From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E67FC4743C for ; Mon, 21 Jun 2021 12:10:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB2E860FDB for ; Mon, 21 Jun 2021 12:10:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB2E860FDB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7566389F3C; Mon, 21 Jun 2021 12:10:52 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 282AF89F3C for ; Mon, 21 Jun 2021 12:10:51 +0000 (UTC) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lvIlN-0004Jv-Ob; Mon, 21 Jun 2021 14:10:49 +0200 Message-ID: Subject: Re: [PATCH] drm: mxsfb: Disable overlay plane support for i.MX8MM/i.MX8MN From: Lucas Stach To: Marek Vasut , dri-devel@lists.freedesktop.org Date: Mon, 21 Jun 2021 14:10:48 +0200 In-Reply-To: <20210620224834.189411-1-marex@denx.de> References: <20210620224834.189411-1-marex@denx.de> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.1 (3.40.1-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Abrecht , Emil Velikov , ch@denx.de, Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Am Montag, dem 21.06.2021 um 00:48 +0200 schrieb Marek Vasut: > The iMX8MM and iMX8MN do not support the overlay plane, so they > are MXSFB V4. Add the compatible strings to reflect this. Note > that iMX8MQ does support the overlay plane, so it is MXSFB V6. Do we need this compatible in the driver? If there are no other changes known at this time, shouldn't we be able to just specify "fsl,imx28- lcdif" as the fallback compatible in the DT, besides the imx8m* specific ones? Regards, Lucas > > Signed-off-by: Marek Vasut > Cc: Daniel Abrecht > Cc: Emil Velikov > Cc: Laurent Pinchart > Cc: Lucas Stach > Cc: Stefan Agner > --- > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c > index c277d3f61a5e..0ae4a3553304 100644 > --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c > +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c > @@ -308,6 +308,8 @@ static const struct of_device_id mxsfb_dt_ids[] = { > { .compatible = "fsl,imx23-lcdif", .data = &mxsfb_devdata[MXSFB_V3], }, > { .compatible = "fsl,imx28-lcdif", .data = &mxsfb_devdata[MXSFB_V4], }, > { .compatible = "fsl,imx6sx-lcdif", .data = &mxsfb_devdata[MXSFB_V6], }, > + { .compatible = "fsl,imx8mm-lcdif", .data = &mxsfb_devdata[MXSFB_V4], }, > + { .compatible = "fsl,imx8mn-lcdif", .data = &mxsfb_devdata[MXSFB_V4], }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, mxsfb_dt_ids);