From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D29FC433EF for ; Mon, 27 Jun 2022 09:30:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233348AbiF0Jak (ORCPT ); Mon, 27 Jun 2022 05:30:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233795AbiF0Jaj (ORCPT ); Mon, 27 Jun 2022 05:30:39 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 316C318A for ; Mon, 27 Jun 2022 02:30:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1656322239; x=1687858239; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=2TAk1HTirqWaRmYwpXIm8GXh5upucONd8Hs6TrcmmQI=; b=T16Cbd7oWV518/rAf+w8MpwBgq4BHPBKKjm8Xzcoqr2m8xD+JUmT0Vlx aAhurgvBbMQyWkUHdzrz9QY0KDVAYYwyg0vhnUjVnckW0STsxgn25Ive0 9Mt03tu8dAIGW9kK54m7txMaSnM9bk6ibQw81pi/fYYYWDG+COiKLgVm5 c=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-01.qualcomm.com with ESMTP; 27 Jun 2022 02:30:38 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2022 02:30:38 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Mon, 27 Jun 2022 02:30:38 -0700 Received: from [10.216.28.64] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Mon, 27 Jun 2022 02:30:36 -0700 Message-ID: Date: Mon, 27 Jun 2022 15:00:33 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] pinctrl: qcom: sc7280: Fix compile bug Content-Language: en-US To: Linus Walleij , CC: Stephen Boyd References: <20220627092425.98730-1-linus.walleij@linaro.org> From: Srinivasa Rao Mandadapu Organization: Qualcomm In-Reply-To: <20220627092425.98730-1-linus.walleij@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 6/27/2022 2:54 PM, Linus Walleij wrote: Thanks for Your Support Linus. > The idea was right but the code was breaking in next. > I assume some unstaged commit was involed. Fix it up. > > Cc: Srinivasa Rao Mandadapu > Cc: Stephen Boyd > Fixes: 36fe26843d6d ("pinctrl: qcom: sc7280: Add clock optional check for ADSP bypass targets") > Signed-off-by: Linus Walleij > --- > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c > index b3d4244a5266..b5d1b996c454 100644 > --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c > +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c > @@ -388,7 +388,8 @@ int lpi_pinctrl_probe(struct platform_device *pdev) > pctrl->data = data; > pctrl->dev = &pdev->dev; > > - data->is_clk_optional = of_property_read_bool(np, "qcom,adsp-bypass-mode"); > + data->is_clk_optional = of_property_read_bool(dev->of_node, > + "qcom,adsp-bypass-mode"); There is another problem with this patch.  As lpi_pinctrl_variant_data is const type,  unable to update this variable. So I have posted the fix patch series v5. Please check and let me me if anything to be done. > > pctrl->clks[0].id = "core"; > pctrl->clks[1].id = "audio";