From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Subject: Re: [PATCH v3 1/2] examples/ipsec-secgw: add
 configuration file support
Date: Tue, 19 Jul 2016 09:19:43 +0100
Message-ID: <fdacf328-77c2-aef6-7cd1-c3b7c983e5c9@intel.com>
References: <1468248213-13100-1-git-send-email-roy.fan.zhang@intel.com>
 <1468316684-220669-1-git-send-email-roy.fan.zhang@intel.com>
 <1468316684-220669-2-git-send-email-roy.fan.zhang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
To: Fan Zhang <roy.fan.zhang@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 4C7562B86
 for <dev@dpdk.org>; Tue, 19 Jul 2016 10:19:45 +0200 (CEST)
In-Reply-To: <1468316684-220669-2-git-send-email-roy.fan.zhang@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/07/2016 10:44, Fan Zhang wrote:
> This patch adds the configuration file support to ipsec_secgw
> sample application. Instead of hard-coded rules, the users can
> specify their own SP, SA, and routing rules in the configuration
> file. An command line option "-f" is added to pass the
> configuration file location to the application.
>
> Configuration item formats:
>
> SP rule format:
> sp <ip_ver> <dir> esp <action> <priority> <src_ip> <dst_ip> \
> <proto> <sport> <dport>
>
> SA rule format:
> sa <dir> <spi> <cipher_algo> <auth_algo> <mode> <src_ip> <dst_ip>

I think we should be able to set the key also on config file for both 
cipher and auth.
Then we can check that the key size is the expected by the chosen 
cipher/auth algo.

I think we should also create and set the xforms dynamically instead of 
static as
they currently are (sa_add_rules function).

Sergio

> Routing rule format:
> rt <ip_ver> <src_ip> <dst_ip> <port>
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---