From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752874AbcGAILU (ORCPT <rfc822;w@1wt.eu>);
	Fri, 1 Jul 2016 04:11:20 -0400
Received: from mail-wm0-f67.google.com ([74.125.82.67]:33938 "EHLO
	mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752102AbcGAILM (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 1 Jul 2016 04:11:12 -0400
Subject: Re: [PATCH v1 04/11] KVM: x86: use u16 for logical VCPU mask in lapic
To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org
References: <20160630205429.16480-1-rkrcmar@redhat.com>
 <20160630205429.16480-5-rkrcmar@redhat.com>
Cc: "Lan, Tianyu" <tianyu.lan@intel.com>, Igor Mammedov <imammedo@redhat.com>,
        Jan Kiszka <jan.kiszka@web.de>, Peter Xu <peterx@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <fdc80f6b-cdb1-b1e6-a843-d5c6a75a69f5@redhat.com>
Date: Fri, 1 Jul 2016 09:56:51 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <20160630205429.16480-5-rkrcmar@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 30/06/2016 22:54, Radim Krčmář wrote:
> @@ -747,7 +745,7 @@ static inline bool kvm_apic_map_get_dest_lapic(struct kvm *kvm, struct kvm_lapic
>  			return true;
>  
>  		lowest = kvm_vector_to_index(irq->vector, hweight16(*bitmap),
> -				bitmap, 16);
> +				(unsigned long *)bitmap, 16);
>  

kvm_vector_to_index's last argument is always 16, so we might as well
omit it and make the third argument u16* too.

Paolo