From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21BA1C433EF for ; Wed, 23 Feb 2022 14:11:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241423AbiBWOLm (ORCPT ); Wed, 23 Feb 2022 09:11:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241415AbiBWOLk (ORCPT ); Wed, 23 Feb 2022 09:11:40 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E7740B153D for ; Wed, 23 Feb 2022 06:11:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645625472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YdcAku5RTM09+5NmAraAro7hs3RJHhvW1fX0az3zUcE=; b=WyWOOlxejBRUUebe7k32lpVJwHpsUkqdmNaErQEzPpKol8JQLs4yHgacL27KeoefkO13P8 RSBSZ/+hv1KbJTLUQotXMXxS5BsULnn63AEpPeDfGwgu/yZSnkLta1MhM6df2ZvVIUGhhF 9Fo2bg6mfiDE/bgcez6YxpswxEYVyM8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-364-15Miu6EtNjqn7LqSAj8OMw-1; Wed, 23 Feb 2022 09:11:08 -0500 X-MC-Unique: 15Miu6EtNjqn7LqSAj8OMw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DC37D835DE2; Wed, 23 Feb 2022 14:11:07 +0000 (UTC) Received: from starship (unknown [10.40.195.190]) by smtp.corp.redhat.com (Postfix) with ESMTP id 405B9866C2; Wed, 23 Feb 2022 14:11:06 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2 03/18] KVM: x86/mmu: WARN if PAE roots linger after kvm_mmu_unload From: Maxim Levitsky To: Paolo Bonzini , Sean Christopherson Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Date: Wed, 23 Feb 2022 16:11:05 +0200 In-Reply-To: References: <20220217210340.312449-1-pbonzini@redhat.com> <20220217210340.312449-4-pbonzini@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2022-02-18 at 18:23 +0100, Paolo Bonzini wrote: > On 2/18/22 18:14, Sean Christopherson wrote: > > Checkpatch doesn't like it, and IMO the existing asserts > > are unnecessary. > > I agree that removing the assertions could be another way to go. > > A third and better one could be to just wait until pae_root is gone. I > have started looking at it but I would like your opinion on one detail; > see question I posted at > https://lore.kernel.org/kvm/7ccb16e5-579e-b3d9-cedc-305152ef9b8f@redhat.com/. > > For now I'll drop this patch. IMHO, the idea of having shadow pages backing the synthetic pages like pae roots, is a very good idea. I hope I get to review that RFC very soon. Best regards, Maxim Levitsky > > Paolo >