From: Bart Van Assche <bvanassche@acm.org>
To: Nikos Tsironis <ntsironis@arrikto.com>,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org
Subject: Re: [PATCH] tcm_loop: Increase maximum request size
Date: Sun, 2 Oct 2022 14:09:26 -0700 [thread overview]
Message-ID: <fde47e5e-119a-54ca-7cf6-5b58552ee2b3@acm.org> (raw)
In-Reply-To: <20220929115504.23806-1-ntsironis@arrikto.com>
On 9/29/22 04:55, Nikos Tsironis wrote:
> Increase the maximum request size for tcm_loop, by setting sg_tablesize
> to SG_MAX_SEGMENTS.
>
> The current value of 256 for sg_tablesize limits the request size to
> PAGE_SIZE * 256, which for 4K pages is 1MiB.
>
> Signed-off-by: Nikos Tsironis <ntsironis@arrikto.com>
> ---
> drivers/target/loopback/tcm_loop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/target/loopback/tcm_loop.c
> index 4407b56aa6d1..6d7c3ebd8613 100644
> --- a/drivers/target/loopback/tcm_loop.c
> +++ b/drivers/target/loopback/tcm_loop.c
> @@ -308,7 +308,7 @@ static struct scsi_host_template tcm_loop_driver_template = {
> .eh_device_reset_handler = tcm_loop_device_reset,
> .eh_target_reset_handler = tcm_loop_target_reset,
> .this_id = -1,
> - .sg_tablesize = 256,
> + .sg_tablesize = SG_MAX_SEGMENTS,
> .max_sectors = 0xFFFF,
> .dma_boundary = PAGE_SIZE - 1,
> .module = THIS_MODULE,
There is more that can be improved for this driver, namely removal of
the dma_boundary parameter and increasing max_sectors.
Thanks,
Bart.
next prev parent reply other threads:[~2022-10-02 21:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 11:55 [PATCH] tcm_loop: Increase maximum request size Nikos Tsironis
2022-10-02 21:09 ` Bart Van Assche [this message]
2022-10-12 14:19 ` Nikos Tsironis
2022-10-12 16:32 ` Bart Van Assche
2022-12-07 10:29 ` Nikos Tsironis
2022-12-07 18:29 ` Mike Christie
2022-12-07 18:35 ` Christoph Hellwig
2022-12-19 14:39 ` Nikos Tsironis
2022-12-19 18:49 ` Mike Christie
2022-12-21 8:30 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fde47e5e-119a-54ca-7cf6-5b58552ee2b3@acm.org \
--to=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ntsironis@arrikto.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.