From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Guo Subject: Re: [PATCH v8 7/7] igb_uio: fix uio release issue for hotplug Date: Wed, 11 Jul 2018 18:01:37 +0800 Message-ID: References: <1498711073-42917-1-git-send-email-jia.guo@intel.com> <1531220607-2977-1-git-send-email-jia.guo@intel.com> <1531220607-2977-8-git-send-email-jia.guo@intel.com> <20180710145254.661da2cf@xeon-e3> <60ae9559-c658-5e2c-ddb3-09c6ababe2f5@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, gaetan.rivet@6wind.com, jingjing.wu@intel.com, thomas@monjalon.net, motih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com, qi.z.zhang@intel.com, shaopeng.he@intel.com, bernard.iremonger@intel.com, arybchenko@solarflare.com, wenzhuo.lu@intel.com, jblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org, helin.zhang@intel.com To: Stephen Hemminger Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id CAF471B53A for ; Wed, 11 Jul 2018 12:01:48 +0200 (CEST) In-Reply-To: <60ae9559-c658-5e2c-ddb3-09c6ababe2f5@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/11/2018 10:46 AM, Jeff Guo wrote: > > > On 7/11/2018 5:52 AM, Stephen Hemminger wrote: >> On Tue, 10 Jul 2018 19:03:27 +0800 >> Jeff Guo wrote: >> >>> When hotplug out device, the device resource will be released in >>> kernel. >>> The fd sys file will disappear, and the irq will be released. At >>> this time, >>> if igb uio driver still try to release this resource, it will cause >>> kernel >>> crash. On the other hand, interrupt disabling do not automatically be >>> processed in kernel. If not handle it, this redundancy and dirty >>> thing will >>> affect the interrupt resource be used by other device. So the igb_uio >>> driver have to check the hotplug status, and the corresponding process >>> should be taken in igb uio driver. >>> >>> This patch propose to add enum rte_udev_state into struct >>> rte_uio_pci_dev >>> of igb uio driver, which will record the state of uio device, such as >>> probed/opened/released/removed. When detect the unexpected removal >>> which >>> cause of hotplug out behavior, it will corresponding disable interrupt >>> resource. For the part of releasement which kernel have already handle, >>> just skip it to avoid double free or null pointer crash issue. >>> >>> Signed-off-by: Jeff Guo >> The PCI hotplug management is an important and potentially error prone >> error of DPDK. >> >> I realize that English is not your native language, but the commit >> messages >> for this are hard to read. Perhaps you can get a volunteer or other >> person >> in the community to reword them. The commit logs and comments contain >> important information about the documentation of the code. > > yes, i think that it might not be the whole thing to let you confused > except something specific. But definitely it is my task to let > reviewer most easily know what i want to propose before they will ack it, > especial for some complex case. let's try my best for check my word. I > am also planning to go to more native English country and great > conference study, anyway to improve my word : ) > >> How does VFIO handle hotplug? We should direct all users to use VFIO >> since it is supported and secure. Igb uio has always been a slightly >> dangerous (as they say "running with scissors") way of accessing >> devices. > > You exposure VFIO here to replace igo uio, maybe we should check if it > is optional or not. > If we can fix all igb_uio issue it should be optional, if only vfio > show stable we should go to vfio only. > What other else guy comment here? Plus, the pci vfio hotplug enabling is still on the next plan, since the different framework between vifo and uio for uevent process. Per vfio, when user space control it will holding the resource so the uevent will be blocked to sent out from kernel. Anyway that should be another story. We hope this patch set just fix hotplug failure issue for igb uio case.