From: Shawn Lin <shawn.lin@rock-chips.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Wolfram Sang <wsa@the-dreams.de>,
shawn.lin@rock-chips.com, Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: Re: [PATCH v3] mmc: block: prevent propagating R1_OUT_OF_RANGE for open-ending mode
Date: Fri, 18 Aug 2017 09:03:04 +0800 [thread overview]
Message-ID: <fdf88986-aefc-a4c1-c340-2b5ad89616f4@rock-chips.com> (raw)
In-Reply-To: <20170817133413.GD7608@dragon>
On 2017/8/17 21:34, Shawn Guo wrote:
> On Thu, Aug 17, 2017 at 12:40:47PM +0200, Wolfram Sang wrote:
>> Hi Shawn,
>>
>> On Wed, Aug 16, 2017 at 09:11:41AM +0800, Shawn Lin wrote:
>>> We to some extent should tolerate R1_OUT_OF_RANGE for open-ending
>>> mode as it is expected behaviour and most of the backup partition
>>> tables should be located near some of the last blocks which will
>>> always make open-ending read exceed the capacity of cards.
>>>
>>> Fixes: 9820a5b11101 ("mmc: core: for data errors, take response of stop cmd into account")
>>> Fixes: a04e6bae9e6f ("mmc: core: check also R1 response for stop commands")
>>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>>>
>>> Tested-by: Shawn Guo <shawnguo@kernel.org>
>>> Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>
>> I'd think these Tested-by should be dropped. We changed the patch quite
>> a bit meanwhile and I am quite sure Shimoda-san didn't test this new
>> version of the patch. Dunno about Shawn. Hopefully they have time to
>> re-test?
>
> I just re-tested it on Hikey, so my Tested-by tag can be kept.
Great! Thanks for testing it again!
>
> Shawn
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
next prev parent reply other threads:[~2017-08-18 1:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 1:11 [PATCH v3] mmc: block: prevent propagating R1_OUT_OF_RANGE for open-ending mode Shawn Lin
2017-08-17 10:40 ` Wolfram Sang
2017-08-17 13:34 ` Shawn Guo
2017-08-18 1:03 ` Shawn Lin [this message]
2017-08-18 1:02 ` Shawn Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdf88986-aefc-a4c1-c340-2b5ad89616f4@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=linux-mmc@vger.kernel.org \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa@the-dreams.de \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.