From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Guo, Jia" Subject: Re: [PATCH v7 1/2] eal: add uevent monitor for hot plug Date: Wed, 10 Jan 2018 17:32:51 +0800 Message-ID: References: <1509567405-27439-3-git-send-email-jia.guo@intel.com> <3539603.0DoXzmkF5E@xps> <01BA8470C017D6468C8290E4B9C5E1E83B2D1493@shsmsx102.ccr.corp.intel.com> <2285928.Pr9jqWPkcR@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Mordechay Haimovsky , dev@dpdk.org, "stephen@networkplumber.org" , "Richardson, Bruce" , "Yigit, Ferruh" , "gaetan.rivet@6wind.com" , "Ananyev, Konstantin" , "shreyansh.jain@nxp.com" , "Wu, Jingjing" , "Zhang, Helin" , "Van Haaren, Harry" To: Thomas Monjalon Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 3F5C61B1B7 for ; Wed, 10 Jan 2018 10:32:56 +0100 (CET) In-Reply-To: <2285928.Pr9jqWPkcR@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/9/2018 9:44 PM, Thomas Monjalon wrote: > 09/01/2018 13:08, Guo, Jia: >> Your comments about split it totally make sense ,no doubt that, but my question is that if split api with the funcational , so the function part should be set null implement or stake. Any other good idea or tip for that. > Yes when introducing the callback API first, there will be no > implementation, so the callbacks are not called. > If needed you can have some empty functions. i think we all want to make review more effective in any good way, so the v9 patch set have been sent, please check.