All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hanna Reitz <hreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Thomas Huth <thuth@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH v2 0/3] iotests: Check for zstd support
Date: Wed, 23 Mar 2022 11:46:26 +0100	[thread overview]
Message-ID: <fe028770-f420-905d-84da-04709dfb51bc@redhat.com> (raw)
In-Reply-To: <20220302124540.45083-1-hreitz@redhat.com>

On 02.03.22 13:45, Hanna Reitz wrote:
> Hi,
>
> v1 cover letter:
>
> https://lists.nongnu.org/archive/html/qemu-devel/2022-02/msg04592.html
>
> We have two tests (as far as I know) that use compression_type=zstd for
> qcow2 but do not check whether that is actually supported.  Thomas
> reported this for 065, but it’s also the case for 303.
>
> This series makes 303 be skipped when zstd is not compiled in, and has
> 065 use zlib for each of its test cases then (it was made to use zstd
> just to improve on coverage, so using zlib as a fallback is perfectly
> fine).

Thanks a lot for the quick replies to my ping!

Regrettably, I forgot to consider that John’s recent changes would 
remove qemu_img_pipe_and_status(), which is used in patch 1...  I’m 
sorry, but I’ll have to send a v3. :/

Hanna



      parent reply	other threads:[~2022-03-23 10:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-02 12:45 [PATCH v2 0/3] iotests: Check for zstd support Hanna Reitz
2022-03-02 12:45 ` [PATCH v2 1/3] iotests.py: Add supports_qcow2_zstd_compression() Hanna Reitz
2022-03-02 12:45 ` [PATCH v2 2/3] iotests/065: Check for zstd support Hanna Reitz
2022-03-02 12:45 ` [PATCH v2 3/3] iotests/303: " Hanna Reitz
2022-03-22  9:48 ` [PATCH v2 0/3] iotests: " Hanna Reitz
2022-03-22 10:50   ` Vladimir Sementsov-Ogievskiy
2022-03-22  9:56 ` Thomas Huth
2022-03-23 10:46 ` Hanna Reitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe028770-f420-905d-84da-04709dfb51bc@redhat.com \
    --to=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.