From: Andy Walls <awalls@md.metrocast.net>
To: Jean Delvare <jdelvare@suse.de>, linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
Fabio Belavenuto <belavenuto@gmail.com>
Subject: Re: [PATCH] [media] tea5764: Fix module parameter permissions
Date: Fri, 08 Jul 2011 06:34:38 -0400 [thread overview]
Message-ID: <fe03786e-e629-4260-b637-80a58ce37728@email.android.com> (raw)
In-Reply-To: <201107081100.37406.jdelvare@suse.de>
Jean Delvare <jdelvare@suse.de> wrote:
>The third parameter of module_param is supposed to represent sysfs
>file permissions. A value of "1" leads to the following:
>
>$ ls -l /sys/module/radio_tea5764/parameters/
>total 0
>---------x 1 root root 4096 Jul 8 09:17 use_xtal
>
>I am changing it to "0" to align with the other module parameters in
>this driver.
>
>Signed-off-by: Jean Delvare <jdelvare@suse.de>
>Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
>Cc: Fabio Belavenuto <belavenuto@gmail.com>
>---
> drivers/media/radio/radio-tea5764.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>--- linux-3.0-rc6.orig/drivers/media/radio/radio-tea5764.c 2011-05-20
>10:41:19.000000000 +0200
>+++ linux-3.0-rc6/drivers/media/radio/radio-tea5764.c 2011-07-08
>09:15:16.000000000 +0200
>@@ -596,7 +596,7 @@ MODULE_AUTHOR(DRIVER_AUTHOR);
> MODULE_DESCRIPTION(DRIVER_DESC);
> MODULE_LICENSE("GPL");
>
>-module_param(use_xtal, int, 1);
>+module_param(use_xtal, int, 0);
> MODULE_PARM_DESC(use_xtal, "Chip have a xtal connected in board");
> module_param(radio_nr, int, 0);
> MODULE_PARM_DESC(radio_nr, "video4linux device number to use");
>
>--
>Jean Delvare
>Suse L3
>--
>To unsubscribe from this list: send the line "unsubscribe linux-media"
>in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
To whomever might know:
Was the intent of the "1" to set the default value of the parameter?
Regards,
Andy
next prev parent reply other threads:[~2011-07-08 10:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 9:00 [PATCH] [media] tea5764: Fix module parameter permissions Jean Delvare
2011-07-08 10:34 ` Andy Walls [this message]
2011-07-11 11:54 ` Jean Delvare
2011-07-11 12:25 ` Fabio Belavenuto
2011-07-13 14:35 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe03786e-e629-4260-b637-80a58ce37728@email.android.com \
--to=awalls@md.metrocast.net \
--cc=belavenuto@gmail.com \
--cc=jdelvare@suse.de \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.