From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BBECC433E0 for ; Mon, 15 Mar 2021 13:02:04 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7BD5564EB3 for ; Mon, 15 Mar 2021 13:02:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BD5564EB3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Dzc551Qctz2yyh for ; Tue, 16 Mar 2021 00:02:01 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=csgroup.eu (client-ip=93.17.236.30; helo=pegase1.c-s.fr; envelope-from=christophe.leroy@csgroup.eu; receiver=) Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Dzc4j4qKcz2xZD for ; Tue, 16 Mar 2021 00:01:40 +1100 (AEDT) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4Dzc4X2pKBz9tyRs; Mon, 15 Mar 2021 14:01:32 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id JijiRi72Cvcq; Mon, 15 Mar 2021 14:01:32 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4Dzc4W73j6z9tyRk; Mon, 15 Mar 2021 14:01:31 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 3974C8B779; Mon, 15 Mar 2021 14:01:37 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id Lls54DDK7J70; Mon, 15 Mar 2021 14:01:37 +0100 (CET) Received: from [172.25.230.100] (po15451.idsi0.si.c-s.fr [172.25.230.100]) by messagerie.si.c-s.fr (Postfix) with ESMTP id CDC4A8B776; Mon, 15 Mar 2021 14:01:36 +0100 (CET) Subject: Re: [PATCH] powerpc: Fix missing prototype problems for "arch/powerpc/kernel/setup_64.c" To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , "heying (H)" , mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, npiggin@gmail.com, dja@axtens.net, akpm@linux-foundation.org, rppt@kernel.org, aneesh.kumar@linux.ibm.com References: <20210315120444.215905-1-heying24@huawei.com> <6eb1925c-a3a1-f062-29da-3a7fa946505c@csgroup.eu>

From: Christophe Leroy Message-ID: Date: Mon, 15 Mar 2021 14:01:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: johnny.chenyi@huawei.com, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Le 15/03/2021 à 13:57, Cédric Le Goater a écrit : > On 3/15/21 1:48 PM, heying (H) wrote: >> >> 在 2021/3/15 20:17, Christophe Leroy 写道: >>> You subject doesn't match the content of the patch. >> OK. I'll adapt that. >>> >>> Le 15/03/2021 à 13:04, He Ying a écrit : >>>> The variables 'uaccess_fulsh' and 'entry_flush' are not referenced >>>> outside the file. So define them as static to avoid the warnings. >>>> >>>> And add a prototype for the function 'panic_smp_self_stop' for the >>>> same purpose. >>>> >>>> Sparse also warns that 'rfi_flush' should be static. However, it's >>>> referenced outside the file. >>> >>> To clear that warning, you have to include asm/security_features.h, rfi_flush is declared there. >> Do you mean that I should include this header in arch/powerpc/kernel/setup_64.c? > > yes. > >>> >>>> >>>> The warnings about the file reported by sparse are as follows: >>>> arch/powerpc/kernel/setup_64.c:422:6: warning: symbol 'panic_smp_self_stop' was not declared. Should it be static? >>>> arch/powerpc/kernel/setup_64.c:951:6: warning: symbol 'rfi_flush' was not declared. Should it be static? >>>> arch/powerpc/kernel/setup_64.c:952:6: warning: symbol 'entry_flush' was not declared. Should it be static? >>>> arch/powerpc/kernel/setup_64.c:953:6: warning: symbol 'uaccess_flush' was not declared. Should it be static? >>>> >>>> Reported-by: Hulk Robot >>>> Signed-off-by: He Ying >>>> --- >>>> arch/powerpc/kernel/setup_64.c | 6 ++++-- >>>> 1 file changed, 4 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c >>>> index 560ed8b975e7..603aacd8527b 100644 >>>> --- a/arch/powerpc/kernel/setup_64.c >>>> +++ b/arch/powerpc/kernel/setup_64.c >>>> @@ -71,6 +71,8 @@ >>>> #include "setup.h" >>>> +extern void panic_smp_self_stop(void); >>>> + >>> >>> For function prototypes 'extern' is unneeded and deprecated. >>> >>> And function prototypes should go in an header file. >>> >>> panic_smp_self_stop() is called from kernel/panic.c , it should be declared in one of the generic linux header files I think. >> Yes, you're right. But I have no idea which header it should be declared in. May I have your suggestions? > > arch/powerpc/include/asm/bug.h looks like a good place. Why declaring it in a powerpc header ? It's a weak function defined in core part of kernel (kernel/panic.c). I think it should go in a common header, just like for instance arch_thaw_secondary_cpus_begin() > > C. > >>> >>>> int spinning_secondaries; >>>> u64 ppc64_pft_size; >>>> @@ -949,8 +951,8 @@ static bool no_rfi_flush; >>>> static bool no_entry_flush; >>>> static bool no_uaccess_flush; >>>> bool rfi_flush; >>>> -bool entry_flush; >>>> -bool uaccess_flush; >>>> +static bool entry_flush; >>>> +static bool uaccess_flush; >>>> DEFINE_STATIC_KEY_FALSE(uaccess_flush_key); >>>> EXPORT_SYMBOL(uaccess_flush_key); >>>> >>> .