All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Wanpeng Li <kernellwp@gmail.com>, Yuyang Du <yuyang.du@intel.com>,
	Morten Rasmussen <Morten.Rasmussen@arm.com>,
	Linaro Kernel Mailman List <linaro-kernel@lists.linaro.org>,
	Paul Turner <pjt@google.com>,
	Benjamin Segall <bsegall@google.com>
Subject: Re: [PATCH 1/7 v4] sched: factorize attach entity
Date: Wed, 12 Oct 2016 12:12:04 +0100	[thread overview]
Message-ID: <fe0f79fa-9e94-b153-4c20-bccf087bd001@arm.com> (raw)
In-Reply-To: <CAKfTPtCh4Hrb5rVVdfS2G29imHkYLwyRCHc6n-8h_pkO3gUuVg@mail.gmail.com>

On 12/10/16 11:59, Vincent Guittot wrote:
> On 7 October 2016 at 01:11, Vincent Guittot <vincent.guittot@linaro.org> wrote:
>>
>> On 5 October 2016 at 11:38, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
>>> On 09/26/2016 01:19 PM, Vincent Guittot wrote:

[...]

>>>> -static void attach_task_cfs_rq(struct task_struct *p)
>>>> +static void attach_entity_cfs_rq(struct sched_entity *se)
>>>>  {
>>>> -     struct sched_entity *se = &p->se;
>>>>       struct cfs_rq *cfs_rq = cfs_rq_of(se);
>>>
>>>
>>> Both callers of attach_entity_cfs_rq() already use cfs_rq_of(se). You
>>> could pass it into attach_entity_cfs_rq().
>>
>> Yes that would make sense
> 
> In fact there is a 3rd caller online_fair_sched_group which calls
> attach_entity_cfs_rq and doesn't already use  cfs_rq_of(se) so i
> wonder if it's worth doing the interface change.

OK, this change gets in w/ patch 6/7. Yeah, skip it, it's not so important.

  reply	other threads:[~2016-10-12 11:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-26 12:19 [PATCH 0/7 v4] sched: reflect sched_entity move into task_group's load Vincent Guittot
2016-09-26 12:19 ` [PATCH 1/7 v4] sched: factorize attach entity Vincent Guittot
2016-10-05  9:38   ` Dietmar Eggemann
2016-10-06 23:11     ` Vincent Guittot
2016-10-12 10:59       ` Vincent Guittot
2016-10-12 11:12         ` Dietmar Eggemann [this message]
2016-09-26 12:19 ` [PATCH 2/7 v4] sched: fix hierarchical order in rq->leaf_cfs_rq_list Vincent Guittot
2016-09-26 12:19 ` [PATCH 3/7 v4] sched: factorize PELT update Vincent Guittot
2016-09-26 12:19 ` [PATCH 4/7 v4] sched: propagate load during synchronous attach/detach Vincent Guittot
2016-09-26 12:19 ` [PATCH 5/7 v4] sched: propagate asynchrous detach Vincent Guittot
2016-10-12 15:03   ` Dietmar Eggemann
2016-10-12 15:45     ` Vincent Guittot
2016-10-12 16:18       ` Dietmar Eggemann
2016-09-26 12:19 ` [PATCH 6/7 v4] sched: fix task group initialization Vincent Guittot
2016-09-26 12:19 ` [PATCH 7/7 v4] sched: fix wrong utilization accounting when switching to fair class Vincent Guittot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe0f79fa-9e94-b153-4c20-bccf087bd001@arm.com \
    --to=dietmar.eggemann@arm.com \
    --cc=Morten.Rasmussen@arm.com \
    --cc=bsegall@google.com \
    --cc=kernellwp@gmail.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    --cc=vincent.guittot@linaro.org \
    --cc=yuyang.du@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.