From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56FDCC433DF for ; Fri, 15 May 2020 15:52:48 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 272B6206C0 for ; Fri, 15 May 2020 15:52:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="DsoVeDZT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 272B6206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jZcdT-0003zp-6V; Fri, 15 May 2020 15:52:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jZcdS-0003zk-2a for xen-devel@lists.xenproject.org; Fri, 15 May 2020 15:52:30 +0000 X-Inumbo-ID: 14506526-96c4-11ea-ae69-bc764e2007e4 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 14506526-96c4-11ea-ae69-bc764e2007e4; Fri, 15 May 2020 15:52:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1589557949; h=subject:from:to:cc:references:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=LqOMgwBCraexW+x7DyWMRZYdT+fJD87gTxi9XiSBgi4=; b=DsoVeDZTDoNNW9T9qhZpPgCdJstIVgALrYZiak0GImRfyT+dSd5DO3mX GB11Jv3sP/5g41SbDTNafcTCZI5RdKofYM4g13Ktz0H6412ffMCu2vgWm aPJFjvrIDhlx3hQJZtvI7TY+k79KxMTOiMtdKyYJPVGAZ0Gxgwple9Wx4 o=; Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com; dmarc=pass (p=none dis=none) d=citrix.com IronPort-SDR: TIBIMGfxpy5XlkH/PD9FtukFDItMTCgr0iPsjmHbKlkHhK/SGR3c28LsiAT60nOYjq0vt0Mm7Y sHaZBoBW8M5oPzP26eZVDzneEuZz/JW2znJx6PRgZoRux2jTczclDeimrr1s5vIV6YrWFVh+21 sTQ77LK7jiSomjUO23ebRLnH54JloAp8geGjb/1cG7pn4wziw0sYsF18toLZ0Ct1H+vb62FZfv +SWNdv+jqEUlHsEUSJlhjvzZ6yWj/K0Zr8pATE9bqezyham03yvIUntCHIA7Kn1/ueLtkCAJZL /XM= X-SBRS: 2.7 X-MesageID: 17672619 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,395,1583211600"; d="scan'208";a="17672619" Subject: Re: [PATCH v2 6/6] x86/mem-paging: consistently use gfn_t From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" References: Message-ID: Date: Fri, 15 May 2020 16:52:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 15/05/2020 16:49, Andrew Cooper wrote: > On 23/04/2020 09:39, Jan Beulich wrote: >> --- a/xen/arch/x86/mm/hap/guest_walk.c >> +++ b/xen/arch/x86/mm/hap/guest_walk.c >> @@ -68,7 +68,7 @@ unsigned long hap_p2m_ga_to_gfn(GUEST_PA >> *pfec = PFEC_page_paged; >> if ( top_page ) >> put_page(top_page); >> - p2m_mem_paging_populate(p2m->domain, cr3 >> PAGE_SHIFT); >> + p2m_mem_paging_populate(p2m->domain, _gfn(PFN_DOWN(cr3))); > addr_to_gfn() Sorry - gaddr_to_gfn() ~Andrew > > Otherwise, Acked-by: Andrew Cooper >