From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B7B7C433DF for ; Fri, 7 Aug 2020 13:12:25 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56F472224D for ; Fri, 7 Aug 2020 13:12:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56F472224D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k42AD-0008Uw-AO; Fri, 07 Aug 2020 13:12:01 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k42AC-0008Ur-Gz for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 13:12:00 +0000 X-Inumbo-ID: c5945bda-4e7b-437b-82c1-565938ada16d Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c5945bda-4e7b-437b-82c1-565938ada16d; Fri, 07 Aug 2020 13:11:59 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 322AAAF5D; Fri, 7 Aug 2020 13:12:17 +0000 (UTC) Subject: Re: [PATCH 11/14] kernel-doc: public/version.h To: Stefano Stabellini References: <20200806234933.16448-11-sstabellini@kernel.org> From: Jan Beulich Message-ID: Date: Fri, 7 Aug 2020 15:12:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200806234933.16448-11-sstabellini@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, xen-devel@lists.xenproject.org, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07.08.2020 01:49, Stefano Stabellini wrote: > --- a/xen/include/public/version.h > +++ b/xen/include/public/version.h > @@ -30,19 +30,33 @@ > > #include "xen.h" > > -/* NB. All ops return zero on success, except XENVER_{version,pagesize} > - * XENVER_{version,pagesize,build_id} */ > +/** > + * DOC: XENVER_* > + * > + * NB. All ops return zero on success, except for: > + * > + * - XENVER_{version,pagesize} > + * - XENVER_{version,pagesize,build_id} You make the mistake made by 460d24188d81 even more obvious, instead of fixing it (by removing the first of these two lines). Jan