From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD932C04FF3 for ; Mon, 24 May 2021 17:48:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D86661400 for ; Mon, 24 May 2021 17:48:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233351AbhEXRto (ORCPT ); Mon, 24 May 2021 13:49:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:37094 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232744AbhEXRto (ORCPT ); Mon, 24 May 2021 13:49:44 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 69481613FC; Mon, 24 May 2021 17:48:15 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1llEgX-003Ixg-Iu; Mon, 24 May 2021 18:48:13 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 24 May 2021 18:48:13 +0100 From: Marc Zyngier To: Zenghui Yu Cc: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, kernel-team@android.com, Hector Martin Subject: Re: [PATCH v3 7/9] KVM: arm64: timer: Refactor IRQ configuration In-Reply-To: <9f28e15b-26d0-5d3e-8f0e-8026ece536e0@huawei.com> References: <20210510134824.1910399-1-maz@kernel.org> <20210510134824.1910399-8-maz@kernel.org> <9f28e15b-26d0-5d3e-8f0e-8026ece536e0@huawei.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, kernel-team@android.com, marcan@marcan.st X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2021-05-14 13:46, Zenghui Yu wrote: > On 2021/5/10 21:48, Marc Zyngier wrote: >> As we are about to add some more things to the timer IRQ >> configuration, move this code out of the main timer init code >> into its own set of functions. >> >> No functional changes. >> >> Signed-off-by: Marc Zyngier >> --- >> arch/arm64/kvm/arch_timer.c | 61 >> ++++++++++++++++++++++--------------- >> 1 file changed, 37 insertions(+), 24 deletions(-) >> >> diff --git a/arch/arm64/kvm/arch_timer.c b/arch/arm64/kvm/arch_timer.c >> index e2288b6bf435..7fa4f446456a 100644 >> --- a/arch/arm64/kvm/arch_timer.c >> +++ b/arch/arm64/kvm/arch_timer.c >> @@ -973,6 +973,39 @@ static int kvm_timer_dying_cpu(unsigned int cpu) >> return 0; >> } >> +static void kvm_irq_fixup_flags(unsigned int virq, u32 *flags) >> +{ >> + *flags = irq_get_trigger_type(virq); >> + if (*flags != IRQF_TRIGGER_HIGH && *flags != IRQF_TRIGGER_LOW) { >> + kvm_err("Invalid trigger for timer IRQ%d, assuming level low\n", >> + virq); >> + *flags = IRQF_TRIGGER_LOW; >> + } >> +} >> + >> +static int kvm_irq_init(struct arch_timer_kvm_info *info) >> +{ >> + struct irq_domain *domain = NULL; >> + struct fwnode_handle *fwnode; >> + struct irq_data *data; > > Shouldn't this belong to patch #8? Yup. Now moved. Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0731DC04FF3 for ; Mon, 24 May 2021 17:48:21 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 6DD9161403 for ; Mon, 24 May 2021 17:48:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DD9161403 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 0EA4C4B156; Mon, 24 May 2021 13:48:20 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sHdmeiHWeuRo; Mon, 24 May 2021 13:48:19 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 1B1E94B14C; Mon, 24 May 2021 13:48:19 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 52C894B133 for ; Mon, 24 May 2021 13:48:17 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VvqNVbCgneX9 for ; Mon, 24 May 2021 13:48:16 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 5C3784B127 for ; Mon, 24 May 2021 13:48:16 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 69481613FC; Mon, 24 May 2021 17:48:15 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1llEgX-003Ixg-Iu; Mon, 24 May 2021 18:48:13 +0100 MIME-Version: 1.0 Date: Mon, 24 May 2021 18:48:13 +0100 From: Marc Zyngier To: Zenghui Yu Subject: Re: [PATCH v3 7/9] KVM: arm64: timer: Refactor IRQ configuration In-Reply-To: <9f28e15b-26d0-5d3e-8f0e-8026ece536e0@huawei.com> References: <20210510134824.1910399-1-maz@kernel.org> <20210510134824.1910399-8-maz@kernel.org> <9f28e15b-26d0-5d3e-8f0e-8026ece536e0@huawei.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, kernel-team@android.com, marcan@marcan.st X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: Hector Martin , kernel-team@android.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 2021-05-14 13:46, Zenghui Yu wrote: > On 2021/5/10 21:48, Marc Zyngier wrote: >> As we are about to add some more things to the timer IRQ >> configuration, move this code out of the main timer init code >> into its own set of functions. >> >> No functional changes. >> >> Signed-off-by: Marc Zyngier >> --- >> arch/arm64/kvm/arch_timer.c | 61 >> ++++++++++++++++++++++--------------- >> 1 file changed, 37 insertions(+), 24 deletions(-) >> >> diff --git a/arch/arm64/kvm/arch_timer.c b/arch/arm64/kvm/arch_timer.c >> index e2288b6bf435..7fa4f446456a 100644 >> --- a/arch/arm64/kvm/arch_timer.c >> +++ b/arch/arm64/kvm/arch_timer.c >> @@ -973,6 +973,39 @@ static int kvm_timer_dying_cpu(unsigned int cpu) >> return 0; >> } >> +static void kvm_irq_fixup_flags(unsigned int virq, u32 *flags) >> +{ >> + *flags = irq_get_trigger_type(virq); >> + if (*flags != IRQF_TRIGGER_HIGH && *flags != IRQF_TRIGGER_LOW) { >> + kvm_err("Invalid trigger for timer IRQ%d, assuming level low\n", >> + virq); >> + *flags = IRQF_TRIGGER_LOW; >> + } >> +} >> + >> +static int kvm_irq_init(struct arch_timer_kvm_info *info) >> +{ >> + struct irq_domain *domain = NULL; >> + struct fwnode_handle *fwnode; >> + struct irq_data *data; > > Shouldn't this belong to patch #8? Yup. Now moved. Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A991C2B9F8 for ; Tue, 25 May 2021 00:41:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B935611CD for ; Tue, 25 May 2021 00:41:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B935611CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CUb+rM/pbGz1A7tvVvvWI+ACW1KAF4s2tM3vJ7j82mo=; b=sfldZ+Ah/flYx7vKqOr2opihG oFSwwykb4BGGp2s+LdHWh5cmiJfwXfXg9ORNNtC2u3Y1qYp49PMpKA6l7/mZntUYh9qyJK0AUVJv2 VfyjDQ6NxbWBvRb382hZ0910lB81hJzAjgEu0l4uMsjYQg0XEsfixCDOlm3cDZQZ80j3kshy+NgSE 4ZafLGrX/xUHxLK7d9zMKDIVNomVPD/7a5ERut82aMi1oLl4E6dd/wsgva/j/PXJvCOXUXyzo83I1 ut55c36SXy+KbxJve50CMzpOLx2kAxy2NV9r8dRod8JOb692vvPB/Rsjj0+iwmgjDXDVcP73FBkZM GbvbZtvnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llL75-002bPS-9Z; Tue, 25 May 2021 00:40:03 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1llEga-001L9Q-A8 for linux-arm-kernel@lists.infradead.org; Mon, 24 May 2021 17:48:17 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 69481613FC; Mon, 24 May 2021 17:48:15 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1llEgX-003Ixg-Iu; Mon, 24 May 2021 18:48:13 +0100 MIME-Version: 1.0 Date: Mon, 24 May 2021 18:48:13 +0100 From: Marc Zyngier To: Zenghui Yu Cc: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, kernel-team@android.com, Hector Martin Subject: Re: [PATCH v3 7/9] KVM: arm64: timer: Refactor IRQ configuration In-Reply-To: <9f28e15b-26d0-5d3e-8f0e-8026ece536e0@huawei.com> References: <20210510134824.1910399-1-maz@kernel.org> <20210510134824.1910399-8-maz@kernel.org> <9f28e15b-26d0-5d3e-8f0e-8026ece536e0@huawei.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, kernel-team@android.com, marcan@marcan.st X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_104816_426277_0DD48434 X-CRM114-Status: GOOD ( 14.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-05-14 13:46, Zenghui Yu wrote: > On 2021/5/10 21:48, Marc Zyngier wrote: >> As we are about to add some more things to the timer IRQ >> configuration, move this code out of the main timer init code >> into its own set of functions. >> >> No functional changes. >> >> Signed-off-by: Marc Zyngier >> --- >> arch/arm64/kvm/arch_timer.c | 61 >> ++++++++++++++++++++++--------------- >> 1 file changed, 37 insertions(+), 24 deletions(-) >> >> diff --git a/arch/arm64/kvm/arch_timer.c b/arch/arm64/kvm/arch_timer.c >> index e2288b6bf435..7fa4f446456a 100644 >> --- a/arch/arm64/kvm/arch_timer.c >> +++ b/arch/arm64/kvm/arch_timer.c >> @@ -973,6 +973,39 @@ static int kvm_timer_dying_cpu(unsigned int cpu) >> return 0; >> } >> +static void kvm_irq_fixup_flags(unsigned int virq, u32 *flags) >> +{ >> + *flags = irq_get_trigger_type(virq); >> + if (*flags != IRQF_TRIGGER_HIGH && *flags != IRQF_TRIGGER_LOW) { >> + kvm_err("Invalid trigger for timer IRQ%d, assuming level low\n", >> + virq); >> + *flags = IRQF_TRIGGER_LOW; >> + } >> +} >> + >> +static int kvm_irq_init(struct arch_timer_kvm_info *info) >> +{ >> + struct irq_domain *domain = NULL; >> + struct fwnode_handle *fwnode; >> + struct irq_data *data; > > Shouldn't this belong to patch #8? Yup. Now moved. Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel