From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"dpdklab@iol.unh.edu" <dpdklab@iol.unh.edu>,
"aconole@redhat.com" <aconole@redhat.com>
Cc: "gakhil@marvell.com" <gakhil@marvell.com>,
"Power, Ciara" <ciara.power@intel.com>,
Ali Alnubani <alialnu@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] test: fix crypto_op length for sessionless case
Date: Sat, 3 Jul 2021 01:26:26 +0200 [thread overview]
Message-ID: <fe564d48-4732-6b79-ffeb-1b2a23c61f2f@intel.com> (raw)
In-Reply-To: <PH0PR11MB482489A5D87BEB4ABDCE38E1E81F9@PH0PR11MB4824.namprd11.prod.outlook.com>
On 7/2/2021 7:08 PM, Gujjar, Abhinandan S wrote:
> Hi Aaron/dpdklab,
>
> This patch's CI seems to have lot of false positive!
> Ferruh triggered the re-test sometime back. Now, it is reporting less.
> Could you please check from your end? Thanks!
>
Only a malloc related unit test is still failing, which seems unrelated with the
patch. I am triggering it one more time, third time lucky.
Also after re-run, some tests passing now still shown as fail in the patchwork
checks table. Isn't re-run sending the patchwork test status again?
> Regards
> Abhinandan
>
>
>> -----Original Message-----
>> From: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
>> Sent: Wednesday, June 30, 2021 6:17 PM
>> To: dev@dpdk.org; jerinj@marvell.com
>> Cc: gakhil@marvell.com; Gujjar, Abhinandan S
>> <abhinandan.gujjar@intel.com>; Power, Ciara <ciara.power@intel.com>
>> Subject: [PATCH] test: fix crypto_op length for sessionless case
>>
>> Currently, private_data_offset for the sessionless is computed wrongly which
>> includes extra bytes added because of using sizeof(struct
>> rte_crypto_sym_xform) * 2) instead of (sizeof(union
>> rte_event_crypto_metadata)). Due to this buffer overflow, the corruption was
>> leading to test application crash while freeing the ops mempool.
>>
>> Fixes: 3c2c535ecfc0 ("test: add event crypto adapter auto-test")
>> Reported-by: ciara.power@intel.com
>>
>> Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
>> ---
>> app/test/test_event_crypto_adapter.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/app/test/test_event_crypto_adapter.c
>> b/app/test/test_event_crypto_adapter.c
>> index f689bc1f2..688ac0b2f 100644
>> --- a/app/test/test_event_crypto_adapter.c
>> +++ b/app/test/test_event_crypto_adapter.c
>> @@ -229,7 +229,7 @@ test_op_forward_mode(uint8_t session_less)
>> first_xform = &cipher_xform;
>> sym_op->xform = first_xform;
>> uint32_t len = IV_OFFSET + MAXIMUM_IV_LENGTH +
>> - (sizeof(struct rte_crypto_sym_xform) * 2);
>> + (sizeof(union rte_event_crypto_metadata));
>> op->private_data_offset = len;
>> /* Fill in private data information */
>> rte_memcpy(&m_data.response_info, &response_info, @@ -
>> 424,7 +424,7 @@ test_op_new_mode(uint8_t session_less)
>> first_xform = &cipher_xform;
>> sym_op->xform = first_xform;
>> uint32_t len = IV_OFFSET + MAXIMUM_IV_LENGTH +
>> - (sizeof(struct rte_crypto_sym_xform) * 2);
>> + (sizeof(union rte_event_crypto_metadata));
>> op->private_data_offset = len;
>> /* Fill in private data information */
>> rte_memcpy(&m_data.response_info, &response_info,
>> --
>> 2.25.1
>
next prev parent reply other threads:[~2021-07-02 23:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 12:46 [dpdk-dev] [PATCH] test: fix crypto_op length for sessionless case Abhinandan Gujjar
2021-07-02 17:08 ` Gujjar, Abhinandan S
2021-07-02 23:26 ` Ferruh Yigit [this message]
2021-07-05 6:30 ` Gujjar, Abhinandan S
2021-07-06 16:09 ` Brandon Lo
2021-07-07 14:07 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-07-08 14:12 ` Gujjar, Abhinandan S
2021-07-13 9:11 ` Akhil Goyal
2021-07-18 9:05 ` Gujjar, Abhinandan S
2021-07-18 9:22 ` Gujjar, Abhinandan S
2021-07-18 9:25 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe564d48-4732-6b79-ffeb-1b2a23c61f2f@intel.com \
--to=ferruh.yigit@intel.com \
--cc=abhinandan.gujjar@intel.com \
--cc=aconole@redhat.com \
--cc=alialnu@nvidia.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=dpdklab@iol.unh.edu \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.