From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1ECCC47088 for ; Wed, 26 May 2021 13:32:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87D20613BA for ; Wed, 26 May 2021 13:32:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87D20613BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0935C6E4BB; Wed, 26 May 2021 13:32:55 +0000 (UTC) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1D5EE6E4BB; Wed, 26 May 2021 13:32:54 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id f75-20020a1c1f4e0000b0290171001e7329so525376wmf.1; Wed, 26 May 2021 06:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=YlBMJFk9IU7XFpKBGAdwLecZ23BlfUXVTyQ5htgnqds=; b=gHerwUijsmKZTx4DCmhcXuTnIFvyweNastBkn9ZahCah3iPkN6qssuhEnZPYikpTXk RX22AZNSYo0f9LnQxB+tGHPW7EicBzlz0paibGwJqll459D9GranIBqGDnHUX0cYZncx nZpVupWUHabYgH0UBi7gLLfMRyGCyvETRi0K2w2FEUMDDLvwMI7s21+tKrDI9eeUQ+bu q2ZJ+Vwea2gEB1SOlH0SoO6nRY0IUHfDLbHJpOg0chTfNAgj+6bpACfIzjyNl9xXIZ9w XkKPZvSXQik3WBxDBewoVhH93liltdQM/tFv8G3wAqtIEZXhH07TJdL3qZYWortdJcxX E2HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=YlBMJFk9IU7XFpKBGAdwLecZ23BlfUXVTyQ5htgnqds=; b=mh3+a7JahGQdJ4xiMGl4uSvsoI6yKjf93X+o1G7GbOtB0Ap0KVjEiZwHzJWdqkbZO1 1OFJFWO/3JqJ4cI0pb9dkDECnvCXq+0Z9Ah3FR0C6TYqJlHFhT9KQgFfsbxGcL9fKqw5 1/YyIaN3jBWnASJRL98Vsmt2LqUMNFeuM4YymvRuXbkzQEOooTeWZIgXZZGf4EjNHrT4 ON3orr26NS7i6Hl62migD4qgTmX169uJdFaYc7Z3UQIf/Wr+lw6vskC+rxQ6KhfgpLDL /sZsQOWBDkoIs9cENIAg7NMG0oWTk0qbNjGwTlOo4skNSnE5Jqx0WP5JpEmvgm5wzalq omAw== X-Gm-Message-State: AOAM532lTkM5UhuTC9hlHU3o3j7YLmCn+Wu6yArqhzdJk0I8Mo7TqQy8 hyVs8aHqP2NifI9furh7fZ0= X-Google-Smtp-Source: ABdhPJyaNjBH9aRtWN83y51VC2QaShd89a7j4j98DGf1DzeCXlHUlJkhEhO3F6fRhbwIb39lhclevg== X-Received: by 2002:a7b:cbc4:: with SMTP id n4mr3577903wmi.153.1622035972705; Wed, 26 May 2021 06:32:52 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:1950:35e:cae9:5bed? ([2a02:908:1252:fb60:1950:35e:cae9:5bed]) by smtp.gmail.com with ESMTPSA id x24sm6561252wmi.13.2021.05.26.06.32.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 May 2021 06:32:52 -0700 (PDT) Subject: Re: [Mesa-dev] [PATCH 01/11] drm/amdgpu: Comply with implicit fencing rules To: Daniel Vetter References: <20210521090959.1663703-1-daniel.vetter@ffwll.ch> <31467363-e936-879b-8b0d-5a2a92644221@gmail.com> <312b183f-8eb2-d9e2-24ad-b429b74c886c@gmail.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Wed, 26 May 2021 15:32:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Daniel Stone , =?UTF-8?Q?Michel_D=c3=a4nzer?= , Intel Graphics Development , Kevin Wang , DRI Development , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Luben Tuikov , "Kristian H . Kristensen" , Chen Li , Alex Deucher , Daniel Vetter , mesa-dev , =?UTF-8?Q?Christian_K=c3=b6nig?= , Dennis Li , Deepak R Varma Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Am 25.05.21 um 17:23 schrieb Daniel Vetter: > On Tue, May 25, 2021 at 5:05 PM Christian König > wrote: >> Hi Daniel, >> >> Am 25.05.21 um 15:05 schrieb Daniel Vetter: >>> Hi Christian, >>> >>> On Sat, May 22, 2021 at 10:30:19AM +0200, Christian König wrote: >>>> Am 21.05.21 um 20:31 schrieb Daniel Vetter: >>>> This works by adding the fence of the last eviction DMA operation to BOs >>>> when their backing store is newly allocated. That's what the >>>> ttm_bo_add_move_fence() function you stumbled over is good for: https://elixir.bootlin.com/linux/v5.13-rc2/source/drivers/gpu/drm/ttm/ttm_bo.c#L692 >>>> >>>> Now the problem is it is possible that the application is terminated before >>>> it can complete it's command submission. But since resource management only >>>> waits for the shared fences when there are some there is a chance that we >>>> free up memory while it is still in use. >>> Hm where is this code? Would help in my audit that I wanted to do this >>> week? If you look at most other places like >>> drm_gem_fence_array_add_implicit() I mentioned earlier, then we don't >>> treat the shared fences special and always also include the exclusive one. >> See amdgpu_gem_object_close(): >> >> ... >> fence = dma_resv_get_excl(bo->tbo.base.resv); >> if (fence) { >> amdgpu_bo_fence(bo, fence, true); >> fence = NULL; >> } >> ... >> >> We explicitly added that because resource management of some other >> driver was going totally bananas without that. >> >> But I'm not sure which one that was. Maybe dig a bit in the git and >> mailing history of that. > Hm I looked and it's > > commit 82c416b13cb7d22b96ec0888b296a48dff8a09eb > Author: Christian König > Date: Thu Mar 12 12:03:34 2020 +0100 > > drm/amdgpu: fix and cleanup amdgpu_gem_object_close v4 > > That sounded more like amdgpu itself needing this, not another driver? No, that patch was just a follow up moving the functionality around. > But looking at amdgpu_vm_bo_update_mapping() it seems to pick the > right fencing mode for gpu pte clearing, so I'm really not sure what > the bug was that you worked around here?The implementation boils down > to amdgpu_sync_resv() which syncs for the exclusive fence, always. And > there's nothing else that I could find in public history at least, no > references to bug reports or anything. I think you need to dig > internally, because as-is I'm not seeing the problem here. > > Or am I missing something here? See the code here for example: https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/nouveau/nouveau_fence.c#L361 Nouveau assumes that when a shared fence is present it doesn't need to wait for the exclusive one because the shared are always supposed to finish after the exclusive one. But for page table unmap fences that isn't true and we ran into a really nasty and hard to reproduce bug because of this. I think it would be much more defensive if we could say that we always wait for the exclusive fence and fix the use case in nouveau and double check if somebody else does stuff like that as well. Christian. > -Daniel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 430B4C47088 for ; Wed, 26 May 2021 13:33:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0132C613B0 for ; Wed, 26 May 2021 13:33:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0132C613B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9EC286E4F9; Wed, 26 May 2021 13:33:09 +0000 (UTC) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1D5EE6E4BB; Wed, 26 May 2021 13:32:54 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id f75-20020a1c1f4e0000b0290171001e7329so525376wmf.1; Wed, 26 May 2021 06:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=YlBMJFk9IU7XFpKBGAdwLecZ23BlfUXVTyQ5htgnqds=; b=gHerwUijsmKZTx4DCmhcXuTnIFvyweNastBkn9ZahCah3iPkN6qssuhEnZPYikpTXk RX22AZNSYo0f9LnQxB+tGHPW7EicBzlz0paibGwJqll459D9GranIBqGDnHUX0cYZncx nZpVupWUHabYgH0UBi7gLLfMRyGCyvETRi0K2w2FEUMDDLvwMI7s21+tKrDI9eeUQ+bu q2ZJ+Vwea2gEB1SOlH0SoO6nRY0IUHfDLbHJpOg0chTfNAgj+6bpACfIzjyNl9xXIZ9w XkKPZvSXQik3WBxDBewoVhH93liltdQM/tFv8G3wAqtIEZXhH07TJdL3qZYWortdJcxX E2HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=YlBMJFk9IU7XFpKBGAdwLecZ23BlfUXVTyQ5htgnqds=; b=mh3+a7JahGQdJ4xiMGl4uSvsoI6yKjf93X+o1G7GbOtB0Ap0KVjEiZwHzJWdqkbZO1 1OFJFWO/3JqJ4cI0pb9dkDECnvCXq+0Z9Ah3FR0C6TYqJlHFhT9KQgFfsbxGcL9fKqw5 1/YyIaN3jBWnASJRL98Vsmt2LqUMNFeuM4YymvRuXbkzQEOooTeWZIgXZZGf4EjNHrT4 ON3orr26NS7i6Hl62migD4qgTmX169uJdFaYc7Z3UQIf/Wr+lw6vskC+rxQ6KhfgpLDL /sZsQOWBDkoIs9cENIAg7NMG0oWTk0qbNjGwTlOo4skNSnE5Jqx0WP5JpEmvgm5wzalq omAw== X-Gm-Message-State: AOAM532lTkM5UhuTC9hlHU3o3j7YLmCn+Wu6yArqhzdJk0I8Mo7TqQy8 hyVs8aHqP2NifI9furh7fZ0= X-Google-Smtp-Source: ABdhPJyaNjBH9aRtWN83y51VC2QaShd89a7j4j98DGf1DzeCXlHUlJkhEhO3F6fRhbwIb39lhclevg== X-Received: by 2002:a7b:cbc4:: with SMTP id n4mr3577903wmi.153.1622035972705; Wed, 26 May 2021 06:32:52 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:1950:35e:cae9:5bed? ([2a02:908:1252:fb60:1950:35e:cae9:5bed]) by smtp.gmail.com with ESMTPSA id x24sm6561252wmi.13.2021.05.26.06.32.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 May 2021 06:32:52 -0700 (PDT) To: Daniel Vetter References: <20210521090959.1663703-1-daniel.vetter@ffwll.ch> <31467363-e936-879b-8b0d-5a2a92644221@gmail.com> <312b183f-8eb2-d9e2-24ad-b429b74c886c@gmail.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Wed, 26 May 2021 15:32:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mailman-Approved-At: Wed, 26 May 2021 13:33:09 +0000 Subject: Re: [Intel-gfx] [Mesa-dev] [PATCH 01/11] drm/amdgpu: Comply with implicit fencing rules X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Daniel Stone , =?UTF-8?Q?Michel_D=c3=a4nzer?= , Intel Graphics Development , Kevin Wang , DRI Development , Sumit Semwal , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Luben Tuikov , "Kristian H . Kristensen" , Chen Li , Bas Nieuwenhuizen , Alex Deucher , Daniel Vetter , mesa-dev , =?UTF-8?Q?Christian_K=c3=b6nig?= , Dennis Li , Deepak R Varma Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" QW0gMjUuMDUuMjEgdW0gMTc6MjMgc2NocmllYiBEYW5pZWwgVmV0dGVyOgo+IE9uIFR1ZSwgTWF5 IDI1LCAyMDIxIGF0IDU6MDUgUE0gQ2hyaXN0aWFuIEvDtm5pZwo+IDxja29lbmlnLmxlaWNodHp1 bWVya2VuQGdtYWlsLmNvbT4gd3JvdGU6Cj4+IEhpIERhbmllbCwKPj4KPj4gQW0gMjUuMDUuMjEg dW0gMTU6MDUgc2NocmllYiBEYW5pZWwgVmV0dGVyOgo+Pj4gSGkgQ2hyaXN0aWFuLAo+Pj4KPj4+ IE9uIFNhdCwgTWF5IDIyLCAyMDIxIGF0IDEwOjMwOjE5QU0gKzAyMDAsIENocmlzdGlhbiBLw7Zu aWcgd3JvdGU6Cj4+Pj4gQW0gMjEuMDUuMjEgdW0gMjA6MzEgc2NocmllYiBEYW5pZWwgVmV0dGVy Ogo+Pj4+IFRoaXMgd29ya3MgYnkgYWRkaW5nIHRoZSBmZW5jZSBvZiB0aGUgbGFzdCBldmljdGlv biBETUEgb3BlcmF0aW9uIHRvIEJPcwo+Pj4+IHdoZW4gdGhlaXIgYmFja2luZyBzdG9yZSBpcyBu ZXdseSBhbGxvY2F0ZWQuIFRoYXQncyB3aGF0IHRoZQo+Pj4+IHR0bV9ib19hZGRfbW92ZV9mZW5j ZSgpIGZ1bmN0aW9uIHlvdSBzdHVtYmxlZCBvdmVyIGlzIGdvb2QgZm9yOiBodHRwczovL2VsaXhp ci5ib290bGluLmNvbS9saW51eC92NS4xMy1yYzIvc291cmNlL2RyaXZlcnMvZ3B1L2RybS90dG0v dHRtX2JvLmMjTDY5Mgo+Pj4+Cj4+Pj4gTm93IHRoZSBwcm9ibGVtIGlzIGl0IGlzIHBvc3NpYmxl IHRoYXQgdGhlIGFwcGxpY2F0aW9uIGlzIHRlcm1pbmF0ZWQgYmVmb3JlCj4+Pj4gaXQgY2FuIGNv bXBsZXRlIGl0J3MgY29tbWFuZCBzdWJtaXNzaW9uLiBCdXQgc2luY2UgcmVzb3VyY2UgbWFuYWdl bWVudCBvbmx5Cj4+Pj4gd2FpdHMgZm9yIHRoZSBzaGFyZWQgZmVuY2VzIHdoZW4gdGhlcmUgYXJl IHNvbWUgdGhlcmUgaXMgYSBjaGFuY2UgdGhhdCB3ZQo+Pj4+IGZyZWUgdXAgbWVtb3J5IHdoaWxl IGl0IGlzIHN0aWxsIGluIHVzZS4KPj4+IEhtIHdoZXJlIGlzIHRoaXMgY29kZT8gV291bGQgaGVs cCBpbiBteSBhdWRpdCB0aGF0IEkgd2FudGVkIHRvIGRvIHRoaXMKPj4+IHdlZWs/IElmIHlvdSBs b29rIGF0IG1vc3Qgb3RoZXIgcGxhY2VzIGxpa2UKPj4+IGRybV9nZW1fZmVuY2VfYXJyYXlfYWRk X2ltcGxpY2l0KCkgSSBtZW50aW9uZWQgZWFybGllciwgdGhlbiB3ZSBkb24ndAo+Pj4gdHJlYXQg dGhlIHNoYXJlZCBmZW5jZXMgc3BlY2lhbCBhbmQgYWx3YXlzIGFsc28gaW5jbHVkZSB0aGUgZXhj bHVzaXZlIG9uZS4KPj4gU2VlIGFtZGdwdV9nZW1fb2JqZWN0X2Nsb3NlKCk6Cj4+Cj4+IC4uLgo+ PiAgICAgICAgICAgZmVuY2UgPSBkbWFfcmVzdl9nZXRfZXhjbChiby0+dGJvLmJhc2UucmVzdik7 Cj4+ICAgICAgICAgICBpZiAoZmVuY2UpIHsKPj4gICAgICAgICAgICAgICAgICAgYW1kZ3B1X2Jv X2ZlbmNlKGJvLCBmZW5jZSwgdHJ1ZSk7Cj4+ICAgICAgICAgICAgICAgICAgIGZlbmNlID0gTlVM TDsKPj4gICAgICAgICAgIH0KPj4gLi4uCj4+Cj4+IFdlIGV4cGxpY2l0bHkgYWRkZWQgdGhhdCBi ZWNhdXNlIHJlc291cmNlIG1hbmFnZW1lbnQgb2Ygc29tZSBvdGhlcgo+PiBkcml2ZXIgd2FzIGdv aW5nIHRvdGFsbHkgYmFuYW5hcyB3aXRob3V0IHRoYXQuCj4+Cj4+IEJ1dCBJJ20gbm90IHN1cmUg d2hpY2ggb25lIHRoYXQgd2FzLiBNYXliZSBkaWcgYSBiaXQgaW4gdGhlIGdpdCBhbmQKPj4gbWFp bGluZyBoaXN0b3J5IG9mIHRoYXQuCj4gSG0gSSBsb29rZWQgYW5kIGl0J3MKPgo+IGNvbW1pdCA4 MmM0MTZiMTNjYjdkMjJiOTZlYzA4ODhiMjk2YTQ4ZGZmOGEwOWViCj4gQXV0aG9yOiBDaHJpc3Rp YW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cj4gRGF0ZTogICBUaHUgTWFyIDEy IDEyOjAzOjM0IDIwMjAgKzAxMDAKPgo+ICAgICBkcm0vYW1kZ3B1OiBmaXggYW5kIGNsZWFudXAg YW1kZ3B1X2dlbV9vYmplY3RfY2xvc2UgdjQKPgo+IFRoYXQgc291bmRlZCBtb3JlIGxpa2UgYW1k Z3B1IGl0c2VsZiBuZWVkaW5nIHRoaXMsIG5vdCBhbm90aGVyIGRyaXZlcj8KCk5vLCB0aGF0IHBh dGNoIHdhcyBqdXN0IGEgZm9sbG93IHVwIG1vdmluZyB0aGUgZnVuY3Rpb25hbGl0eSBhcm91bmQu Cgo+IEJ1dCBsb29raW5nIGF0IGFtZGdwdV92bV9ib191cGRhdGVfbWFwcGluZygpIGl0IHNlZW1z IHRvIHBpY2sgdGhlCj4gcmlnaHQgZmVuY2luZyBtb2RlIGZvciBncHUgcHRlIGNsZWFyaW5nLCBz byBJJ20gcmVhbGx5IG5vdCBzdXJlIHdoYXQKPiB0aGUgYnVnIHdhcyB0aGF0IHlvdSB3b3JrZWQg YXJvdW5kIGhlcmU/VGhlIGltcGxlbWVudGF0aW9uIGJvaWxzIGRvd24KPiB0byBhbWRncHVfc3lu Y19yZXN2KCkgd2hpY2ggc3luY3MgZm9yIHRoZSBleGNsdXNpdmUgZmVuY2UsIGFsd2F5cy4gQW5k Cj4gdGhlcmUncyBub3RoaW5nIGVsc2UgdGhhdCBJIGNvdWxkIGZpbmQgaW4gcHVibGljIGhpc3Rv cnkgYXQgbGVhc3QsIG5vCj4gcmVmZXJlbmNlcyB0byBidWcgcmVwb3J0cyBvciBhbnl0aGluZy4g SSB0aGluayB5b3UgbmVlZCB0byBkaWcKPiBpbnRlcm5hbGx5LCBiZWNhdXNlIGFzLWlzIEknbSBu b3Qgc2VlaW5nIHRoZSBwcm9ibGVtIGhlcmUuCj4KPiBPciBhbSBJIG1pc3Npbmcgc29tZXRoaW5n IGhlcmU/CgpTZWUgdGhlIGNvZGUgaGVyZSBmb3IgZXhhbXBsZTogCmh0dHBzOi8vZWxpeGlyLmJv b3RsaW4uY29tL2xpbnV4L2xhdGVzdC9zb3VyY2UvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbm91 dmVhdV9mZW5jZS5jI0wzNjEKCk5vdXZlYXUgYXNzdW1lcyB0aGF0IHdoZW4gYSBzaGFyZWQgZmVu Y2UgaXMgcHJlc2VudCBpdCBkb2Vzbid0IG5lZWQgdG8gCndhaXQgZm9yIHRoZSBleGNsdXNpdmUg b25lIGJlY2F1c2UgdGhlIHNoYXJlZCBhcmUgYWx3YXlzIHN1cHBvc2VkIHRvIApmaW5pc2ggYWZ0 ZXIgdGhlIGV4Y2x1c2l2ZSBvbmUuCgpCdXQgZm9yIHBhZ2UgdGFibGUgdW5tYXAgZmVuY2VzIHRo YXQgaXNuJ3QgdHJ1ZSBhbmQgd2UgcmFuIGludG8gYSByZWFsbHkgCm5hc3R5IGFuZCBoYXJkIHRv IHJlcHJvZHVjZSBidWcgYmVjYXVzZSBvZiB0aGlzLgoKSSB0aGluayBpdCB3b3VsZCBiZSBtdWNo IG1vcmUgZGVmZW5zaXZlIGlmIHdlIGNvdWxkIHNheSB0aGF0IHdlIGFsd2F5cyAKd2FpdCBmb3Ig dGhlIGV4Y2x1c2l2ZSBmZW5jZSBhbmQgZml4IHRoZSB1c2UgY2FzZSBpbiBub3V2ZWF1IGFuZCBk b3VibGUgCmNoZWNrIGlmIHNvbWVib2R5IGVsc2UgZG9lcyBzdHVmZiBsaWtlIHRoYXQgYXMgd2Vs bC4KCkNocmlzdGlhbi4KCj4gLURhbmllbAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==