From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinan Kaya Subject: Re: [PATCH] ACPI / GED: unregister interrupts during shutdown Date: Wed, 6 Dec 2017 09:57:03 -0500 Message-ID: References: <1512507705-2411-1-git-send-email-okaya@codeaurora.org> <0b661eec-f9c7-7818-ad09-f3d488adcefe@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:56524 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751748AbdLFO5G (ORCPT ); Wed, 6 Dec 2017 09:57:06 -0500 In-Reply-To: Content-Language: en-US Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: "Rafael J. Wysocki" Cc: ACPI Devel Maling List , Timur Tabi , "Rafael J. Wysocki" , linux-arm-msm@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List On 12/6/2017 8:37 AM, Rafael J. Wysocki wrote: > On Wed, Dec 6, 2017 at 2:24 PM, Sinan Kaya wrote: >> On 12/5/2017 5:18 PM, Rafael J. Wysocki wrote: >>> On Tue, Dec 5, 2017 at 10:01 PM, Sinan Kaya wrote: >>>> Some GED interrupts could be pending by the time we are doing a reboot. > > [cut] > >> >>> >>>> .probe = ged_probe, >>>> .driver = { >>>> .name = MODULE_NAME, >>>> -- >>> >>> Overall, it looks like we should just unbind the driver from all >>> devices on shutdown. >> >> I see that shutdown is getting called on all GED instances. That should >> take care of it, right? > > Yes, it should, so I'm not sure why you need the list in the first place. > > Also it looks like something along the lines of devres_release_all() > should be sufficient. Good suggestion, let me test this. > > Thanks, > Rafael > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752105AbdLFO5I (ORCPT ); Wed, 6 Dec 2017 09:57:08 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:56524 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751748AbdLFO5G (ORCPT ); Wed, 6 Dec 2017 09:57:06 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 524DC60398 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH] ACPI / GED: unregister interrupts during shutdown To: "Rafael J. Wysocki" Cc: ACPI Devel Maling List , Timur Tabi , "Rafael J. Wysocki" , linux-arm-msm@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List References: <1512507705-2411-1-git-send-email-okaya@codeaurora.org> <0b661eec-f9c7-7818-ad09-f3d488adcefe@codeaurora.org> From: Sinan Kaya Message-ID: Date: Wed, 6 Dec 2017 09:57:03 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/6/2017 8:37 AM, Rafael J. Wysocki wrote: > On Wed, Dec 6, 2017 at 2:24 PM, Sinan Kaya wrote: >> On 12/5/2017 5:18 PM, Rafael J. Wysocki wrote: >>> On Tue, Dec 5, 2017 at 10:01 PM, Sinan Kaya wrote: >>>> Some GED interrupts could be pending by the time we are doing a reboot. > > [cut] > >> >>> >>>> .probe = ged_probe, >>>> .driver = { >>>> .name = MODULE_NAME, >>>> -- >>> >>> Overall, it looks like we should just unbind the driver from all >>> devices on shutdown. >> >> I see that shutdown is getting called on all GED instances. That should >> take care of it, right? > > Yes, it should, so I'm not sure why you need the list in the first place. > > Also it looks like something along the lines of devres_release_all() > should be sufficient. Good suggestion, let me test this. > > Thanks, > Rafael > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. From mboxrd@z Thu Jan 1 00:00:00 1970 From: okaya@codeaurora.org (Sinan Kaya) Date: Wed, 6 Dec 2017 09:57:03 -0500 Subject: [PATCH] ACPI / GED: unregister interrupts during shutdown In-Reply-To: References: <1512507705-2411-1-git-send-email-okaya@codeaurora.org> <0b661eec-f9c7-7818-ad09-f3d488adcefe@codeaurora.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/6/2017 8:37 AM, Rafael J. Wysocki wrote: > On Wed, Dec 6, 2017 at 2:24 PM, Sinan Kaya wrote: >> On 12/5/2017 5:18 PM, Rafael J. Wysocki wrote: >>> On Tue, Dec 5, 2017 at 10:01 PM, Sinan Kaya wrote: >>>> Some GED interrupts could be pending by the time we are doing a reboot. > > [cut] > >> >>> >>>> .probe = ged_probe, >>>> .driver = { >>>> .name = MODULE_NAME, >>>> -- >>> >>> Overall, it looks like we should just unbind the driver from all >>> devices on shutdown. >> >> I see that shutdown is getting called on all GED instances. That should >> take care of it, right? > > Yes, it should, so I'm not sure why you need the list in the first place. > > Also it looks like something along the lines of devres_release_all() > should be sufficient. Good suggestion, let me test this. > > Thanks, > Rafael > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.