From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D0CAC433F5 for ; Thu, 7 Oct 2021 21:19:37 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67E3561077 for ; Thu, 7 Oct 2021 21:19:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 67E3561077 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.204036.359232 (Exim 4.92) (envelope-from ) id 1mYanY-0008A9-Ts; Thu, 07 Oct 2021 21:19:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 204036.359232; Thu, 07 Oct 2021 21:19:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mYanY-0008A2-Qz; Thu, 07 Oct 2021 21:19:28 +0000 Received: by outflank-mailman (input) for mailman id 204036; Thu, 07 Oct 2021 21:19:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mYanX-00089Y-Ir for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 21:19:27 +0000 Received: from mail-ed1-x529.google.com (unknown [2a00:1450:4864:20::529]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d8fef562-bb3e-4295-b308-b0a52a44b1cc; Thu, 07 Oct 2021 21:19:26 +0000 (UTC) Received: by mail-ed1-x529.google.com with SMTP id r18so28253450edv.12 for ; Thu, 07 Oct 2021 14:19:26 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id o5sm230384eds.26.2021.10.07.14.19.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Oct 2021 14:19:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d8fef562-bb3e-4295-b308-b0a52a44b1cc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=LukkjeGvSI0BY1W+mXe0HSJdY78EUYNMhAIPp3JeJPA=; b=n8NV+1m2KOfLSVOINnmtS4LmJSf79mjK7Z/o1XfFDZwswDnIH8G9kWvsyLETg2B7mo +u8oiRH7IAQJWMU8R5s0IvCrs5EXoYtLKnOcOO6tBkURiJdNxs099+VLoMyG2UVgMoti mbL3KRMtCbjRTm3xJZ/hdIxKuhevD+8t2n7/cs4t0bhlZ1bcuk0xciID8MJIMe5xzW/f fAoElJ9pyF1rBUXihIFNIxVKTDLvjMYOi76gBQyqnDh5Bzn4cn0GNCpiXX7lwO8YbD14 Sii99VKHfpEadrEB/hWA70biQukb+VIhDwyrI/J7H5wwxSCgTSrqamgMgRhdCxPdHrwa EN7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=LukkjeGvSI0BY1W+mXe0HSJdY78EUYNMhAIPp3JeJPA=; b=FZNjlNbsIAqM2u9Z0SxgB9VH9XCKGNoyRenehKKmio2Soj94mZS+GqSLbxQbUKuqlg cQELLd8a4Hv5lytRF5rWZW8D9AAtlBwfcz4rQf3Gx8xqlBDfeqeD0okfjQ7Vw3iScEn+ sg9pk7CvA7RIU0WjBQBgn6cpKHX5ALR5Q68sD0tHzd/Wuk+bMwt3DLCsiSISM8S5BtTG sTXHe3I60LsF5TbPlfbDplivCGlA4Gj7oYiQWO0f6omGB0VvTtKb0tqX96L1Ay03vFZ7 Mu30srH+UbRkPQPie2yguZ+9Lv/VuKe5R7IHXLsFOdRlxsmCzJFMvZYYtcQmGpbtDXns pY9Q== X-Gm-Message-State: AOAM533kPJEyiv0obKhQwhY4n/b2nDJVauMGMWKvk1oaX9RCakuuXuWu JqOlMqIAbRxUMj0MgtFF1bQ= X-Google-Smtp-Source: ABdhPJx/buooncs7SbNYFsuLDN9rPZbfccw8RSBVoZCzxV0dqr3NMdf7mk2TrSBVPR0klTbUsuFsMw== X-Received: by 2002:a05:6402:3483:: with SMTP id v3mr7321340edc.296.1633641565720; Thu, 07 Oct 2021 14:19:25 -0700 (PDT) Subject: Re: [PATCH V5 3/3] xen/arm: Updates for extended regions support To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, Oleksandr Tyshchenko , Julien Grall , Volodymyr Babchuk References: <1633519346-3686-1-git-send-email-olekstysh@gmail.com> <1633519346-3686-4-git-send-email-olekstysh@gmail.com> From: Oleksandr Message-ID: Date: Fri, 8 Oct 2021 00:19:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 07.10.21 23:42, Stefano Stabellini wrote: Hi Stefano > On Thu, 7 Oct 2021, Oleksandr wrote: >> On 07.10.21 23:06, Stefano Stabellini wrote: >>> On Thu, 7 Oct 2021, Oleksandr wrote: >>>> On 07.10.21 04:50, Stefano Stabellini wrote: >>>> >>>> Hi Stefano >>>> >>>>> On Wed, 6 Oct 2021, Oleksandr Tyshchenko wrote: >>>>>> From: Oleksandr Tyshchenko >>>>>> >>>>>> This is a follow-up of >>>>>> "b6fe410 xen/arm: Add handling of extended regions for Dom0" >>>>>> >>>>>> Add various in-code comments, update Xen hypervisor device tree >>>>>> bindings text, change the log level for some prints and clarify >>>>>> format specifier, reuse dt_for_each_range() to avoid open-coding >>>>>> in find_memory_holes(). >>>>>> >>>>>> Signed-off-by: Oleksandr Tyshchenko >>>>> Thanks for the patch, it looks like you addressed all Julien's comments >>>>> well. >>>> I believe so) >>> [...] >>> >>>>>> @@ -1193,8 +1215,8 @@ static int __init make_hypervisor_node(struct >>>>>> domain >>>>>> *d, >>>>>> u64 start = ext_regions->bank[i].start; >>>>>> u64 size = ext_regions->bank[i].size; >>>>>> - dt_dprintk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n", >>>>>> - i, start, start + size); >>>>>> + printk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n", >>>>>> + i, start, start + size); >>>>> Also should be PRIpaddr >>>> I thought I needed to change specifier only for variables of type >>>> "paddr_t", >>>> but here "u64". >>> Sorry, you are right. >>> >>> I added my reviewed-by and made the small typo changes on commit. >> Thanks! In case if you haven't committed the patch yet, let's please wait for >> Julien (who asked for this follow-up) to review it. >> >> In any case, I will be able to do another follow-up if needed. > > I committed it as I would like to squeeze as many runs out of OSSTest > and Gitlab-CI as possible as we are getting closer and closer to the > release. I am trying to avoid the last minute rush to commit 150 patches > one day before code freeze :-) > > The more intermediate runs we get, the easier is to pinpoint (and fix) > regressions. I got it, thank you for the explanation. > > But also, this patch doesn't affect external interfances, it is just > internal and mostly comments, so it is super-easy to do follow-ups. Yes, agree. -- Regards, Oleksandr Tyshchenko