From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v2 09/28] drm: omapdrm: dsi: Store DSI type and PLL hardware data in OF data Date: Tue, 9 May 2017 12:31:58 +0300 Message-ID: References: <20170508113303.27521-1-laurent.pinchart@ideasonboard.com> <20170508113303.27521-10-laurent.pinchart@ideasonboard.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0179933527==" Return-path: Received: from fllnx209.ext.ti.com (fllnx209.ext.ti.com [198.47.19.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4D97C6E11D for ; Tue, 9 May 2017 09:32:28 +0000 (UTC) In-Reply-To: <20170508113303.27521-10-laurent.pinchart@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0179933527== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1mo4A0kCObF4Mk4KrWaDckv8rVkrnl8wM" --1mo4A0kCObF4Mk4KrWaDckv8rVkrnl8wM Content-Type: multipart/mixed; boundary="dTQbHNGeop6FFFFv616JLowWsE5CE3cmd"; protected-headers="v1" From: Tomi Valkeinen To: Laurent Pinchart , dri-devel@lists.freedesktop.org Message-ID: Subject: Re: [PATCH v2 09/28] drm: omapdrm: dsi: Store DSI type and PLL hardware data in OF data References: <20170508113303.27521-1-laurent.pinchart@ideasonboard.com> <20170508113303.27521-10-laurent.pinchart@ideasonboard.com> In-Reply-To: <20170508113303.27521-10-laurent.pinchart@ideasonboard.com> --dTQbHNGeop6FFFFv616JLowWsE5CE3cmd Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/05/17 14:32, Laurent Pinchart wrote: > The DSI PLL hardware data and DSS channels are selected based on the > OMAP SoC model. There's no need for fine-grained model information, as > the driver only needs to differentiate between OMAP3, OMAP4 and OMAP5. > As this can be done through the DSI compatible string, store the > corresponding information in OF match data instead to avoid accessing > the OMAP SoC model. >=20 > Signed-off-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 116 ++++++++++++++++++------------= -------- > 1 file changed, 55 insertions(+), 61 deletions(-) >=20 > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdr= m/dss/dsi.c > index 3edd194d6f36..400f903d8197 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -227,6 +227,12 @@ static int dsi_vc_send_null(struct omap_dss_device= *dssdev, int channel); > #define DSI_MAX_NR_ISRS 2 > #define DSI_MAX_NR_LANES 5 > =20 > +enum dsi_device_type { > + DSI_TYPE_OMAP3, > + DSI_TYPE_OMAP4, > + DSI_TYPE_OMAP5, > +}; Same comment here as for the DPI. At least to me "type" doesn't sound like what we're looking for here. If I read "switch (dsi->data->type)" my thought is not that we're checking the DSI version. Although "DSI version" is maybe not an exact match either... It's about how the DSI has been integrated in that particular SoC, and which PLL version we have= =2E Tomi --dTQbHNGeop6FFFFv616JLowWsE5CE3cmd-- --1mo4A0kCObF4Mk4KrWaDckv8rVkrnl8wM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZEYyOAAoJEPo9qoy8lh71WNgP/j65s+qj+NzoWw/mutAVRI4h /4MDnoYO4s4X5VXUQTzisecs9xGSGa+su2Zls2/9slHjE/ScKsuZIGRkOUNhI6ND VlXI9b6NeRajeGpm9Zwe/tlHsXUDSo7uaJaSY1f0A2yl9gzlEszEeqrHATu3zva9 GvQ3YacSi07+P18YS3DsAL+jLx+N+ZrTioVFKsvR2ANLWV3lWK+FmhqvFzt6vPUG 0qbfvH7ll0K9OgXdh0tS6oWZTPLpWJcOlSd7NaLdA39eaEywQTyzCc2AiT1esZst o+HeIA6d1egWYP5ct6e9Hct3HRkVqJeelyYnmrQ8RsDlQMQBDtn3yNOOEOwy08+Z 9DzPNK+KGxqx/ZWqOmy4awuxJ3fhkkzN7wEFK/Cd9uQGzyhNC8QC0d7IT/XEuQk2 fMW1ZUeh5E9iV+vWgJ1FdYSoaNQ6zwu76IIOlJ0I7n6MTAWBUOsMVPZZX05ev+ZX 6Aq4NwhsPPn01A4zNqQz/m226JJoM46prRAU69tiVOiSwDk7yCqmnJ5H4fksu/ev fXfSjUlsZPHcxQdHimlXo5CrtUs0ItoyVZWjYWNv89ThrE5hXZOCIwTZiqxdHRrH 0//0HPRUxsRb2IDg/lClnTgDw+lOUcLJr2LN841cLO/0AlwBEPsZx5sTNu7aJKmi l5KI7gCf97MZE2QbiygV =DUoc -----END PGP SIGNATURE----- --1mo4A0kCObF4Mk4KrWaDckv8rVkrnl8wM-- --===============0179933527== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0179933527==--