From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B337C433F5 for ; Mon, 20 Sep 2021 05:32:55 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 679EF6101C for ; Mon, 20 Sep 2021 05:32:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 679EF6101C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8570981E1C; Mon, 20 Sep 2021 07:32:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1632115972; bh=XYEU0EPzIISrTnNnauxTqZK9iAXymQSrgHBB0kcVQp0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=UUM1fhR3aGqPVdrYVO/t3UJ9hO65ltAdmGHd7PMY1UlvnXNECyjf55pXWKoNXvcI5 PZF7y4ZBQWpkJWNVJAupSp3t0QAQx+UKdf2TKSS26oCDcV0U6xyr3Md4Yhy85qMxMf jYB5ILeN4hnuwK3a3XEkYJlp5N5Ta803yJ+5UGqc30ABo74XejNXyfUlc5FBw2akpg AUqNDJvJJdxmWE8+hK9iNIB2EloiAdnTqEHEnnQNAUsKuPUh4ckZmsY1lyb5XgzUOQ bOxQjzUEmt1UpG+AUU0DkzviTN4PrYeFZzQ7EXxhQK84yksaHSoAG3BXrYvn/UF7jJ 5/Tcus32wyaeg== Received: by phobos.denx.de (Postfix, from userid 109) id D82EC82DA1; Mon, 20 Sep 2021 07:32:50 +0200 (CEST) Received: from mout-u-107.mailbox.org (mout-u-107.mailbox.org [IPv6:2001:67c:2050:1::465:107]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id ED9A2811F7 for ; Mon, 20 Sep 2021 07:32:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-107.mailbox.org (Postfix) with ESMTPS id 4HCY9W59YJzQjjL; Mon, 20 Sep 2021 07:32:47 +0200 (CEST) Subject: Re: [PATCH] wdt: dw: Fix passing NULL pointer to reset functions To: Sean Anderson , Simon Glass , u-boot@lists.denx.de Cc: Leo Liang , Meng Li References: <20210911191130.931814-1-seanga2@gmail.com> From: Stefan Roese Message-ID: Date: Mon, 20 Sep 2021 07:32:44 +0200 MIME-Version: 1.0 In-Reply-To: <20210911191130.931814-1-seanga2@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: C2C5D188F X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 11.09.21 21:11, Sean Anderson wrote: > reset_*_bulk expects a real pointer. > > Fixes: 4f7abafe1c ("driver: watchdog: reset watchdog in designware_wdt_stop() function") > Signed-off-by: Sean Anderson Reviewed-by: Stefan Roese Thanks, Stefan > --- > > drivers/watchdog/designware_wdt.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/watchdog/designware_wdt.c b/drivers/watchdog/designware_wdt.c > index afed81e6c6..cfec29bd15 100644 > --- a/drivers/watchdog/designware_wdt.c > +++ b/drivers/watchdog/designware_wdt.c > @@ -22,7 +22,7 @@ > struct designware_wdt_priv { > void __iomem *base; > unsigned int clk_khz; > - struct reset_ctl_bulk *resets; > + struct reset_ctl_bulk resets; > }; > > /* > @@ -99,11 +99,11 @@ static int designware_wdt_stop(struct udevice *dev) > if (CONFIG_IS_ENABLED(DM_RESET)) { > int ret; > > - ret = reset_assert_bulk(priv->resets); > + ret = reset_assert_bulk(&priv->resets); > if (ret) > return ret; > > - ret = reset_deassert_bulk(priv->resets); > + ret = reset_deassert_bulk(&priv->resets); > if (ret) > return ret; > } > @@ -156,11 +156,11 @@ static int designware_wdt_probe(struct udevice *dev) > #endif > > if (CONFIG_IS_ENABLED(DM_RESET)) { > - ret = reset_get_bulk(dev, priv->resets); > + ret = reset_get_bulk(dev, &priv->resets); > if (ret) > goto err; > > - ret = reset_deassert_bulk(priv->resets); > + ret = reset_deassert_bulk(&priv->resets); > if (ret) > goto err; > } > Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de