From: Paolo Bonzini <pbonzini@redhat.com>
To: P J P <ppandit@redhat.com>, Qemu Developers <qemu-devel@nongnu.org>
Cc: Dmitry Fleytman <dmitry@daynix.com>, Li Qiang <liqiang6-s@360.cn>,
Prasad J Pandit <pjp@fedoraproject.org>
Subject: Re: [Qemu-devel] [PATCH] scsi: pvscsi: request descriptor data_length to 32 bit
Date: Mon, 5 Sep 2016 11:04:57 +0200 [thread overview]
Message-ID: <fe88297e-34a1-a51c-b964-062f31c20b14@redhat.com> (raw)
In-Reply-To: <1472884428-9975-1-git-send-email-ppandit@redhat.com>
On 03/09/2016 08:33, P J P wrote:
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> In PVSCSI paravirtual SCSI bus, the request descriptor data
> length is defined to be 64 bit. While building SG list from
> a request descriptor, it gets truncated to 32bit in routine
> 'pvscsi_convert_sglist'. This could lead to an infinite loop
> situation for arbitrarily large 'dataLen' values. Define local
> variable 'data_length' to be 32 bit, to avoid it.
>
> Reported-by: Li Qiang <liqiang6-s@360.cn>
> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
> ---
> hw/scsi/vmw_pvscsi.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c
> index 4245c15..4d38330 100644
> --- a/hw/scsi/vmw_pvscsi.c
> +++ b/hw/scsi/vmw_pvscsi.c
> @@ -629,7 +629,7 @@ static void
> pvscsi_convert_sglist(PVSCSIRequest *r)
> {
> int chunk_size;
> - uint64_t data_length = r->req.dataLen;
> + uint32_t data_length = r->req.dataLen;
Why is this needed if you remove the cast in MIN, below?
Paolo
> PVSCSISGState sg = r->sg;
> while (data_length) {
> while (!sg.resid) {
> @@ -637,8 +637,7 @@ pvscsi_convert_sglist(PVSCSIRequest *r)
> trace_pvscsi_convert_sglist(r->req.context, r->sg.dataAddr,
> r->sg.resid);
> }
> - assert(data_length > 0);
> - chunk_size = MIN((unsigned) data_length, sg.resid);
> + chunk_size = MIN(data_length, sg.resid);
> if (chunk_size) {
> qemu_sglist_add(&r->sgl, sg.dataAddr, chunk_size);
> }
>
next prev parent reply other threads:[~2016-09-05 9:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-03 6:33 [Qemu-devel] [PATCH] scsi: pvscsi: request descriptor data_length to 32 bit P J P
2016-09-05 9:04 ` Paolo Bonzini [this message]
2016-09-05 9:50 ` P J P
2016-09-05 10:00 ` Paolo Bonzini
2016-09-05 11:13 ` P J P
2016-09-05 11:39 ` Paolo Bonzini
2016-09-05 12:58 ` P J P
2016-09-05 13:02 ` Paolo Bonzini
2016-09-05 20:52 ` P J P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe88297e-34a1-a51c-b964-062f31c20b14@redhat.com \
--to=pbonzini@redhat.com \
--cc=dmitry@daynix.com \
--cc=liqiang6-s@360.cn \
--cc=pjp@fedoraproject.org \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.