Re: [Buildroot] [PATCH v7 1/1] package/qt5: bump packages to latest kde submodule versions

From: Arnout Vandecappelle <arnout@mind.be>
To: James Hilliard <james.hilliard1@gmail.com>, buildroot@buildroot.org
Cc: "Naumann Andreas" <ANaumann@ultratronik.de>,
	"Joshua Henderson" <joshua.henderson@microchip.com>,
	"Angelo Compagnucci" <angelo.compagnucci@gmail.com>,
	"Bartosz Bilas" <b.bilas@grinn-global.com>,
	"Peter Seiderer" <ps.report@gmx.net>,
	"Gaël Portay" <gael.portay@collabora.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Julien Corjon" <corjon.j@ecagroup.com>
Subject: Re: [Buildroot] [PATCH v7 1/1] package/qt5: bump packages to latest kde submodule versions
Date: Thu, 3 Feb 2022 20:35:56 +0100	[thread overview]
Message-ID: <fe89e71a-ad55-44ab-20ba-d2b46b15a271@mind.be> (raw)
In-Reply-To: <20220131225622.90226-1-james.hilliard1@gmail.com>

On 31/01/2022 23:56, James Hilliard wrote:
> This points all qt5 packages to the latest kde submodule versions
> available at https://invent.kde.org/qt/qt/qt5/-/tree/kde/5.15

  It took me some reading of the patch and of the upstream repositories to 
understand that there are actually no release tarballs or tags, and the the 
5.15.8 is something we just pull out of our hat to be compatible with 
qt5webengine. So I updated the commit message to (hopefully) better explain that.

> 
> We need to remove some patches applied upstream already.
> 
> We need to rework qt5location to pull in the mapboxgl dependency from
> a separate package as that dependency is only included in release
> archives.

  Instead of creating a separate package for it (which BTW you forgot to add to 
DEVELOPERS), I changed this to use the git download method and _GIT_SUBMODULES = 
YES. I checked that it extracts to exactly the same thing.

> 
> We need to pin qt5 packages not available in the new upstream to the
> previous 5.15.2 version.
> 
> We need to set SYNC_QT_HEADERS for all qt5 packages in the new
> upstream as headers are only copied in release archives which are
> not provided in the kde upstream.
> 
> Set the MODULE_VERSION to 5.15.8 to match latest qt5webengine which
> should be the closest release to the kde patches which don't have
> proper version tags.
> 
> Create a .git file so to trigger headers sync during configure.

  I don't really understand why this was needed rather than calling syncqt 
explicitly, but OK.

  Applied to master, thanks.

  Regards,
  Arnout

> 
> Hold back updating qt5webengine for now since the latest version
> requires significant changes to build, just tweak existing version
> to be compatible with latest kde versions for now.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

[snip]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot