From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sagar Arun Kamble <sagar.a.kamble@intel.com>
Subject: Re: [PATCH v2 1/2] drm/i915/guc: Use correct error code
 for GuC initialization failure
Date: Wed, 21 Feb 2018 13:38:08 +0530
Message-ID: <fe983e6f-412f-eede-86f7-0c07c785203e@intel.com>
References: <20180220225711.12524-1-michal.wajdeczko@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 972956E534
 for <intel-gfx@lists.freedesktop.org>; Wed, 21 Feb 2018 08:08:11 +0000 (UTC)
In-Reply-To: <20180220225711.12524-1-michal.wajdeczko@intel.com>
Content-Language: en-US
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

CgpPbiAyLzIxLzIwMTggNDoyNyBBTSwgTWljaGFsIFdhamRlY3prbyB3cm90ZToKPiBTaW5jZSBj
b21taXQgNmNhOWEyYmViNTRhICgiZHJtL2k5MTU6IFVud2luZCBpOTE1X2dlbV9pbml0KCkgZmFp
bHVyZSIpCj4gd2UgYmVsaWV2ZWQgdGhhdCB3ZSBjb3JyZWN0bHkgaGFuZGxlIGFsbCBlcnJvcnMg
ZW5jb3VudGVyZWQgZHVyaW5nCj4gR3VDIGluaXRpYWxpemF0aW9uLCBpbmNsdWRpbmcgc3BlY2lh
bCBvbmUgdGhhdCBpbmRpY2F0ZXMgcmVxdWVzdCB0bwo+IHJ1biBkcml2ZXIgd2l0aCBkaXNhYmxl
ZCBHUFUgc3VibWlzc2lvbiAoLUVJTykuCj4KPiBVbmZvcnR1bmF0ZWx5IHNpbmNlIGNvbW1pdCAx
MjE5ODFmYWZlNjkgKCJkcm0vaTkxNS9ndWM6IENvbWJpbmUKPiBlbmFibGVfZ3VjX2xvYWRpbmd8
c3VibWlzc2lvbiBtb2RwYXJhbXMiKSB3ZSBzdG9wcGVkIHVzaW5nIHRoYXQKPiBlcnJvciBjb2Rl
IHRvIGF2b2lkIHVud2FudGVkIGZhbGxiYWNrIHRvIGV4ZWNsaXN0IHN1Ym1pc3Npb24gbW9kZS4K
Pgo+IEluIHJlc3VsdCBhbnkgR3VDIGluaXRpYWxpemF0aW9uIGZhaWx1cmUgd2FzIHRyZWF0ZWQg
YXMgbm9uLXJlY292ZXJhYmxlCj4gZXJyb3IgbGVhZGluZyB0byBkcml2ZXIgbG9hZCBhYm9ydCwg
c28gd2UgY291bGQgbm90IGV2ZW4gcmVhZCByZWxhdGVkCj4gR3VDIGVycm9yIGxvZyB0byBpbnZl
c3RpZ2F0ZSBjYXVzZSBvZiB0aGUgcHJvYmxlbS4KPgo+IEZpeCB0aGF0IGJ5IGFsd2F5cyByZXR1
cm5pbmcgLUVJTyBvbiB1QyBoYXJkd2FyZSByZWxhdGVkIGZhaWx1cmUuCj4KPiB2MjogZG9uJ3Qg
YWxsb3cgLUVJTyBmcm9tIHVjX2luaXQKPiAgICAgIGRvbid0IGNhbGwgdWNfZmluaVtfbWlzY10g
b24gLUVJTwo+ICAgICAgbWFyayBndWMgZncgYXMgZmFpbGVkIG9uIGh3IGluaXQgZmFpbHVyZQo+
ICAgICAgcHJlcGFyZSB1Y19maW5pX2h3IHRvIHJ1biBhZnRlciBlYXJsaWVyIC1FSU8KPgo+IFNp
Z25lZC1vZmYtYnk6IE1pY2hhbCBXYWpkZWN6a28gPG1pY2hhbC53YWpkZWN6a29AaW50ZWwuY29t
Pgo+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogTWlj
aGFsIFdpbmlhcnNraSA8bWljaGFsLndpbmlhcnNraUBpbnRlbC5jb20+Cj4gQ2M6IERhbmllbGUg
Q2VyYW9sbyBTcHVyaW8gPGRhbmllbGUuY2VyYW9sb3NwdXJpb0BpbnRlbC5jb20+Cj4gQ2M6IFNh
Z2FyIEFydW4gS2FtYmxlIDxzYWdhci5hLmthbWJsZUBpbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2
ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jICAgIHwgMTMgKysrKysrKystLS0tLQo+ICAgZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmggICB8ICA1ICsrKysrCj4gICBkcml2ZXJzL2dw
dS9kcm0vaTkxNS9pbnRlbF91Yy5jICAgIHwgMTMgKysrKysrKysrLS0tLQo+ICAgZHJpdmVycy9n
cHUvZHJtL2k5MTUvaW50ZWxfdWNfZncuaCB8ICA1ICsrKysrCj4gICA0IGZpbGVzIGNoYW5nZWQs
IDI3IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt
LmMKPiBpbmRleCA2MzFhMmRiLi44MGYyM2E4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5j
Cj4gQEAgLTUzMjQsOCArNTMyNCwxMCBAQCBpbnQgaTkxNV9nZW1faW5pdChzdHJ1Y3QgZHJtX2k5
MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gICAJaW50ZWxfaW5pdF9ndF9wb3dlcnNhdmUoZGV2X3By
aXYpOwo+ICAgCj4gICAJcmV0ID0gaW50ZWxfdWNfaW5pdChkZXZfcHJpdik7Cj4gLQlpZiAocmV0
KQo+ICsJaWYgKHJldCkgewo+ICsJCUdFTV9CVUdfT04ocmV0ID09IC1FSU8pOwo+ICAgCQlnb3Rv
IGVycl9wbTsKPiArCX0KPiAgIAo+ICAgCXJldCA9IGk5MTVfZ2VtX2luaXRfaHcoZGV2X3ByaXYp
Owo+ICAgCWlmIChyZXQpCj4gQEAgLTUzNzIsNyArNTM3NCw4IEBAIGludCBpOTE1X2dlbV9pbml0
KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgIAlpOTE1X2dlbV9jb250ZXh0
c19sb3N0KGRldl9wcml2KTsKPiAgIAlpbnRlbF91Y19maW5pX2h3KGRldl9wcml2KTsKVGhpcyB1
Y19maW5pX2h3IHNob3VsZCBhbHNvIGJlIG5vdCBjYWxsZWQgb24gLUVJTz8KPiAgIGVycl91Y19p
bml0Ogo+IC0JaW50ZWxfdWNfZmluaShkZXZfcHJpdik7Cj4gKwlpZiAocmV0ICE9IC1FSU8pCj4g
KwkJaW50ZWxfdWNfZmluaShkZXZfcHJpdik7Cj4gICBlcnJfcG06Cj4gICAJaWYgKHJldCAhPSAt
RUlPKSB7Cj4gICAJCWludGVsX2NsZWFudXBfZ3RfcG93ZXJzYXZlKGRldl9wcml2KTsKPiBAQCAt
NTM4NiwxMCArNTM4OSwxMCBAQCBpbnQgaTkxNV9nZW1faW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJp
dmF0ZSAqZGV2X3ByaXYpCj4gICAJaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9wdXQoZGV2X3ByaXYs
IEZPUkNFV0FLRV9BTEwpOwo+ICAgCW11dGV4X3VubG9jaygmZGV2X3ByaXYtPmRybS5zdHJ1Y3Rf
bXV0ZXgpOwo+ICAgCj4gLQlpbnRlbF91Y19maW5pX21pc2MoZGV2X3ByaXYpOwo+IC0KPiAtCWlm
IChyZXQgIT0gLUVJTykKPiArCWlmIChyZXQgIT0gLUVJTykgewo+ICsJCWludGVsX3VjX2Zpbmlf
bWlzYyhkZXZfcHJpdik7Cj4gICAJCWk5MTVfZ2VtX2NsZWFudXBfdXNlcnB0cihkZXZfcHJpdik7
Cj4gKwl9Cj4gICAKPiAgIAlpZiAocmV0ID09IC1FSU8pIHsKPiAgIAkJLyoKQ29tbWVudCBoZXJl
IGNhbiBiZSB1cGRhdGVkIHRvIHNheSAiQWxsb3cgZW5naW5lcyBvciB1QyBpbml0aWFsaXphdGlv
biAKdG8gZmFpbCAuLi4gIgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl
bF9ndWMuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oCj4gaW5kZXggNTI4NTZh
OS4uNTEyZmY3YiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMu
aAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oCj4gQEAgLTEwMCw2ICsx
MDAsMTEgQEAgc3RhdGljIGlubGluZSB2b2lkIGludGVsX2d1Y19ub3RpZnkoc3RydWN0IGludGVs
X2d1YyAqZ3VjKQo+ICAgCWd1Yy0+bm90aWZ5KGd1Yyk7Cj4gICB9Cj4gICAKPiArc3RhdGljIGlu
bGluZSBib29sIGludGVsX2d1Y19pc19sb2FkZWQoc3RydWN0IGludGVsX2d1YyAqZ3VjKQo+ICt7
Cj4gKwlyZXR1cm4gaW50ZWxfdWNfZndfaXNfbG9hZGVkKCZndWMtPmZ3KTsKPiArfQo+ICsKPiAg
IC8qCj4gICAgKiBHdUMgZG9lcyBub3QgYWxsb3cgYW55IGdmeCBHR1RUIGFkZHJlc3MgdGhhdCBm
YWxscyBpbnRvIHJhbmdlIFswLCBXT1BDTV9UT1ApLAo+ICAgICogd2hpY2ggaXMgcmVzZXJ2ZWQg
Zm9yIEJvb3QgUk9NLCBTUkFNIGFuZCBXT1BDTS4gQ3VycmVudGx5IHRoaXMgdG9wIGFkZHJlc3Mg
aXMKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYyBiL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjLmMKPiBpbmRleCA5ZjFiYWM2Li43NWQwZWI5IDEwMDY0
NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjLmMKPiArKysgYi9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pbnRlbF91Yy5jCj4gQEAgLTQyMSwxMSArNDIxLDEzIEBAIGludCBpbnRl
bF91Y19pbml0X2h3KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgIAkgKiBO
b3RlIHRoYXQgdGhlcmUgaXMgbm8gZmFsbGJhY2sgYXMgZWl0aGVyIHVzZXIgZXhwbGljaXRseSBh
c2tlZCBmb3IKPiAgIAkgKiB0aGUgR3VDIG9yIGRyaXZlciBkZWZhdWx0IG9wdGlvbiB3YXMgdG8g
cnVuIHdpdGggdGhlIEd1QyBlbmFibGVkLgo+ICAgCSAqLwo+IC0JaWYgKEdFTV9XQVJOX09OKHJl
dCA9PSAtRUlPKSkKPiAtCQlyZXQgPSAtRUlOVkFMOwo+IC0KPiAgIAlkZXZfZXJyKGRldl9wcml2
LT5kcm0uZGV2LCAiR3VDIGluaXRpYWxpemF0aW9uIGZhaWxlZCAlZFxuIiwgcmV0KTsKPiAtCXJl
dHVybiByZXQ7Cj4gKwo+ICsJLyogTWFyayBHdUMgZmlybXdhcmUgYXMgZmFpbGVkIHRvIGF2b2lk
IHJlZHVuZGFudCBjbGVhbi11cCAqLwp1Y19maW5pX2h3IGlzIG5vdCByZWR1bmRhbnQuIHVjX2Zp
bmlbX21pc2NdIHdhcyByZWR1bmRhbnQuIE1heSBiZSB3ZSAKc2hvdWxkIHNheQoidG8gYXZvaWQg
Y2xlYW4tdXAgb24gd2VkZ2VkIgo+ICsJZ3VjLT5mdy5sb2FkX3N0YXR1cyA9IElOVEVMX1VDX0ZJ
Uk1XQVJFX0ZBSUw7Cj4gKwo+ICsJLyogV2Ugd2FudCB0byBkaXNhYmxlIEdQVSBzdWJtaXNzaW9u
IGJ1dCBrZWVwIEtNUyBhbGl2ZSAqLwo+ICsJcmV0dXJuIC1FSU87Cj4gICB9Cj4gICAKPiAgIHZv
aWQgaW50ZWxfdWNfZmluaV9odyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4g
QEAgLTQzNyw2ICs0MzksOSBAQCB2b2lkIGludGVsX3VjX2ZpbmlfaHcoc3RydWN0IGRybV9pOTE1
X3ByaXZhdGUgKmRldl9wcml2KQo+ICAgCj4gICAJR0VNX0JVR19PTighSEFTX0dVQyhkZXZfcHJp
dikpOwo+ICAgCj4gKwlpZiAoIWludGVsX2d1Y19pc19sb2FkZWQoZ3VjKSkKPiArCQlyZXR1cm47
Cj4gKwpDYW4gd2Ugc2tpcCBiYXNlZCBvbiBpOTE1X3Rlcm1pbmFsbHlfd2VkZ2VkIGluc3RlYWQ/
ClNpbWlsYXJseSB3ZWRnZWQgY2hlY2sgaXMgbmVlZGVkIGZvciBpbnZva2luZyBvdGhlciBwb3J0
aW9uIG9mIAppOTE1X2dlbV9maW5pIGxpa2UgZ2VtX2NsZWFudXBfZW5naW5lcywgZ2VtX2NvbnRl
eHRzX2Zpbmkgc2luY2UKd2Ugc2tpcHBlZCB0aGVtIG9uIC1FSU8gZHVyaW5nIGdlbV9pbml0Lgo+
ICAgCWlmIChVU0VTX0dVQ19TVUJNSVNTSU9OKGRldl9wcml2KSkKPiAgIAkJaW50ZWxfZ3VjX3N1
Ym1pc3Npb25fZGlzYWJsZShndWMpOwo+ICAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX3VjX2Z3LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Y19mdy5o
Cj4gaW5kZXggZDVmZDQ2MC4uMGUzYjIzNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v
aTkxNS9pbnRlbF91Y19mdy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWNf
ZncuaAo+IEBAIC0xMTUsNiArMTE1LDExIEBAIHN0YXRpYyBpbmxpbmUgYm9vbCBpbnRlbF91Y19m
d19pc19zZWxlY3RlZChzdHJ1Y3QgaW50ZWxfdWNfZncgKnVjX2Z3KQo+ICAgCXJldHVybiB1Y19m
dy0+cGF0aCAhPSBOVUxMOwo+ICAgfQo+ICAgCj4gK3N0YXRpYyBpbmxpbmUgYm9vbCBpbnRlbF91
Y19md19pc19sb2FkZWQoc3RydWN0IGludGVsX3VjX2Z3ICp1Y19mdykKPiArewo+ICsJcmV0dXJu
IHVjX2Z3LT5sb2FkX3N0YXR1cyA9PSBJTlRFTF9VQ19GSVJNV0FSRV9TVUNDRVNTOwo+ICt9Cj4g
Kwo+ICAgdm9pZCBpbnRlbF91Y19md19mZXRjaChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2
X3ByaXYsCj4gICAJCSAgICAgICBzdHJ1Y3QgaW50ZWxfdWNfZncgKnVjX2Z3KTsKPiAgIGludCBp
bnRlbF91Y19md191cGxvYWQoc3RydWN0IGludGVsX3VjX2Z3ICp1Y19mdywKCi0tIApUaGFua3Ms
ClNhZ2FyCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ
bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0
cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK