From: "Noralf Trønnes" <noralf@tronnes.org>
To: Peter Stuge <peter@stuge.se>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/gud: Add Raspberry Pi Pico ID
Date: Thu, 8 Jul 2021 15:41:31 +0200 [thread overview]
Message-ID: <feaa0011-a6ee-527b-b2ae-93068bf972f6@tronnes.org> (raw)
In-Reply-To: <20210703192448.26298.qmail@stuge.se>
Den 03.07.2021 21.24, skrev Peter Stuge:
> Hi Noralf,
>
> Noralf Trønnes wrote:
>> Add VID/PID for the Raspberry Pi Pico implementation.
>> Source: https://github.com/notro/gud-pico
>>
>> +++ b/drivers/gpu/drm/gud/gud_drv.c
>> @@ -660,6 +660,7 @@ static int gud_resume(struct usb_interface *intf)
>>
>> static const struct usb_device_id gud_id_table[] = {
>> { USB_DEVICE_INTERFACE_CLASS(0x1d50, 0x614d, USB_CLASS_VENDOR_SPEC) },
>> + { USB_DEVICE_INTERFACE_CLASS(0x16d0, 0x10a9, USB_CLASS_VENDOR_SPEC) },
>> { }
>> };
>
> A VID/PID isn't neccessarily tied to one implementation; as long as an
> implementation is in fact compatible with the driver I consider it okay
> to reuse a VID/PID, and the 0x1d50 conditions are met by gud-pico too.
> That said, there's no harm in adding another id. :)
>
> Reviewed-by: Peter Stuge <peter@stuge.se>
>
Both patches applied, thanks for reviewing.
Noralf.
prev parent reply other threads:[~2021-07-08 13:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-03 14:13 [PATCH 1/2] drm/gud: Add Raspberry Pi Pico ID Noralf Trønnes
2021-07-03 14:13 ` [PATCH 2/2] drm/gud: Add async_flush module parameter Noralf Trønnes
2021-07-03 19:29 ` Peter Stuge
2021-07-03 19:24 ` [PATCH 1/2] drm/gud: Add Raspberry Pi Pico ID Peter Stuge
2021-07-08 13:41 ` Noralf Trønnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=feaa0011-a6ee-527b-b2ae-93068bf972f6@tronnes.org \
--to=noralf@tronnes.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=peter@stuge.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.