From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-lf0-f67.google.com ([209.85.215.67]:33517 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751023AbdCQTtZ (ORCPT ); Fri, 17 Mar 2017 15:49:25 -0400 Received: by mail-lf0-f67.google.com with SMTP id r36so6193797lfi.0 for ; Fri, 17 Mar 2017 12:49:24 -0700 (PDT) Subject: Re: [RFC v4 06/21] ath10k: sdio support To: Kalle Valo References: <1487693741-10042-1-git-send-email-erik.stromdahl@gmail.com> <1487693741-10042-7-git-send-email-erik.stromdahl@gmail.com> <8760jh2uy8.fsf@kamboji.qca.qualcomm.com> <871su52th2.fsf@kamboji.qca.qualcomm.com> <2528f323-6ec7-915c-d98b-615db04510e9@gmail.com> <877f3qyc5g.fsf@kamboji.qca.qualcomm.com> <29c3dd40-c3ac-746e-d8ef-cb072c58578a@gmail.com> <87y3w5tvkq.fsf@kamboji.qca.qualcomm.com> Cc: "linux-wireless@vger.kernel.org" , "ath10k@lists.infradead.org" From: Erik Stromdahl Message-ID: (sfid-20170317_204959_026669_2313D166) Date: Fri, 17 Mar 2017 16:54:08 +0100 MIME-Version: 1.0 In-Reply-To: <87y3w5tvkq.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2017-03-16 10:33, Kalle Valo wrote: > Erik Stromdahl writes: > >>> There seems to be same pattern for reading four bytes, what if we should >>> add a helper for that? Something like ath10k_sdio_read32()? It could >>> handle the kmalloc and switch endianess also. >>> >>> But please don't make any chances to sdio.c for the moment, let me >>> submit v5 first. >>> >> I notice that you have submitted v5 (and v6) of the sdio patches. Great! >> >> I assume you will add them to master-pending soon so I will try out >> everything (usb too) as soon as they are on master-pending. > > v6 is now in master-pending. > I have added my usb patches on top of sdio v6 and everything works as expected (both usb and sdio). Your changes does not seem to have broken anything. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1couD2-00032U-Ll for ath10k@lists.infradead.org; Fri, 17 Mar 2017 15:54:35 +0000 Received: by mail-lf0-x241.google.com with SMTP id v2so5817047lfi.2 for ; Fri, 17 Mar 2017 08:54:11 -0700 (PDT) Subject: Re: [RFC v4 06/21] ath10k: sdio support References: <1487693741-10042-1-git-send-email-erik.stromdahl@gmail.com> <1487693741-10042-7-git-send-email-erik.stromdahl@gmail.com> <8760jh2uy8.fsf@kamboji.qca.qualcomm.com> <871su52th2.fsf@kamboji.qca.qualcomm.com> <2528f323-6ec7-915c-d98b-615db04510e9@gmail.com> <877f3qyc5g.fsf@kamboji.qca.qualcomm.com> <29c3dd40-c3ac-746e-d8ef-cb072c58578a@gmail.com> <87y3w5tvkq.fsf@kamboji.qca.qualcomm.com> From: Erik Stromdahl Message-ID: Date: Fri, 17 Mar 2017 16:54:08 +0100 MIME-Version: 1.0 In-Reply-To: <87y3w5tvkq.fsf@kamboji.qca.qualcomm.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo Cc: "linux-wireless@vger.kernel.org" , "ath10k@lists.infradead.org" On 2017-03-16 10:33, Kalle Valo wrote: > Erik Stromdahl writes: > >>> There seems to be same pattern for reading four bytes, what if we should >>> add a helper for that? Something like ath10k_sdio_read32()? It could >>> handle the kmalloc and switch endianess also. >>> >>> But please don't make any chances to sdio.c for the moment, let me >>> submit v5 first. >>> >> I notice that you have submitted v5 (and v6) of the sdio patches. Great! >> >> I assume you will add them to master-pending soon so I will try out >> everything (usb too) as soon as they are on master-pending. > > v6 is now in master-pending. > I have added my usb patches on top of sdio v6 and everything works as expected (both usb and sdio). Your changes does not seem to have broken anything. _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k