From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B268AC433F5 for ; Tue, 7 Sep 2021 23:30:32 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6E2D6108D for ; Tue, 7 Sep 2021 23:30:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B6E2D6108D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CBBBD82C87; Wed, 8 Sep 2021 01:30:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="d1LdwUK+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5B40C82C89; Wed, 8 Sep 2021 01:30:26 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 33E4F82C2B for ; Wed, 8 Sep 2021 01:30:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1631057422; bh=TsPRCwjVLHT/PTN1DTOsWjpTo4JyJxiTfKZlQMyMXWI=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=d1LdwUK+/pCjEsaBOm8LkOhGmvfxIiEYOiAa2jdzk5U7+PdCc754200kPcE55Kp/I wPrXOtRpB+3BoSBZEmb5jrTA/047AqBI0clEU7oF/2hGXgACRXHwfgF3BIVvjUo3TS gTuTbj/mhvWSCihXE7/xoAOCJlfxt8OPyGe0RypI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.35] ([88.152.144.157]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MrQEn-1mhd6Y3PUd-00oZ4i; Wed, 08 Sep 2021 01:30:21 +0200 Subject: Re: [PATCH 1/1] efi_loader: require CONFIG_BLK To: AKASHI Takahiro , u-boot@lists.denx.de, Alexander Graf , Simon Glass References: <20210907070108.8200-1-xypron.glpk@gmx.de> <20210907112517.GB49004@laputa> From: Heinrich Schuchardt Message-ID: Date: Wed, 8 Sep 2021 01:30:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210907112517.GB49004@laputa> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:2X4mmeC/W2wSpXUUWGMk10NnjhR9fXudKwHopAXMAqQTl3ocSCU lB6AYrFnvvi6FLYpBh45aFnhUJ/hRMy1EpBJSnQY29qXWjT4Qi74+CvqadGJbQSyr3Gf3ea TqCspJVmSjA5lKLmpdhkp3Kp+Qjh3L2rzJo0z1GweLTPB85ZB9JwuyMxhXuqCQoUe1RJRLN 98xiwj+5YP5qXZX9ampOQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:B1T3WH9Y4Aw=:spfFrnsEdb2gBJ8BLJVH1p HI4SmnfhdyEXSQ2nQcG6yAs8Y22oBBDqupdNfpQBErj9XkEz/n3gc7KqgUCtKl2aIePIYPZOl 7xHWu0695DAP0TITnSckq22zjfq6mQ0xG5gdCkVPf1Tu/25cwzA5xgwERsPhp0io8bXI9zNMF qLfiSOJOxGgXEthq3yic2bbPfx6JDta/4qNdJvbicZSO+ZxhVf0WJdzx5Kh1ToPnFd8EE/2Ji Stq11KyBx7nAgdhAxPcuS6Vgc1ggRQziwrK9PyozLn2GsBGki3zu6iVukiCU8LeTHmMQ/E5Cj nZilhdM4m1Ziuwloj1W8FpS5WtJR50Ot014JzJ/ud+3W7ZY/YelwG3LGct+D02sRRJkm7S0L9 qKbq6RKMhpji3r/d+7ThuPP3pztuH7r1BJbDBn46b7uDd7UPp08/1j5In90MdPASTEQLxa3EI iWiHEN+5XbbolI0h7HXaKNTnvgHqkLKGUNlOAaEwS+LuvE+ZxshVUDDknugE1burgq4f3B2lb EaKS+j2A1NDYrCJjmgG4KA37ndmzuGkltLdmixAg+XpsTLNVHdGXFSTz4S/M9PZth/g5CB/ww HhpU0h8Sq13wnFv8eVvtmc6i29WCFbcFfvnqCBcmm2pEVbli7jbAdmp8JM37oUfomijH2SIbm J9heSnwRGhWR9Wxetk6t2OuAwdXCZw0nD7Jy8IV0J2glbTkdaNOFq9gaivNIYQYld0iW8Q7R0 9ppw4xIWSBa9l1ltmBj6p2CKc8ESXQ0/wfVe09C+leFYGZQoSRkl1Ix04Vi9xj7OVBhnWa5Hy O6U1LIDpMdmyb1gpQQTqtsSlt/U6YtER0O4vmMrPdFs3yksRo+Ah3/S4j6uUCHTcoIZdPjYeC zQdrDudQ2hHl1qsxhbvRpeD4rx/nSQnBzp7LO788eWUmgE5gwFH7VNPsKXYv3OlYGFHttYEgU kGDetU/xHFMkIUF2Z9E2D57AtvwtGENR0TikcG8yuGG+sdIfhPHjvfw4cZKTBBenNeu6h2MhQ FwVouA+uq2N8RmTzdVv3NtjAQZ2I9MupMfyGUA27ztUHf83zfDpSXMtWWvkKtY+e8kro9N+3i RVRS4KBsb54ZPSdGHglSo1MtcTvtMru8d+M0BaOtKZnBWlQxhfLy85mCQ== X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 9/7/21 1:25 PM, AKASHI Takahiro wrote: > On Tue, Sep 07, 2021 at 09:01:08AM +0200, Heinrich Schuchardt wrote: >> The move to driver model should by now be completed. To be able to remo= ve >> pre-driver model code from our block IO code require CONFIG_BLK=3Dy for= UEFI >> support. > > If so, we can safely remove !CONFIG_BLK-related code > from efi_disk.c and efi_device_path.c. Yes, that was my intent. As we want to improve the integration with the driver model we should get rid of the outdated non-BLK code. Let's merge that into the next branch. Best regards Heinrich > > -Takahiro Akashi > > >> Signed-off-by: Heinrich Schuchardt >> --- >> lib/efi_loader/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig >> index dacc3b5881..692cf5ced0 100644 >> --- a/lib/efi_loader/Kconfig >> +++ b/lib/efi_loader/Kconfig >> @@ -10,6 +10,7 @@ config EFI_LOADER >> depends on !EFI_STUB || !X86_64 || EFI_STUB_64BIT >> # We need EFI_STUB_32BIT to be set on x86_32 with EFI_STUB >> depends on !EFI_STUB || !X86 || X86_64 || EFI_STUB_32BIT >> + depends on BLK >> default y if !ARM || SYS_CPU =3D armv7 || SYS_CPU =3D armv8 >> select LIB_UUID >> select PARTITION_UUIDS >> -- >> 2.30.2 >>