All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Song Gao <gaosong@loongson.cn>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, f4bug@amsat.org,
	alex.bennee@linaro.org, yangxiaojuan@loongson.cn
Subject: Re: [PATCH for-7.1 4/5] target/loongarch: Update loongarch-fpu.xml
Date: Thu, 4 Aug 2022 09:06:37 -0700	[thread overview]
Message-ID: <fec78f36-159d-50b0-1113-e2286e464d99@linaro.org> (raw)
In-Reply-To: <20220804130213.1364164-5-gaosong@loongson.cn>

On 8/4/22 06:02, Song Gao wrote:
> Rename loongarch-fpu64.xml to loongarch-fpu.xml and update loongarch-fpu.xml to match upstream GDB [1]
> 
> [1]:https://github.com/bminor/binutils-gdb/blob/master/gdb/features/loongarch/fpu.xml
> 
> Signed-off-by: Song Gao <gaosong@loongson.cn>
> ---
>   configs/targets/loongarch64-softmmu.mak |  2 +-
>   gdb-xml/loongarch-fpu.xml               | 50 ++++++++++++++++++++++
>   gdb-xml/loongarch-fpu64.xml             | 57 -------------------------
>   target/loongarch/gdbstub.c              |  2 +-
>   4 files changed, 52 insertions(+), 59 deletions(-)
>   create mode 100644 gdb-xml/loongarch-fpu.xml
>   delete mode 100644 gdb-xml/loongarch-fpu64.xml
> 
> diff --git a/configs/targets/loongarch64-softmmu.mak b/configs/targets/loongarch64-softmmu.mak
> index 483474ba93..9abc99056f 100644
> --- a/configs/targets/loongarch64-softmmu.mak
> +++ b/configs/targets/loongarch64-softmmu.mak
> @@ -1,5 +1,5 @@
>   TARGET_ARCH=loongarch64
>   TARGET_BASE_ARCH=loongarch
>   TARGET_SUPPORTS_MTTCG=y
> -TARGET_XML_FILES= gdb-xml/loongarch-base64.xml gdb-xml/loongarch-fpu64.xml
> +TARGET_XML_FILES= gdb-xml/loongarch-base64.xml gdb-xml/loongarch-fpu.xml
>   TARGET_NEED_FDT=y
> diff --git a/gdb-xml/loongarch-fpu.xml b/gdb-xml/loongarch-fpu.xml
> new file mode 100644
> index 0000000000..a61057ec44
> --- /dev/null
> +++ b/gdb-xml/loongarch-fpu.xml
> @@ -0,0 +1,50 @@
> +<?xml version="1.0"?>
> +<!-- Copyright (C) 2021 Free Software Foundation, Inc.
> +
> +     Copying and distribution of this file, with or without modification,
> +     are permitted in any medium without royalty provided the copyright
> +     notice and this notice are preserved.  -->
> +
> +<!DOCTYPE feature SYSTEM "gdb-target.dtd">
> +<feature name="org.gnu.gdb.loongarch.fpu">
> +
> +  <union id="fputype">
> +    <field name="f" type="ieee_single"/>
> +    <field name="d" type="ieee_double"/>
> +  </union>
> +
> +  <reg name="f0" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f1" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f2" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f3" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f4" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f5" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f6" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f7" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f8" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f9" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f10" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f11" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f12" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f13" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f14" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f15" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f16" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f17" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f18" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f19" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f20" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f21" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f22" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f23" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f24" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f25" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f26" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f27" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f28" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f29" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f30" bitsize="64" type="fputype" group="float"/>
> +  <reg name="f31" bitsize="64" type="fputype" group="float"/>
> +  <reg name="fcc" bitsize="64" type="fputype" group="float"/>

While this matches upstream gdb, the type of fcc should be uint64_t.
Interpreting these 8 bits (lsb of each byte) as a double is going to fail badly.


r~


  reply	other threads:[~2022-08-04 16:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-04 13:02 [PATCH for-7.1 0/5] Fix gdb bugs and update gdb-xml Song Gao
2022-08-04 13:02 ` [PATCH for-7.1 1/5] target/loongarch: Fix GDB get the wrong pc Song Gao
2022-08-04 15:56   ` Richard Henderson
2022-08-04 13:02 ` [PATCH for-7.1 2/5] target/loongarch: add gdb_arch_name() Song Gao
2022-08-04 16:02   ` Richard Henderson
2022-08-04 13:02 ` [PATCH for-7.1 3/5] target/loongarch: update loongarch-base64.xml Song Gao
2022-08-04 16:03   ` Richard Henderson
2022-08-04 13:02 ` [PATCH for-7.1 4/5] target/loongarch: Update loongarch-fpu.xml Song Gao
2022-08-04 16:06   ` Richard Henderson [this message]
2022-08-04 13:02 ` [PATCH for-7.1 5/5] target/loongarch: Update gdb_set_fpu() and gdb_get_fpu() Song Gao
2022-08-04 16:08   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fec78f36-159d-50b0-1113-e2286e464d99@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=f4bug@amsat.org \
    --cc=gaosong@loongson.cn \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=yangxiaojuan@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.