From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45445C4321E for ; Thu, 24 Nov 2022 13:24:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229806AbiKXNYP (ORCPT ); Thu, 24 Nov 2022 08:24:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229652AbiKXNYO (ORCPT ); Thu, 24 Nov 2022 08:24:14 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A29D38EB66 for ; Thu, 24 Nov 2022 05:24:13 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id n3so2477657wrp.5 for ; Thu, 24 Nov 2022 05:24:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=TWdHEIhQJolLV9piJexmiUcaauZy35sANMJtric59n0=; b=rguYDKI2ty6fv9ZQMrfQIWwdHVGPDqvPXCToXJrEc69ZEGKb3NO6hMtm/CiAVNJVed i2G3xhlHQEhr809vJ4kyNtFqxNKMKZYAprs6Q/+w1OpP8uvo0r5fNVmsYFJ6yJgBt63L bd3x2H/MI19t73WlG+xJn+7GYyG3aE8+kMM5ELJQEFy/OP/Om37zVIUSCd5oguthql3Y Iowsnr2dijU6MPbeai3zQtYiXz0xhopxyxa3TzObO40YBFaZlq5Mk3hBz7Vuxxoda4wh XbW1a1h0EJw2gbCsWw3n9YhNyefQaAbsm0AcoVmQqg5NjCezJ7G6RXcCCTkFDpszLkXB hTlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TWdHEIhQJolLV9piJexmiUcaauZy35sANMJtric59n0=; b=Lis2Q2VqEP1sGHH44XeLoXMeBW9C9qYMfkQfFOFTyCLCu3IrbF3yslAEtg3YUEP2wN kSHqjhUEkCvGvEzvhsd+JhdEJj3jq4rFRfxiA4lriQcsFoQzjOK5Cgb9n5X6Ab0SvDzO Fl7a4GISJVueO3ujiBJQNO0/u+/ZL+TstJ+KHmr3B3V+5ta3x/4FuqztV0xUpo+grnZI 3E8TqnbcNWYb3h+Kume7+XQJqvl1Go0BbNkG2hBuFirUGBB4etfUU23spPt5SpbSTh3E 54OXmXwLmeyB8qwPT6ZOfzcO1rJEXYOmTkkTkREsQwd5gi/L5o8+JQfgCKReNbuRPNnK lfrw== X-Gm-Message-State: ANoB5plxWdIqIP9DTo4+2Cg9G110oNq8MUioc5HmA//SHBpBhZTFwT9o ZQAA+4s0Uea3AF3Npt6Ox0fX+g== X-Google-Smtp-Source: AA0mqf7Jn3k6EzokKUy0sxQU+IibqSzMAOZEuSw/2DJkBMIxO1OmsoHYBspu6A8noUsbL8KEcvB/9Q== X-Received: by 2002:adf:ec04:0:b0:236:63fa:c792 with SMTP id x4-20020adfec04000000b0023663fac792mr8349892wrn.476.1669296252202; Thu, 24 Nov 2022 05:24:12 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:c48e:30d8:4886:1148? ([2a01:e0a:982:cbb0:c48e:30d8:4886:1148]) by smtp.gmail.com with ESMTPSA id i19-20020a1c5413000000b003cfc02ab8basm6163783wmb.33.2022.11.24.05.24.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Nov 2022 05:24:11 -0800 (PST) Message-ID: Date: Thu, 24 Nov 2022 14:24:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v2 2/4] dt-bindings: pinctrl: qcom,tlmm-common: document i2c pull property Content-Language: en-US To: Linus Walleij , Abel Vesa Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Linux Kernel Mailing List , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, "linux-gpio@vger.kernel.org" References: <20221123152001.694546-1-abel.vesa@linaro.org> <20221123152001.694546-3-abel.vesa@linaro.org> Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Linus, On 24/11/2022 14:11, Linus Walleij wrote: > On Wed, Nov 23, 2022 at 4:20 PM Abel Vesa wrote: > >> From: Neil Armstrong >> >> Document the new i2c_pull property introduced for SM8550 setting >> an I2C specific pull mode on I2C able pins. >> >> Signed-off-by: Neil Armstrong >> Signed-off-by: Abel Vesa > (...) >> + qcom,i2c-pull: >> + type: boolean >> + description: enable bias pull feature designed for I2C on pin > > But what is this? > > I2C buses are usually just plain old bias-high-impedance, high-z > or open drain, wire-or or whatever you want to call it. > > But now there is some special i2c mode, huh? > > The description is pretty much "it is what it is"... can we have > some explanation about what this means electrically speaking > and why you cannot use bias-high-impedance? I'll try to get some more info, but so far I only found what I wrote in the bindings. Neil > > Yours, > Linus Walleij