From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrice CHOTARD Date: Fri, 26 Mar 2021 16:13:29 +0100 Subject: [PATCH 2/3] configs: stm32mp1: Remove misleading CONFIG_SPL_BSS_START_ADDR In-Reply-To: <20210322132001.1637567-2-mr.nuke.me@gmail.com> References: <20210322132001.1637567-1-mr.nuke.me@gmail.com> <20210322132001.1637567-2-mr.nuke.me@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Alexandru On 3/22/21 2:20 PM, Alexandru Gagniuc wrote: > CONFIG_SPL_BSS_START_ADDR is only used on a few mach- linker scripts. > stm32mp1 uses the generic script under arch/arm/cpu/u-boot-spl.lds, > which does not make use of this definition. > > The SPL BSS starts in SRAM, right after .text, .rodata, .data, and > .u_boot_list. A very short version of the STM32MP1 memory map is: > * SYSRAM: 2ffc0000 - 30000000 <- all of SPL is here > * DRAM: c0000000+ > > 0xC0200000 is a DRAM address, and has nothing to do with SPL. It is > just very misleading to have it next to CONFIG_SPL_BSS_MAX_SIZE, or to > have it at all. > > Signed-off-by: Alexandru Gagniuc > --- > include/configs/stm32mp1.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/configs/stm32mp1.h b/include/configs/stm32mp1.h > index 7fdb3ffce4..56a70cb584 100644 > --- a/include/configs/stm32mp1.h > +++ b/include/configs/stm32mp1.h > @@ -50,7 +50,6 @@ > /* SPL support */ > #ifdef CONFIG_SPL > /* SPL use DDR */ > -#define CONFIG_SPL_BSS_START_ADDR 0xC0200000 > #define CONFIG_SPL_BSS_MAX_SIZE 0x00100000 > #define CONFIG_SYS_SPL_MALLOC_START 0xC0300000 > #define CONFIG_SYS_SPL_MALLOC_SIZE 0x01D00000 > Reviewed-by: Patrice Chotard Thanks Patrice