From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96B8EC43334 for ; Mon, 20 Jun 2022 06:52:14 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DA7B18015D; Mon, 20 Jun 2022 08:52:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="FWN6Rv1o"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5EC9D80166; Mon, 20 Jun 2022 08:52:11 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2061b.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e88::61b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1B5E080138 for ; Mon, 20 Jun 2022 08:52:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lLPX4cfedt3TAHsxTB3UWReOa9/CUQNRNQI2mvUKfgF9rzoMxiEYMItU/aeABiFgThXxQt7sVpaF1dHqc9tDMykFkMdVsQ2d3Vgdn7D4kARRut0FTbUiSz5QRrw6qvpJfc6wzOfiwiqjpkCHnPseA1/TDoinmJbF6ngQsvP3dU2zFyDZt5915kqeZkB9w5xW5ai8c6nY2iSoxcXFHWxZ7vIW6m5mvh4XV/9TbqBZLYXdap1dwHV9kaGSVhaG1xP5YR8gwL6LGVU2bVCV3+8MKagTkpmdfrKXuEgOT96+fPJkOBAPPzA32rqIb/xB23R9GMh94nd0ELH69DxeQDfI/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9T8RlI2IHvm2BGZ2fHUaU84ksfFP2yd4dP6HA/dsQBM=; b=G37CGZyEQnbnNDsW7Az7dop+uupotD2ZQJ4K6SRW2asE/T5TMK3A/Gm+lQSiFO/R/k1acuQviaKWRHtfwb65ewJXLYbh+xJviuSkLHCguPETqHgtr8QaQo0ZAJX9t6NcBq+5PJDG7F9NmiBW72NzqIW70/Y7qKQBkMAaj7AkZ411gfuanHhW9/LbaPSWvViz488iRViF8txsQvFE00FfPloaSTYfl0vZR0TsEIY2LHuTb04ugwZ1pRMO3BzYELXN3m686ZzRAkW16xI96axud4wtylqffb6nfVki54lPhEn/Fpk5bg/wEiXTMShFZZMQxhMV5yhqHwRyiN7gpwdniA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=weidmueller.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9T8RlI2IHvm2BGZ2fHUaU84ksfFP2yd4dP6HA/dsQBM=; b=FWN6Rv1o+Wn64U/0Eg+++9TceLJhDR2EIV3baNQxAnJkmxroGj2F0zixczP3xMxE7ZnjtbEzhFe4HHGkTWG4JITjnD7TI5nCr9m0d/R6VWJFQBfrwKh7wp5oN40om44YyD4pNUu6Iy0NoVcHA9YMBk1ZpK7eBtevN+RyDRWFod0= Received: from DM5PR07CA0129.namprd07.prod.outlook.com (2603:10b6:3:13e::19) by BL0PR12MB5690.namprd12.prod.outlook.com (2603:10b6:208:82::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14; Mon, 20 Jun 2022 06:52:04 +0000 Received: from DM6NAM11FT038.eop-nam11.prod.protection.outlook.com (2603:10b6:3:13e:cafe::d9) by DM5PR07CA0129.outlook.office365.com (2603:10b6:3:13e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14 via Frontend Transport; Mon, 20 Jun 2022 06:52:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT038.mail.protection.outlook.com (10.13.173.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5353.14 via Frontend Transport; Mon, 20 Jun 2022 06:52:03 +0000 Received: from [10.254.241.52] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 20 Jun 2022 01:52:00 -0500 Message-ID: Date: Mon, 20 Jun 2022 08:51:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 02/10] firmware: firmware-zynqmp: Probe driver before use Content-Language: en-US To: Stefan Herbrechtsmeier , CC: Stefan Herbrechtsmeier , Adrian Fiergolski , Ashok Reddy Soma , Jaehoon Chung , T Karthik Reddy References: <20220608162054.25641-1-stefan.herbrechtsmeier-oss@weidmueller.com> <20220608162054.25641-3-stefan.herbrechtsmeier-oss@weidmueller.com> <8140173f-3a64-7a34-94c0-d9965eec4821@amd.com> <7f28601d-5d2a-b65f-3b99-53a412e25664@weidmueller.com> From: Michal Simek In-Reply-To: <7f28601d-5d2a-b65f-3b99-53a412e25664@weidmueller.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9861cfa0-9d3e-437f-bbc1-08da52896246 X-MS-TrafficTypeDiagnostic: BL0PR12MB5690:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /nOnlqHpWyQ/R8bpHF5dbplmf05sY5J9yMUBDzB05ODF4pgVK10cdnuHL8DN0PbRRaXguhbmHXvbLVCrmJUflXzuF86/oewHiSRxwBAfrjcjrpuHoWvnogwB7uFOxdPQz/oDztotvJDaHA4UBQq27ds0et+eF4fcwjfA2RUjT4bNjPQ+Guv7qiJ2gAhwKdsDT3Y++VlA6h7fU2SumrxtgsgjX2Riqho+Ab6yVN+/J/CHcqAIm6mOCsvDMIzOTfj1l9Psw2lWxuObn187FhuPB5og3x8Ovb+P+NDypY0Z/X361+FiSCSRUQHTVDxQLgVCfZvVWRXVQTYi8Qhm+d2DE+49JprJHMhza5x1FoNh+kfIy+7tGGUjzPkEs5ePRGR5oltrI9uGvKa6dGo2OnDfX0y/vZpGOBVQxJNfD8H/pbou6o4YdiWDJPrxlYHYRpqtq8iZbxzsxWXAsj4AwZDF1gI6SdtnI+zpR9vFOlYAQXlhc/JPlnUWL4GhKR74q1J8hNdDyhmkqIXRW1esQEsen14BMamcM06cxFWTN83LjUiOu7z8AttvQcF0aqVUr9WgtRipjtBghleeJuFXXksbmcBjCoqzCpoVkOoFgr2kX/n9RDKvvqCG3a1Ot28PJiehN5OWjegwKcgON9PWmYrL+nF+Iqt+cLUxQrWJGX3BBtk3w3Hu+abpr7yikNmDXwugTyN/g9SPXozE5V3KFmfUW+2bQ9K8w8KWFQ5Eg+eZnp+SRSdDymtcHxbjtqLyCr9pFS2RHcQSpKAnNWXY3yLdbA== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(376002)(346002)(136003)(396003)(36840700001)(40470700004)(46966006)(110136005)(8936002)(40480700001)(82310400005)(26005)(4326008)(82740400003)(41300700001)(54906003)(2906002)(86362001)(31696002)(36860700001)(4744005)(107886003)(70586007)(36756003)(31686004)(336012)(478600001)(47076005)(356005)(70206006)(2616005)(16526019)(186003)(53546011)(81166007)(40460700003)(316002)(8676002)(44832011)(5660300002)(426003)(16576012)(43740500002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2022 06:52:03.8052 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9861cfa0-9d3e-437f-bbc1-08da52896246 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT038.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB5690 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi, On 6/20/22 08:40, Stefan Herbrechtsmeier wrote: > Am 16.06.2022 um 16:22 schrieb Michal Simek: >> On 6/8/22 18:20, Stefan Herbrechtsmeier wrote: >>> [CAUTION: External Email] >>> >>> From: Stefan Herbrechtsmeier >>> >>> Probe the driver before use to ensure that the global data are valid. >> >> It is not clear what the issue is. And this function is called in SPL or EL3 >> and likely multiple times. >> Can you please clarify? > > The driver only works if it is used after u-boot,dm-pre-reloc. This change is > needed to support a usage by other drivers like xlnx,zynqmp-firmware. Can you please describe the case, execution path where it is used before? Also that calling multiple times is just adding overhead for boot up time. We should try to avoid it as much as possible. M