Hi Christophe, On 01/19/2017 02:15 AM, Christophe Ronco wrote: > During gprs-context driver probe function, check kernel device driver > data format and modem low level data format. > If they are different, align kernel device driver data format on > modem low level data format. > If an error occurs during this process, continue probing without error. > This is inspired by what is done in qmicli and qmi-network (package > libqmi). > --- > drivers/qmimodem/gprs-context.c | 79 +++++++++++++++++++++++++++++++++++++++-- > drivers/qmimodem/qmi.h | 1 + > drivers/qmimodem/wda.h | 25 +++++++++++++ > 3 files changed, 102 insertions(+), 3 deletions(-) > create mode 100644 drivers/qmimodem/wda.h > This looks fine to me. You do need to add wda.h to the build in Makefile.am and also update the Copyright in that file accordingly. Regards, -Denis