From: Stefano Babic <sbabic@denx.de>
To: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>, u-boot@lists.denx.de
Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH v2 6/6] board: apalis-tk1: launch toradex easy installer in usb recovery
Date: Fri, 6 Aug 2021 13:03:32 +0200 [thread overview]
Message-ID: <fedfac9e-b753-d006-79fd-22b7af7023af@denx.de> (raw)
In-Reply-To: <20210723063950.11326-7-oleksandr.suvorov@toradex.com>
On 23.07.21 08:39, Oleksandr Suvorov wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> The USB recovery mode is used by Toradex to load the Toradex Easy
> Installer image which supports further system images installation.
> Prepare for loading and launching the Toradex Easy Installer if the
> USB Recovery mode is activated.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> ---
>
> Changes in v2:
> - remove 2 patches not meet requirements.
> END
>
> board/toradex/apalis-tk1/apalis-tk1.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/board/toradex/apalis-tk1/apalis-tk1.c b/board/toradex/apalis-tk1/apalis-tk1.c
> index b97617cfca..f418f2c39f 100644
> --- a/board/toradex/apalis-tk1/apalis-tk1.c
> +++ b/board/toradex/apalis-tk1/apalis-tk1.c
> @@ -38,8 +38,17 @@
> int arch_misc_init(void)
> {
> if (readl(NV_PA_BASE_SRAM + NVBOOTINFOTABLE_BOOTTYPE) ==
> - NVBOOTTYPE_RECOVERY)
> - printf("USB recovery mode\n");
> + NVBOOTTYPE_RECOVERY) {
> + printf("USB recovery mode, attempting to boot Toradex Easy Installer\n");
> + env_set("bootdelay", "-2");
> + env_set("defargs", "pcie_aspm=off user_debug=30");
> + env_set("fdt_high", "");
> + env_set("initrd_high", "");
> + env_set("setup", "env set setupargs igb_mac=${ethaddr} consoleblank=0 no_console_suspend=1 console=${console},${baudrate}n8 ${memargs}");
> + env_set("teziargs", "rootfstype=squashfs root=/dev/ram quiet autoinstall");
> + env_set("vidargs", "video=HDMI-A-1:640x480-16@60D");
> + env_set("bootcmd", "run setup; env set bootargs ${defargs} ${setupargs} ${vidargs} ${teziargs}; bootm 0x80208000#config@${soc}-${fdt_module}-${fdt_board}.dtb");
These above are very long lines making checkpatch unhgappy. Can we
switch to a multiline ?
Best regards,
Stefano
> + }
>
> /* PCB Version Indication: V1.2 and later have GPIO_PV0 wired to GND */
> gpio_request(TEGRA_GPIO(V, 0), "PCB Version Indication");
>
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
next prev parent reply other threads:[~2021-08-06 11:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 6:39 [PATCH v2 0/6] Toradex boards' specific patches Oleksandr Suvorov
2021-07-23 6:39 ` [PATCH v2 1/6] board: colibri_imx7: use SDP if USB serial downloader has been used Oleksandr Suvorov
2021-07-23 6:39 ` [PATCH v2 2/6] board: toradex: make USB PID from config block optional Oleksandr Suvorov
2021-07-23 6:39 ` [PATCH v2 3/6] board: colibri-imx8x: update building documentation Oleksandr Suvorov
2021-07-23 6:39 ` [PATCH v2 4/6] board: colibri_imx6: add board_fit_config_name_match to support FIT in SPL Oleksandr Suvorov
2021-07-23 6:39 ` [PATCH v2 5/6] board: colibri_vf: fix compiling warning Oleksandr Suvorov
2021-07-23 6:39 ` [PATCH v2 6/6] board: apalis-tk1: launch toradex easy installer in usb recovery Oleksandr Suvorov
2021-08-06 11:03 ` Stefano Babic [this message]
2021-08-11 9:50 ` Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fedfac9e-b753-d006-79fd-22b7af7023af@denx.de \
--to=sbabic@denx.de \
--cc=marcel.ziswiler@toradex.com \
--cc=oleksandr.suvorov@toradex.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.