From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3AB4C433F5 for ; Wed, 27 Oct 2021 09:18:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 760EF61052 for ; Wed, 27 Oct 2021 09:18:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239528AbhJ0JVK (ORCPT ); Wed, 27 Oct 2021 05:21:10 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:47564 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S237410AbhJ0JVK (ORCPT ); Wed, 27 Oct 2021 05:21:10 -0400 X-UUID: 5f85a098493148fab95b3db43a181f3c-20211027 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=DnF617kfzUFWB+wTivNGwRZqdqT0fNx18iqxKeiaIoI=; b=hohhy9kXY+QlZnce9I8XyAyvddEsPo9QCRuS5fHZP1g3IFpOWbYgi8oK0j9LzTQodzJwz8dRDXEOBcfoVRWiv2aILx5nz3NUkhGWeqLe2vycs0USFjvpbCfPt1r7CBPSYofjAa6XJDYCXT6c7uN4RS4NYQCKS3k5TIKDfbghUvE=; X-UUID: 5f85a098493148fab95b3db43a181f3c-20211027 Received: from mtkcas11.mediatek.inc [(172.21.101.40)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 291350436; Wed, 27 Oct 2021 17:18:40 +0800 Received: from MTKMBS34N1.mediatek.inc (172.27.4.172) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 27 Oct 2021 17:18:39 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS34N1.mediatek.inc (172.27.4.172) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 27 Oct 2021 17:18:32 +0800 Received: from mhfsdcap04 (10.17.3.154) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 27 Oct 2021 17:18:32 +0800 Message-ID: Subject: Re: [PATCH v2 20/22] usb: host: xhci-mtk: deny IRQ0 From: Chunfeng Yun To: Sergey Shtylyov , , "Mathias Nyman" , Greg Kroah-Hartman CC: Matthias Brugger , , Date: Wed, 27 Oct 2021 17:18:31 +0800 In-Reply-To: <20211026173943.6829-21-s.shtylyov@omp.ru> References: <20211026173943.6829-1-s.shtylyov@omp.ru> <20211026173943.6829-21-s.shtylyov@omp.ru> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org T24gVHVlLCAyMDIxLTEwLTI2IGF0IDIwOjM5ICswMzAwLCBTZXJnZXkgU2h0eWx5b3Ygd3JvdGU6 DQo+IElmIHBsYXRmb3JtX2dldF9pcnEoKSByZXR1cm5zIElSUTAgKGNvbnNpZGVyZWQgaW52YWxp ZCBhY2NvcmRpbmcgdG8NCj4gTGludXMpDQo+IHRoZSBkcml2ZXIgYmxpdGhlbHkgcGFzc2VzIGl0 IHRvIHVzYl9hZGRfaGNkKCkgdGhhdCB0cmVhdHMgSVJRMCBhcyBubw0KPiBJUlENCj4gYXQgYWxs LiBEZW55IElSUTAgcmlnaHQgYXdheSwgcmV0dXJuaW5nIC1FSU5WQUwgZnJvbSB0aGUgcHJvYmUo KQ0KPiBtZXRob2QuLi4NCj4gDQo+IEZpeGVzOiAwY2JkNGIzNGNkYTkgKCJ4aGNpOiBtZWRpYXRl azogc3VwcG9ydCBNVEsgeEhDSSBob3N0DQo+IGNvbnRyb2xsZXIiKQ0KPiBTaWduZWQtb2ZmLWJ5 OiBTZXJnZXkgU2h0eWx5b3YgPHMuc2h0eWx5b3ZAb21wLnJ1Pg0KPiAtLS0NCj4gIGRyaXZlcnMv dXNiL2hvc3QveGhjaS1tdGsuYyB8IDQgKysrLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0 aW9ucygrKSwgMSBkZWxldGlvbigtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL2hv c3QveGhjaS1tdGsuYyBiL2RyaXZlcnMvdXNiL2hvc3QveGhjaS0NCj4gbXRrLmMNCj4gaW5kZXgg YzUzZjZmMjc2ZDVjLi5kMmRjOGQ5ODYzZWUgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvdXNiL2hv c3QveGhjaS1tdGsuYw0KPiArKysgYi9kcml2ZXJzL3VzYi9ob3N0L3hoY2ktbXRrLmMNCj4gQEAg LTQ5NSw3ICs0OTUsNyBAQCBzdGF0aWMgaW50IHhoY2lfbXRrX3Byb2JlKHN0cnVjdCBwbGF0Zm9y bV9kZXZpY2UNCj4gKnBkZXYpDQo+ICAJCXJldHVybiByZXQ7DQo+ICANCj4gIAlpcnEgPSBwbGF0 Zm9ybV9nZXRfaXJxX2J5bmFtZV9vcHRpb25hbChwZGV2LCAiaG9zdCIpOw0KPiAtCWlmIChpcnEg PCAwKSB7DQo+ICsJaWYgKGlycSA8PSAwKSB7DQo+ICAJCWlmIChpcnEgPT0gLUVQUk9CRV9ERUZF UikNCj4gIAkJCXJldHVybiBpcnE7DQo+ICANCj4gQEAgLTUwMyw2ICs1MDMsOCBAQCBzdGF0aWMg aW50IHhoY2lfbXRrX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UNCj4gKnBkZXYpDQo+ICAJ CWlycSA9IHBsYXRmb3JtX2dldF9pcnEocGRldiwgMCk7DQo+ICAJCWlmIChpcnEgPCAwKQ0KPiAg CQkJcmV0dXJuIGlycTsNCj4gKwkJaWYgKCFpcnEpDQppdCdzICJpZiAoaXJxIDw9IDApIj8NCg0K PiArCQkJcmV0dXJuIC1FSU5WQUw7DQo+ICAJfQ0KPiAgDQo+ICAJd2FrZXVwX2lycSA9IHBsYXRm b3JtX2dldF9pcnFfYnluYW1lX29wdGlvbmFsKHBkZXYsICJ3YWtldXAiKTsNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB60CC433EF for ; Wed, 27 Oct 2021 09:29:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6936161052 for ; Wed, 27 Oct 2021 09:29:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6936161052 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EWnomN5GS60HLtKYYHx7t7uYay7q07rR77Rm/zmgFZE=; b=mF/OWdchyT4qJO LtCXoS2E2NBjOvIMNfXSx2cLl35FIsbSSkTRZA1YWUzjlpLolgpNmqutn3+Vq/kWIwnVF1RjqoIvT 42XQ01KYGz6wh/QrLYzuUY2UPbaN55npcXp4KCG+hqjjbm2rEsITGRvEu0RTjOWe9DL9iVorprh4R N1EOB/u0OzJOXeLN3Hk9cqaGgQKQiILYYwXfa78+P9WJ1R80mcLHiPiPX+NVCya76k3c5b5oVrLFT yEUDAXXiTF2YThDxYE0xTWygF/CRgIF+CPWe2zttr138Pk3ZhkcbWOeTiiek+MxKqpZHxtnvphUBW kFjraSIsaZSE8qYtYbhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mffEy-004QGo-93; Wed, 27 Oct 2021 09:29:00 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mffEk-004QFd-V2; Wed, 27 Oct 2021 09:28:49 +0000 X-UUID: 13b542b51f81483cb70f8d239801b481-20211027 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=DnF617kfzUFWB+wTivNGwRZqdqT0fNx18iqxKeiaIoI=; b=hohhy9kXY+QlZnce9I8XyAyvddEsPo9QCRuS5fHZP1g3IFpOWbYgi8oK0j9LzTQodzJwz8dRDXEOBcfoVRWiv2aILx5nz3NUkhGWeqLe2vycs0USFjvpbCfPt1r7CBPSYofjAa6XJDYCXT6c7uN4RS4NYQCKS3k5TIKDfbghUvE=; X-UUID: 13b542b51f81483cb70f8d239801b481-20211027 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 391954331; Wed, 27 Oct 2021 02:28:42 -0700 Received: from MTKMBS34N1.mediatek.inc (172.27.4.172) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 27 Oct 2021 02:18:40 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS34N1.mediatek.inc (172.27.4.172) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 27 Oct 2021 17:18:32 +0800 Received: from mhfsdcap04 (10.17.3.154) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 27 Oct 2021 17:18:32 +0800 Message-ID: Subject: Re: [PATCH v2 20/22] usb: host: xhci-mtk: deny IRQ0 From: Chunfeng Yun To: Sergey Shtylyov , , "Mathias Nyman" , Greg Kroah-Hartman CC: Matthias Brugger , , Date: Wed, 27 Oct 2021 17:18:31 +0800 In-Reply-To: <20211026173943.6829-21-s.shtylyov@omp.ru> References: <20211026173943.6829-1-s.shtylyov@omp.ru> <20211026173943.6829-21-s.shtylyov@omp.ru> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211027_022848_444578_CD0C8595 X-CRM114-Status: GOOD ( 17.25 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 2021-10-26 at 20:39 +0300, Sergey Shtylyov wrote: > If platform_get_irq() returns IRQ0 (considered invalid according to > Linus) > the driver blithely passes it to usb_add_hcd() that treats IRQ0 as no > IRQ > at all. Deny IRQ0 right away, returning -EINVAL from the probe() > method... > > Fixes: 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host > controller") > Signed-off-by: Sergey Shtylyov > --- > drivers/usb/host/xhci-mtk.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci- > mtk.c > index c53f6f276d5c..d2dc8d9863ee 100644 > --- a/drivers/usb/host/xhci-mtk.c > +++ b/drivers/usb/host/xhci-mtk.c > @@ -495,7 +495,7 @@ static int xhci_mtk_probe(struct platform_device > *pdev) > return ret; > > irq = platform_get_irq_byname_optional(pdev, "host"); > - if (irq < 0) { > + if (irq <= 0) { > if (irq == -EPROBE_DEFER) > return irq; > > @@ -503,6 +503,8 @@ static int xhci_mtk_probe(struct platform_device > *pdev) > irq = platform_get_irq(pdev, 0); > if (irq < 0) > return irq; > + if (!irq) it's "if (irq <= 0)"? > + return -EINVAL; > } > > wakeup_irq = platform_get_irq_byname_optional(pdev, "wakeup"); _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99A9CC433EF for ; Wed, 27 Oct 2021 09:30:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B25360F90 for ; Wed, 27 Oct 2021 09:30:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6B25360F90 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uc5aTVWpn+8zMg6Q2Ja2nCPQuOf8pewV/i4/FG7wipk=; b=mNqPflT5CKMi2D 7nNDcdpUYP963yFj9xWT/1F7z+ZCMAN1FAf974tNzC5wpAgOAQ3Ny8FnamUN3aaKbkscihhFfSW8A 7acB58BoP6TB/KvQBpF6XnmuNq2jtHFaZ1AY5GEu6hKWTZKN31oflzo0eceAj8idcOes7OE3gr29d Njnzd5tv+evGwPxsRakgql71bT22jfc3gyol/efZWrx5kBft9ZTZiqrInvdO1PJ5LpSdVzMv7/Cmx mTPmAuOzoIcZfX0tJOR7tjNoN21kzHGcLTNbMZ8Ru4rcwPFhO0nd8MH5MgpQmSQfw6n0GZUnQOiCA BWs9VpzABCbk+IjU7qFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mffEp-004QGF-Nu; Wed, 27 Oct 2021 09:28:51 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mffEk-004QFd-V2; Wed, 27 Oct 2021 09:28:49 +0000 X-UUID: 13b542b51f81483cb70f8d239801b481-20211027 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=DnF617kfzUFWB+wTivNGwRZqdqT0fNx18iqxKeiaIoI=; b=hohhy9kXY+QlZnce9I8XyAyvddEsPo9QCRuS5fHZP1g3IFpOWbYgi8oK0j9LzTQodzJwz8dRDXEOBcfoVRWiv2aILx5nz3NUkhGWeqLe2vycs0USFjvpbCfPt1r7CBPSYofjAa6XJDYCXT6c7uN4RS4NYQCKS3k5TIKDfbghUvE=; X-UUID: 13b542b51f81483cb70f8d239801b481-20211027 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 391954331; Wed, 27 Oct 2021 02:28:42 -0700 Received: from MTKMBS34N1.mediatek.inc (172.27.4.172) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 27 Oct 2021 02:18:40 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS34N1.mediatek.inc (172.27.4.172) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 27 Oct 2021 17:18:32 +0800 Received: from mhfsdcap04 (10.17.3.154) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 27 Oct 2021 17:18:32 +0800 Message-ID: Subject: Re: [PATCH v2 20/22] usb: host: xhci-mtk: deny IRQ0 From: Chunfeng Yun To: Sergey Shtylyov , , "Mathias Nyman" , Greg Kroah-Hartman CC: Matthias Brugger , , Date: Wed, 27 Oct 2021 17:18:31 +0800 In-Reply-To: <20211026173943.6829-21-s.shtylyov@omp.ru> References: <20211026173943.6829-1-s.shtylyov@omp.ru> <20211026173943.6829-21-s.shtylyov@omp.ru> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211027_022848_444578_CD0C8595 X-CRM114-Status: GOOD ( 17.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2021-10-26 at 20:39 +0300, Sergey Shtylyov wrote: > If platform_get_irq() returns IRQ0 (considered invalid according to > Linus) > the driver blithely passes it to usb_add_hcd() that treats IRQ0 as no > IRQ > at all. Deny IRQ0 right away, returning -EINVAL from the probe() > method... > > Fixes: 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host > controller") > Signed-off-by: Sergey Shtylyov > --- > drivers/usb/host/xhci-mtk.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci- > mtk.c > index c53f6f276d5c..d2dc8d9863ee 100644 > --- a/drivers/usb/host/xhci-mtk.c > +++ b/drivers/usb/host/xhci-mtk.c > @@ -495,7 +495,7 @@ static int xhci_mtk_probe(struct platform_device > *pdev) > return ret; > > irq = platform_get_irq_byname_optional(pdev, "host"); > - if (irq < 0) { > + if (irq <= 0) { > if (irq == -EPROBE_DEFER) > return irq; > > @@ -503,6 +503,8 @@ static int xhci_mtk_probe(struct platform_device > *pdev) > irq = platform_get_irq(pdev, 0); > if (irq < 0) > return irq; > + if (!irq) it's "if (irq <= 0)"? > + return -EINVAL; > } > > wakeup_irq = platform_get_irq_byname_optional(pdev, "wakeup"); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel