From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7E06C433B4 for ; Mon, 10 May 2021 08:33:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88B6F61430 for ; Mon, 10 May 2021 08:33:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230312AbhEJIeE (ORCPT ); Mon, 10 May 2021 04:34:04 -0400 Received: from mga05.intel.com ([192.55.52.43]:42326 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230215AbhEJIeD (ORCPT ); Mon, 10 May 2021 04:34:03 -0400 IronPort-SDR: 7ijODCU5M6GnOcM9l/OGgmtYoS0LHGYz39FUWEUS/j9ifonRg6mxl+rFPItaIfKfTu0PFDkm7D tA+CRdRsdMXg== X-IronPort-AV: E=McAfee;i="6200,9189,9979"; a="284626354" X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="284626354" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 01:32:59 -0700 IronPort-SDR: EI6UBs0GHV3icPsMda52IPH37BYgVnWhaaGj5zqVCose/og3/4GEBs4LFn3kLp+v2Feg7yeNcq l7DNyidfXprg== X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="470722622" Received: from lingshan-mobl5.ccr.corp.intel.com (HELO [10.254.212.136]) ([10.254.212.136]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 01:32:56 -0700 Subject: Re: [PATCH] Revert "irqbypass: do not start cons/prod when failed connect" From: "Zhu, Lingshan" To: Jason Wang , mst@redhat.com, maz@kernel.org, alex.williamson@redhat.com Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, cohuck@redhat.com, stable@vger.kernel.org References: <20210508071152.722425-1-lingshan.zhu@intel.com> Message-ID: Date: Mon, 10 May 2021 16:32:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On 5/10/2021 3:09 PM, Zhu, Lingshan wrote: > > > On 5/10/2021 12:34 PM, Jason Wang wrote: >> >> 在 2021/5/10 上午11:00, Zhu, Lingshan 写道: >>> >>> >>> On 5/10/2021 10:43 AM, Jason Wang wrote: >>>> >>>> 在 2021/5/8 下午3:11, Zhu Lingshan 写道: >>>>> This reverts commit a979a6aa009f3c99689432e0cdb5402a4463fb88. >>>>> >>>>> The reverted commit may cause VM freeze on arm64 platform. >>>>> Because on arm64 platform, stop a consumer will suspend the VM, >>>>> the VM will freeze without a start consumer >>>>> >>>>> Signed-off-by: Zhu Lingshan >>>> >>>> >>>> Acked-by: Jason Wang >>>> >>>> Please resubmit with the formal process of stable >>>> (stable-kernel-rules.rst). >>> sure, I will re-submit it to stable kernel once it is merged into >>> Linus tree. >>> >>> Thanks >> >> >> I think it's better to resubmit (option 1), see how >> stable-kernel-rules.rst said: >> >> "" >> >> :ref:`option_1` is **strongly** preferred, is the easiest and most >> common. >> :ref:`option_2` and :ref:`option_3` are more useful if the patch >> isn't deemed >> worthy at the time it is applied to a public git tree (for instance, >> because >> it deserves more regression testing first). >> >> """ >> >> Thanks > OK, works for me, I will add cc stable, and resubmit it soon > > Thanks! I just seeMarc has already added "Cc: stable@vger.kernel.org", and he would take the patch in his tree, so I think no need to resend. Thanks, Zhu Lingshan >> >> >>>> >>>> Thanks >>>> >>>> >>>>> --- >>>>>   virt/lib/irqbypass.c | 16 ++++++---------- >>>>>   1 file changed, 6 insertions(+), 10 deletions(-) >>>>> >>>>> diff --git a/virt/lib/irqbypass.c b/virt/lib/irqbypass.c >>>>> index c9bb3957f58a..28fda42e471b 100644 >>>>> --- a/virt/lib/irqbypass.c >>>>> +++ b/virt/lib/irqbypass.c >>>>> @@ -40,21 +40,17 @@ static int __connect(struct >>>>> irq_bypass_producer *prod, >>>>>       if (prod->add_consumer) >>>>>           ret = prod->add_consumer(prod, cons); >>>>>   -    if (ret) >>>>> -        goto err_add_consumer; >>>>> - >>>>> -    ret = cons->add_producer(cons, prod); >>>>> -    if (ret) >>>>> -        goto err_add_producer; >>>>> +    if (!ret) { >>>>> +        ret = cons->add_producer(cons, prod); >>>>> +        if (ret && prod->del_consumer) >>>>> +            prod->del_consumer(prod, cons); >>>>> +    } >>>>>         if (cons->start) >>>>>           cons->start(cons); >>>>>       if (prod->start) >>>>>           prod->start(prod); >>>>> -err_add_producer: >>>>> -    if (prod->del_consumer) >>>>> -        prod->del_consumer(prod, cons); >>>>> -err_add_consumer: >>>>> + >>>>>       return ret; >>>>>   } >>>> >>> >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77F97C43460 for ; Mon, 10 May 2021 08:35:00 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id C5A1261456 for ; Mon, 10 May 2021 08:34:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5A1261456 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 338DE4B6F3; Mon, 10 May 2021 04:34:59 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KhlePbGfrAGD; Mon, 10 May 2021 04:34:57 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id EDB5F4B57F; Mon, 10 May 2021 04:34:57 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 8B3F44B456 for ; Mon, 10 May 2021 04:33:03 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PuGdErYeo54n for ; Mon, 10 May 2021 04:33:00 -0400 (EDT) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id B5B1D4B2CA for ; Mon, 10 May 2021 04:33:00 -0400 (EDT) IronPort-SDR: fwJxLN6NE9Dswo7t/AGsOe50ffWlM8qqPfQzcOYUlnef+eYQbHYfiTYD+H1VbpI0SxxQ3BLV0a m5g1EIN7Dm/Q== X-IronPort-AV: E=McAfee;i="6200,9189,9979"; a="260409532" X-IronPort-AV: E=Sophos;i="5.82,286,1613462400"; d="scan'208";a="260409532" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 01:32:59 -0700 IronPort-SDR: EI6UBs0GHV3icPsMda52IPH37BYgVnWhaaGj5zqVCose/og3/4GEBs4LFn3kLp+v2Feg7yeNcq l7DNyidfXprg== X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="470722622" Received: from lingshan-mobl5.ccr.corp.intel.com (HELO [10.254.212.136]) ([10.254.212.136]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 01:32:56 -0700 Subject: Re: [PATCH] Revert "irqbypass: do not start cons/prod when failed connect" From: "Zhu, Lingshan" To: Jason Wang , mst@redhat.com, maz@kernel.org, alex.williamson@redhat.com References: <20210508071152.722425-1-lingshan.zhu@intel.com> Message-ID: Date: Mon, 10 May 2021 16:32:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mailman-Approved-At: Mon, 10 May 2021 04:34:57 -0400 Cc: stable@vger.kernel.org, cohuck@redhat.com, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu CgpPbiA1LzEwLzIwMjEgMzowOSBQTSwgWmh1LCBMaW5nc2hhbiB3cm90ZToKPgo+Cj4gT24gNS8x MC8yMDIxIDEyOjM0IFBNLCBKYXNvbiBXYW5nIHdyb3RlOgo+Pgo+PiDlnKggMjAyMS81LzEwIOS4 iuWNiDExOjAwLCBaaHUsIExpbmdzaGFuIOWGmemBkzoKPj4+Cj4+Pgo+Pj4gT24gNS8xMC8yMDIx IDEwOjQzIEFNLCBKYXNvbiBXYW5nIHdyb3RlOgo+Pj4+Cj4+Pj4g5ZyoIDIwMjEvNS84IOS4i+WN iDM6MTEsIFpodSBMaW5nc2hhbiDlhpnpgZM6Cj4+Pj4+IFRoaXMgcmV2ZXJ0cyBjb21taXQgYTk3 OWE2YWEwMDlmM2M5OTY4OTQzMmUwY2RiNTQwMmE0NDYzZmI4OC4KPj4+Pj4KPj4+Pj4gVGhlIHJl dmVydGVkIGNvbW1pdCBtYXkgY2F1c2UgVk0gZnJlZXplIG9uIGFybTY0IHBsYXRmb3JtLgo+Pj4+ PiBCZWNhdXNlIG9uIGFybTY0IHBsYXRmb3JtLCBzdG9wIGEgY29uc3VtZXIgd2lsbCBzdXNwZW5k IHRoZSBWTSwKPj4+Pj4gdGhlIFZNIHdpbGwgZnJlZXplIHdpdGhvdXQgYSBzdGFydCBjb25zdW1l cgo+Pj4+Pgo+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBaaHUgTGluZ3NoYW4gPGxpbmdzaGFuLnpodUBp bnRlbC5jb20+Cj4+Pj4KPj4+Pgo+Pj4+IEFja2VkLWJ5OiBKYXNvbiBXYW5nIDxqYXNvd2FuZ0By ZWRoYXQuY29tPgo+Pj4+Cj4+Pj4gUGxlYXNlIHJlc3VibWl0IHdpdGggdGhlIGZvcm1hbCBwcm9j ZXNzIG9mIHN0YWJsZSAKPj4+PiAoc3RhYmxlLWtlcm5lbC1ydWxlcy5yc3QpLgo+Pj4gc3VyZSwg SSB3aWxsIHJlLXN1Ym1pdCBpdCB0byBzdGFibGUga2VybmVsIG9uY2UgaXQgaXMgbWVyZ2VkIGlu dG8gCj4+PiBMaW51cyB0cmVlLgo+Pj4KPj4+IFRoYW5rcwo+Pgo+Pgo+PiBJIHRoaW5rIGl0J3Mg YmV0dGVyIHRvIHJlc3VibWl0IChvcHRpb24gMSksIHNlZSBob3cgCj4+IHN0YWJsZS1rZXJuZWwt cnVsZXMucnN0IHNhaWQ6Cj4+Cj4+ICIiCj4+Cj4+IDpyZWY6YG9wdGlvbl8xYCBpcyAqKnN0cm9u Z2x5KiogcHJlZmVycmVkLCBpcyB0aGUgZWFzaWVzdCBhbmQgbW9zdCAKPj4gY29tbW9uLgo+PiA6 cmVmOmBvcHRpb25fMmAgYW5kIDpyZWY6YG9wdGlvbl8zYCBhcmUgbW9yZSB1c2VmdWwgaWYgdGhl IHBhdGNoIAo+PiBpc24ndCBkZWVtZWQKPj4gd29ydGh5IGF0IHRoZSB0aW1lIGl0IGlzIGFwcGxp ZWQgdG8gYSBwdWJsaWMgZ2l0IHRyZWUgKGZvciBpbnN0YW5jZSwgCj4+IGJlY2F1c2UKPj4gaXQg ZGVzZXJ2ZXMgbW9yZSByZWdyZXNzaW9uIHRlc3RpbmcgZmlyc3QpLgo+Pgo+PiAiIiIKPj4KPj4g VGhhbmtzCj4gT0ssIHdvcmtzIGZvciBtZSwgSSB3aWxsIGFkZCBjYyBzdGFibGUsIGFuZCByZXN1 Ym1pdCBpdCBzb29uCj4KPiBUaGFua3MhCkkganVzdCBzZWVNYXJjIGhhcyBhbHJlYWR5IGFkZGVk ICJDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZyIsIGFuZCBoZSAKd291bGQgdGFrZSB0aGUgcGF0 Y2ggaW4gaGlzIHRyZWUsCnNvIEkgdGhpbmsgbm8gbmVlZCB0byByZXNlbmQuCgpUaGFua3MsClpo dSBMaW5nc2hhbgo+Pgo+Pgo+Pj4+Cj4+Pj4gVGhhbmtzCj4+Pj4KPj4+Pgo+Pj4+PiAtLS0KPj4+ Pj4gwqAgdmlydC9saWIvaXJxYnlwYXNzLmMgfCAxNiArKysrKystLS0tLS0tLS0tCj4+Pj4+IMKg IDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQo+Pj4+Pgo+ Pj4+PiBkaWZmIC0tZ2l0IGEvdmlydC9saWIvaXJxYnlwYXNzLmMgYi92aXJ0L2xpYi9pcnFieXBh c3MuYwo+Pj4+PiBpbmRleCBjOWJiMzk1N2Y1OGEuLjI4ZmRhNDJlNDcxYiAxMDA2NDQKPj4+Pj4g LS0tIGEvdmlydC9saWIvaXJxYnlwYXNzLmMKPj4+Pj4gKysrIGIvdmlydC9saWIvaXJxYnlwYXNz LmMKPj4+Pj4gQEAgLTQwLDIxICs0MCwxNyBAQCBzdGF0aWMgaW50IF9fY29ubmVjdChzdHJ1Y3Qg Cj4+Pj4+IGlycV9ieXBhc3NfcHJvZHVjZXIgKnByb2QsCj4+Pj4+IMKgwqDCoMKgwqAgaWYgKHBy b2QtPmFkZF9jb25zdW1lcikKPj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIHJldCA9IHByb2QtPmFk ZF9jb25zdW1lcihwcm9kLCBjb25zKTsKPj4+Pj4gwqAgLcKgwqDCoCBpZiAocmV0KQo+Pj4+PiAt wqDCoMKgwqDCoMKgwqAgZ290byBlcnJfYWRkX2NvbnN1bWVyOwo+Pj4+PiAtCj4+Pj4+IC3CoMKg wqAgcmV0ID0gY29ucy0+YWRkX3Byb2R1Y2VyKGNvbnMsIHByb2QpOwo+Pj4+PiAtwqDCoMKgIGlm IChyZXQpCj4+Pj4+IC3CoMKgwqDCoMKgwqDCoCBnb3RvIGVycl9hZGRfcHJvZHVjZXI7Cj4+Pj4+ ICvCoMKgwqAgaWYgKCFyZXQpIHsKPj4+Pj4gK8KgwqDCoMKgwqDCoMKgIHJldCA9IGNvbnMtPmFk ZF9wcm9kdWNlcihjb25zLCBwcm9kKTsKPj4+Pj4gK8KgwqDCoMKgwqDCoMKgIGlmIChyZXQgJiYg cHJvZC0+ZGVsX2NvbnN1bWVyKQo+Pj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBwcm9kLT5k ZWxfY29uc3VtZXIocHJvZCwgY29ucyk7Cj4+Pj4+ICvCoMKgwqAgfQo+Pj4+PiDCoCDCoMKgwqDC oMKgIGlmIChjb25zLT5zdGFydCkKPj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIGNvbnMtPnN0YXJ0 KGNvbnMpOwo+Pj4+PiDCoMKgwqDCoMKgIGlmIChwcm9kLT5zdGFydCkKPj4+Pj4gwqDCoMKgwqDC oMKgwqDCoMKgIHByb2QtPnN0YXJ0KHByb2QpOwo+Pj4+PiAtZXJyX2FkZF9wcm9kdWNlcjoKPj4+ Pj4gLcKgwqDCoCBpZiAocHJvZC0+ZGVsX2NvbnN1bWVyKQo+Pj4+PiAtwqDCoMKgwqDCoMKgwqAg cHJvZC0+ZGVsX2NvbnN1bWVyKHByb2QsIGNvbnMpOwo+Pj4+PiAtZXJyX2FkZF9jb25zdW1lcjoK Pj4+Pj4gKwo+Pj4+PiDCoMKgwqDCoMKgIHJldHVybiByZXQ7Cj4+Pj4+IMKgIH0KPj4+Pgo+Pj4K Pj4KPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka3Zt YXJtIG1haWxpbmcgbGlzdAprdm1hcm1AbGlzdHMuY3MuY29sdW1iaWEuZWR1Cmh0dHBzOi8vbGlz dHMuY3MuY29sdW1iaWEuZWR1L21haWxtYW4vbGlzdGluZm8va3ZtYXJtCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F1A5C433B4 for ; Mon, 10 May 2021 08:34:58 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B91B561430 for ; Mon, 10 May 2021 08:34:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B91B561430 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: Cc:To:From:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1inFjuQizcB7D7JwE3xSGsAkKGfUVhJ0J5H3aEED77k=; b=Kor+7PbX/96XBypHgOqmESI6N hhmD55FYB4C8nDwUKYQmKcFiEGgnz0wPKtDrXew/YgvgqN5ufRVfNtbfbqDjUeCqM+5nD6T1mjD7h gwMG7fBkF8XtWmRSHtj4m+P8um4/Dhed+tIXXAMV852VZILybPVc1lXbNz5n8FMsAo1xAr+oTN0VR NgtaiBhH+B2zJORs6WtsPIiREG2jcoriqi1P7IWK7wGtGKRf93CAvygWlfYw1Trr8TjWg2NqreCdI Sirn3nWX0VbzZWXH1MbwY2QfAwEcBPyWc0RYoYyscE/Bqq7xpn8TKaM+CMRxIY4XvzdrTyRM1Scx4 tWggek60Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lg1Lf-00DdXf-4O; Mon, 10 May 2021 08:33:07 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lg1Lb-00DdX9-OA for linux-arm-kernel@desiato.infradead.org; Mon, 10 May 2021 08:33:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:References:Cc:To:From: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=cNnyfv2ivAJGD5Zn+9yGjkoOLvpBwfxbGgRVR76z34I=; b=ObXnuPSJkLyAULMjcMQe0krt5U 9wBeeDdrmNJB5ic8+B7LKr6c8imydZy1oKUWCJFBzKd6LcoWRCBif+afTmrfj+/YDAPgwUWShAbtz obL1S/JMQmXxkSuQq6NCkQaoPaG1RUJIS/AnkdLrU14KbOTe87LqX1Tv2cBA+YASHiTqUnl0RKqnm g/kR22ydgD9872QK0gRzm0nyQlvUl1OX5IJJPrtUrckSTBjtA+KEB6vPSRgLBXyogQrVJCpCpuWNn t6au/tS2X7QIbDc54y+QyaGAJh4Qg/12oWZkid0R6Of4pmyX3/ddKlYpAJjnJ5tcIqd+yv7gu+pzD N/NcBYXQ==; Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lg1LY-008Pyk-VU for linux-arm-kernel@lists.infradead.org; Mon, 10 May 2021 08:33:02 +0000 IronPort-SDR: +npRGX+hPNf0He/GFlptau6HtUAO627RYD7PXOwN467KaaAizGTYcBeVPMg+4Q0RfuMqmAgEYg eOqhDDLAF6uQ== X-IronPort-AV: E=McAfee;i="6200,9189,9979"; a="178731375" X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="178731375" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 01:32:59 -0700 IronPort-SDR: EI6UBs0GHV3icPsMda52IPH37BYgVnWhaaGj5zqVCose/og3/4GEBs4LFn3kLp+v2Feg7yeNcq l7DNyidfXprg== X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="470722622" Received: from lingshan-mobl5.ccr.corp.intel.com (HELO [10.254.212.136]) ([10.254.212.136]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 01:32:56 -0700 Subject: Re: [PATCH] Revert "irqbypass: do not start cons/prod when failed connect" From: "Zhu, Lingshan" To: Jason Wang , mst@redhat.com, maz@kernel.org, alex.williamson@redhat.com Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, cohuck@redhat.com, stable@vger.kernel.org References: <20210508071152.722425-1-lingshan.zhu@intel.com> Message-ID: Date: Mon, 10 May 2021 16:32:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210510_013301_045819_740987EA X-CRM114-Status: GOOD ( 17.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiA1LzEwLzIwMjEgMzowOSBQTSwgWmh1LCBMaW5nc2hhbiB3cm90ZToKPgo+Cj4gT24gNS8x MC8yMDIxIDEyOjM0IFBNLCBKYXNvbiBXYW5nIHdyb3RlOgo+Pgo+PiDlnKggMjAyMS81LzEwIOS4 iuWNiDExOjAwLCBaaHUsIExpbmdzaGFuIOWGmemBkzoKPj4+Cj4+Pgo+Pj4gT24gNS8xMC8yMDIx IDEwOjQzIEFNLCBKYXNvbiBXYW5nIHdyb3RlOgo+Pj4+Cj4+Pj4g5ZyoIDIwMjEvNS84IOS4i+WN iDM6MTEsIFpodSBMaW5nc2hhbiDlhpnpgZM6Cj4+Pj4+IFRoaXMgcmV2ZXJ0cyBjb21taXQgYTk3 OWE2YWEwMDlmM2M5OTY4OTQzMmUwY2RiNTQwMmE0NDYzZmI4OC4KPj4+Pj4KPj4+Pj4gVGhlIHJl dmVydGVkIGNvbW1pdCBtYXkgY2F1c2UgVk0gZnJlZXplIG9uIGFybTY0IHBsYXRmb3JtLgo+Pj4+ PiBCZWNhdXNlIG9uIGFybTY0IHBsYXRmb3JtLCBzdG9wIGEgY29uc3VtZXIgd2lsbCBzdXNwZW5k IHRoZSBWTSwKPj4+Pj4gdGhlIFZNIHdpbGwgZnJlZXplIHdpdGhvdXQgYSBzdGFydCBjb25zdW1l cgo+Pj4+Pgo+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBaaHUgTGluZ3NoYW4gPGxpbmdzaGFuLnpodUBp bnRlbC5jb20+Cj4+Pj4KPj4+Pgo+Pj4+IEFja2VkLWJ5OiBKYXNvbiBXYW5nIDxqYXNvd2FuZ0By ZWRoYXQuY29tPgo+Pj4+Cj4+Pj4gUGxlYXNlIHJlc3VibWl0IHdpdGggdGhlIGZvcm1hbCBwcm9j ZXNzIG9mIHN0YWJsZSAKPj4+PiAoc3RhYmxlLWtlcm5lbC1ydWxlcy5yc3QpLgo+Pj4gc3VyZSwg SSB3aWxsIHJlLXN1Ym1pdCBpdCB0byBzdGFibGUga2VybmVsIG9uY2UgaXQgaXMgbWVyZ2VkIGlu dG8gCj4+PiBMaW51cyB0cmVlLgo+Pj4KPj4+IFRoYW5rcwo+Pgo+Pgo+PiBJIHRoaW5rIGl0J3Mg YmV0dGVyIHRvIHJlc3VibWl0IChvcHRpb24gMSksIHNlZSBob3cgCj4+IHN0YWJsZS1rZXJuZWwt cnVsZXMucnN0IHNhaWQ6Cj4+Cj4+ICIiCj4+Cj4+IDpyZWY6YG9wdGlvbl8xYCBpcyAqKnN0cm9u Z2x5KiogcHJlZmVycmVkLCBpcyB0aGUgZWFzaWVzdCBhbmQgbW9zdCAKPj4gY29tbW9uLgo+PiA6 cmVmOmBvcHRpb25fMmAgYW5kIDpyZWY6YG9wdGlvbl8zYCBhcmUgbW9yZSB1c2VmdWwgaWYgdGhl IHBhdGNoIAo+PiBpc24ndCBkZWVtZWQKPj4gd29ydGh5IGF0IHRoZSB0aW1lIGl0IGlzIGFwcGxp ZWQgdG8gYSBwdWJsaWMgZ2l0IHRyZWUgKGZvciBpbnN0YW5jZSwgCj4+IGJlY2F1c2UKPj4gaXQg ZGVzZXJ2ZXMgbW9yZSByZWdyZXNzaW9uIHRlc3RpbmcgZmlyc3QpLgo+Pgo+PiAiIiIKPj4KPj4g VGhhbmtzCj4gT0ssIHdvcmtzIGZvciBtZSwgSSB3aWxsIGFkZCBjYyBzdGFibGUsIGFuZCByZXN1 Ym1pdCBpdCBzb29uCj4KPiBUaGFua3MhCkkganVzdCBzZWVNYXJjIGhhcyBhbHJlYWR5IGFkZGVk ICJDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZyIsIGFuZCBoZSAKd291bGQgdGFrZSB0aGUgcGF0 Y2ggaW4gaGlzIHRyZWUsCnNvIEkgdGhpbmsgbm8gbmVlZCB0byByZXNlbmQuCgpUaGFua3MsClpo dSBMaW5nc2hhbgo+Pgo+Pgo+Pj4+Cj4+Pj4gVGhhbmtzCj4+Pj4KPj4+Pgo+Pj4+PiAtLS0KPj4+ Pj4gwqAgdmlydC9saWIvaXJxYnlwYXNzLmMgfCAxNiArKysrKystLS0tLS0tLS0tCj4+Pj4+IMKg IDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQo+Pj4+Pgo+ Pj4+PiBkaWZmIC0tZ2l0IGEvdmlydC9saWIvaXJxYnlwYXNzLmMgYi92aXJ0L2xpYi9pcnFieXBh c3MuYwo+Pj4+PiBpbmRleCBjOWJiMzk1N2Y1OGEuLjI4ZmRhNDJlNDcxYiAxMDA2NDQKPj4+Pj4g LS0tIGEvdmlydC9saWIvaXJxYnlwYXNzLmMKPj4+Pj4gKysrIGIvdmlydC9saWIvaXJxYnlwYXNz LmMKPj4+Pj4gQEAgLTQwLDIxICs0MCwxNyBAQCBzdGF0aWMgaW50IF9fY29ubmVjdChzdHJ1Y3Qg Cj4+Pj4+IGlycV9ieXBhc3NfcHJvZHVjZXIgKnByb2QsCj4+Pj4+IMKgwqDCoMKgwqAgaWYgKHBy b2QtPmFkZF9jb25zdW1lcikKPj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIHJldCA9IHByb2QtPmFk ZF9jb25zdW1lcihwcm9kLCBjb25zKTsKPj4+Pj4gwqAgLcKgwqDCoCBpZiAocmV0KQo+Pj4+PiAt wqDCoMKgwqDCoMKgwqAgZ290byBlcnJfYWRkX2NvbnN1bWVyOwo+Pj4+PiAtCj4+Pj4+IC3CoMKg wqAgcmV0ID0gY29ucy0+YWRkX3Byb2R1Y2VyKGNvbnMsIHByb2QpOwo+Pj4+PiAtwqDCoMKgIGlm IChyZXQpCj4+Pj4+IC3CoMKgwqDCoMKgwqDCoCBnb3RvIGVycl9hZGRfcHJvZHVjZXI7Cj4+Pj4+ ICvCoMKgwqAgaWYgKCFyZXQpIHsKPj4+Pj4gK8KgwqDCoMKgwqDCoMKgIHJldCA9IGNvbnMtPmFk ZF9wcm9kdWNlcihjb25zLCBwcm9kKTsKPj4+Pj4gK8KgwqDCoMKgwqDCoMKgIGlmIChyZXQgJiYg cHJvZC0+ZGVsX2NvbnN1bWVyKQo+Pj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBwcm9kLT5k ZWxfY29uc3VtZXIocHJvZCwgY29ucyk7Cj4+Pj4+ICvCoMKgwqAgfQo+Pj4+PiDCoCDCoMKgwqDC oMKgIGlmIChjb25zLT5zdGFydCkKPj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIGNvbnMtPnN0YXJ0 KGNvbnMpOwo+Pj4+PiDCoMKgwqDCoMKgIGlmIChwcm9kLT5zdGFydCkKPj4+Pj4gwqDCoMKgwqDC oMKgwqDCoMKgIHByb2QtPnN0YXJ0KHByb2QpOwo+Pj4+PiAtZXJyX2FkZF9wcm9kdWNlcjoKPj4+ Pj4gLcKgwqDCoCBpZiAocHJvZC0+ZGVsX2NvbnN1bWVyKQo+Pj4+PiAtwqDCoMKgwqDCoMKgwqAg cHJvZC0+ZGVsX2NvbnN1bWVyKHByb2QsIGNvbnMpOwo+Pj4+PiAtZXJyX2FkZF9jb25zdW1lcjoK Pj4+Pj4gKwo+Pj4+PiDCoMKgwqDCoMKgIHJldHVybiByZXQ7Cj4+Pj4+IMKgIH0KPj4+Pgo+Pj4K Pj4KPgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK