From: Julien Grall <julien@xen.org>
To: Jan Beulich <jbeulich@suse.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Ian Jackson <ian.jackson@citrix.com>
Subject: Re: [PATCH 5/8] bitmap: move to/from xenctl_bitmap conversion helpers
Date: Mon, 20 Jul 2020 17:20:39 +0100 [thread overview]
Message-ID: <fef25c94-a3ce-c17e-966c-a7e479566fc5@xen.org> (raw)
In-Reply-To: <5835147f-8428-1d74-7d6e-bbb5522289c7@suse.com>
Hi Jan,
On 15/07/2020 11:40, Jan Beulich wrote:
> A subsequent change will exclude domctl.c from getting built for a
> particular configuration, yet the two functions get used from elsewhere.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/common/bitmap.c
> +++ b/xen/common/bitmap.c
> @@ -9,6 +9,9 @@
> #include <xen/errno.h>
> #include <xen/bitmap.h>
> #include <xen/bitops.h>
> +#include <xen/cpumask.h>
> +#include <xen/domain.h>
The inclusion of xen/domain.h in common/bitmap.c seems a bit odd to me.
Would it make sense to move the prototype of
bitmap_to_xenctl_bitmap()/xenctl_bitmap_to_bitmap() to bitmap.h?
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2020-07-20 16:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 10:29 [PATCH 0/8] x86: build adjustments Jan Beulich
2020-07-15 10:37 ` [PATCH 1/8] x86/EFI: sanitize build logic Jan Beulich
2020-07-15 10:37 ` [PATCH 2/8] x86: don't build with EFI support in shim-exclusive mode Jan Beulich
2020-07-15 10:38 ` [PATCH 3/8] x86: shrink struct arch_{vcpu,domain} when !HVM Jan Beulich
2020-07-15 10:39 ` [PATCH 4/8] Arm: prune #include-s needed by domain.h Jan Beulich
2020-07-15 16:54 ` Stefano Stabellini
2020-07-17 14:44 ` Julien Grall
2020-07-20 8:17 ` Jan Beulich
2020-07-20 9:09 ` Julien Grall
2020-07-20 11:28 ` Jan Beulich
2020-07-20 15:15 ` Julien Grall
2020-07-20 16:17 ` Julien Grall
2020-07-15 10:40 ` [PATCH 5/8] bitmap: move to/from xenctl_bitmap conversion helpers Jan Beulich
2020-07-20 16:20 ` Julien Grall [this message]
2020-07-21 7:31 ` Jan Beulich
2020-07-15 10:40 ` [PATCH 6/8] x86: move domain_cpu_policy_changed() Jan Beulich
2020-07-15 10:41 ` [PATCH 7/8] x86: move cpu_{up,down}_helper() Jan Beulich
2020-07-15 10:41 ` [PATCH 8/8] x86: don't include domctl and alike in shim-exclusive builds Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fef25c94-a3ce-c17e-966c-a7e479566fc5@xen.org \
--to=julien@xen.org \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=jbeulich@suse.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.