From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15D4EC32771 for ; Sun, 19 Jan 2020 03:01:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA374246A9 for ; Sun, 19 Jan 2020 03:01:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727766AbgASDB1 (ORCPT ); Sat, 18 Jan 2020 22:01:27 -0500 Received: from mail-sh.amlogic.com ([58.32.228.43]:26986 "EHLO mail-sh.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727403AbgASDB1 (ORCPT ); Sat, 18 Jan 2020 22:01:27 -0500 Received: from [10.18.38.198] (10.18.38.198) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Sun, 19 Jan 2020 11:01:54 +0800 Subject: Re: [PATCH v6 5/6] arm64: dts: meson: a1: Enable USB2 PHY To: Martin Blumenstingl CC: Jerome Brunet , Neil Armstrong , Rob Herring , Greg Kroah-Hartman , Felipe Balbi , Kevin Hilman , Yue Wang , , , , , Carlo Caione , Michael Turquette , Stephen Boyd , Liang Yang , Jianxin Pan , Qiufang Dai , Jian Hu , Victor Wan , Xingyu Chen References: <1579220504-110067-1-git-send-email-hanjie.lin@amlogic.com> <1579220504-110067-6-git-send-email-hanjie.lin@amlogic.com> From: Hanjie Lin Message-ID: Date: Sun, 19 Jan 2020 11:01:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.18.38.198] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2020/1/19 6:05, Martin Blumenstingl wrote: > Hi Hanjie, > > On Fri, Jan 17, 2020 at 1:22 AM Hanjie Lin wrote: >> >> Enable USB2 PHY for Meson A1 SoC. >> >> Signed-off-by: Yue Wang >> Signed-off-by: Hanjie Lin >> --- >> arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) > personally I would squash this with patch 6/6 because it's only useful > together with patch 6/6 > on the other hand: it's not worth sending a v7 just for this > >> @@ -100,6 +101,18 @@ >> #power-domain-cells = <1>; >> status = "okay"; >> }; >> + >> + usb2_phy1: phy@40000 { >> + status = "okay"; > we typically use one of the following patterns: > - status = "disabled" in SoC.dts > - status = "okay" in board.dts whenever the peripheral should be used > (example: I2C, USB, ...) > OR > - no status property if the peripheral is mandatory on all boards (for > example: clock controller, ...) > > so for consistency with other Amlogic .dts I would either drop the > status property or set it to disabled (and enable it in > meson-a1-ad401.dts) > same applies to patch 6/6 > > > Martin > > . > Hi Martin, Of course, it will be more reasonable. I have a bindings issue need to fix too, so I will do these together in v7. Thanks, Hanjie From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F17CC32771 for ; Sun, 19 Jan 2020 03:01:39 +0000 (UTC) Received: from bombadil.infradead.org (unknown [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7C4E246AA for ; Sun, 19 Jan 2020 03:01:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZIyV56tg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7C4E246AA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amlogic.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5rGokrSplMnxvn1ALoWMbbwo8pwWL4YwGJjf4V99WcY=; b=ZIyV56tg0DMeyG YvEPBf/AEcf/i5sNpdjH8N+sqFYYmpSr/hVBpj617kJWz/lk3EOq+XSMm34vd7oRkBZldNiH4lV7O 5kYVv9sJzivFBLQK2VousTPuWUE5MB/peAjCY1DzXrlmmrlWFXaH1viCTFJC0vwaTjawA4xtUHqUc cburLtNHSw8rRl6ueN7wvqHzUoIDq/YqxqvCH/DIE10xaKD4O7zSE8dbpAUhHByVxthwkAmZ/FUtZ XdRli4wtZ4yjPE8cm6Aj8r0bN1td8DfcnxvTvD6feCvrhlm7LN6ay8ujt4o57HzJFCMsemH7Wxsnr E4x6gBxrkDtZpq7cr1kg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1it0qA-0005Pn-72; Sun, 19 Jan 2020 03:01:30 +0000 Received: from mail-sh.amlogic.com ([58.32.228.43]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1it0q6-0005OQ-Qr; Sun, 19 Jan 2020 03:01:28 +0000 Received: from [10.18.38.198] (10.18.38.198) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Sun, 19 Jan 2020 11:01:54 +0800 Subject: Re: [PATCH v6 5/6] arm64: dts: meson: a1: Enable USB2 PHY To: Martin Blumenstingl References: <1579220504-110067-1-git-send-email-hanjie.lin@amlogic.com> <1579220504-110067-6-git-send-email-hanjie.lin@amlogic.com> From: Hanjie Lin Message-ID: Date: Sun, 19 Jan 2020 11:01:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.18.38.198] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200118_190126_870782_D76FB035 X-CRM114-Status: GOOD ( 15.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Victor Wan , Jianxin Pan , Felipe Balbi , Neil Armstrong , Stephen Boyd , Kevin Hilman , Michael Turquette , linux-usb@vger.kernel.org, Yue Wang , Qiufang Dai , devicetree@vger.kernel.org, Liang Yang , Jian Hu , Xingyu Chen , Greg Kroah-Hartman , Carlo Caione , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020/1/19 6:05, Martin Blumenstingl wrote: > Hi Hanjie, > > On Fri, Jan 17, 2020 at 1:22 AM Hanjie Lin wrote: >> >> Enable USB2 PHY for Meson A1 SoC. >> >> Signed-off-by: Yue Wang >> Signed-off-by: Hanjie Lin >> --- >> arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) > personally I would squash this with patch 6/6 because it's only useful > together with patch 6/6 > on the other hand: it's not worth sending a v7 just for this > >> @@ -100,6 +101,18 @@ >> #power-domain-cells = <1>; >> status = "okay"; >> }; >> + >> + usb2_phy1: phy@40000 { >> + status = "okay"; > we typically use one of the following patterns: > - status = "disabled" in SoC.dts > - status = "okay" in board.dts whenever the peripheral should be used > (example: I2C, USB, ...) > OR > - no status property if the peripheral is mandatory on all boards (for > example: clock controller, ...) > > so for consistency with other Amlogic .dts I would either drop the > status property or set it to disabled (and enable it in > meson-a1-ad401.dts) > same applies to patch 6/6 > > > Martin > > . > Hi Martin, Of course, it will be more reasonable. I have a bindings issue need to fix too, so I will do these together in v7. Thanks, Hanjie _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B192EC32771 for ; Sun, 19 Jan 2020 03:02:02 +0000 (UTC) Received: from bombadil.infradead.org (unknown [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85385246A9 for ; Sun, 19 Jan 2020 03:02:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VTAjw/WG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85385246A9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amlogic.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WRHuM1D48vqURt1p7MgvsYL5AnqYBvUwh4Nalv+vdl8=; b=VTAjw/WGqm1C5R Lf8d2MxV7gDNP7BIS3cA1iTbq5egTA37QcGMWAawGMmwAscOE2cZx89DpvpEFnM4U44IC+YU+gujv 1y2lhIUV5Q5u9eBYzyiUSpJSgHywSxB6mPpaC2DCVHN+Ck6etgT1VBtqD6uOr13uNyiILsmRhroI0 UNFqI8rlZNOipSDTap9F7JD6BL5+F+9T1PQeg2/Ysy3ut06X88tIoZWVcv6BGQFrYq7tG1Kuyl4Rf Vsn14zuQbdSTVDijd1V8mB7jirwfyC3l2UH65oJxHw1A7KvvCRjTy3Y/md9LE2huinpCdxA/nnVW5 xTP8url1t0ZXebAxtLpA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1it0q8-0005On-Dv; Sun, 19 Jan 2020 03:01:28 +0000 Received: from mail-sh.amlogic.com ([58.32.228.43]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1it0q6-0005OQ-Qr; Sun, 19 Jan 2020 03:01:28 +0000 Received: from [10.18.38.198] (10.18.38.198) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Sun, 19 Jan 2020 11:01:54 +0800 Subject: Re: [PATCH v6 5/6] arm64: dts: meson: a1: Enable USB2 PHY To: Martin Blumenstingl References: <1579220504-110067-1-git-send-email-hanjie.lin@amlogic.com> <1579220504-110067-6-git-send-email-hanjie.lin@amlogic.com> From: Hanjie Lin Message-ID: Date: Sun, 19 Jan 2020 11:01:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.18.38.198] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200118_190126_870782_D76FB035 X-CRM114-Status: GOOD ( 15.36 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Victor Wan , Jianxin Pan , Felipe Balbi , Neil Armstrong , Stephen Boyd , Kevin Hilman , Michael Turquette , linux-usb@vger.kernel.org, Yue Wang , Qiufang Dai , devicetree@vger.kernel.org, Liang Yang , Jian Hu , Xingyu Chen , Greg Kroah-Hartman , Carlo Caione , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 2020/1/19 6:05, Martin Blumenstingl wrote: > Hi Hanjie, > > On Fri, Jan 17, 2020 at 1:22 AM Hanjie Lin wrote: >> >> Enable USB2 PHY for Meson A1 SoC. >> >> Signed-off-by: Yue Wang >> Signed-off-by: Hanjie Lin >> --- >> arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) > personally I would squash this with patch 6/6 because it's only useful > together with patch 6/6 > on the other hand: it's not worth sending a v7 just for this > >> @@ -100,6 +101,18 @@ >> #power-domain-cells = <1>; >> status = "okay"; >> }; >> + >> + usb2_phy1: phy@40000 { >> + status = "okay"; > we typically use one of the following patterns: > - status = "disabled" in SoC.dts > - status = "okay" in board.dts whenever the peripheral should be used > (example: I2C, USB, ...) > OR > - no status property if the peripheral is mandatory on all boards (for > example: clock controller, ...) > > so for consistency with other Amlogic .dts I would either drop the > status property or set it to disabled (and enable it in > meson-a1-ad401.dts) > same applies to patch 6/6 > > > Martin > > . > Hi Martin, Of course, it will be more reasonable. I have a bindings issue need to fix too, so I will do these together in v7. Thanks, Hanjie _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic