From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05F08C433EF for ; Thu, 14 Apr 2022 08:50:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241145AbiDNIxS (ORCPT ); Thu, 14 Apr 2022 04:53:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241148AbiDNIwo (ORCPT ); Thu, 14 Apr 2022 04:52:44 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C5993EA94; Thu, 14 Apr 2022 01:50:19 -0700 (PDT) X-UUID: 66d2ab736fc943f0adeeb52f37531326-20220414 X-UUID: 66d2ab736fc943f0adeeb52f37531326-20220414 Received: from mtkcas11.mediatek.inc [(172.21.101.40)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 690631683; Thu, 14 Apr 2022 16:50:14 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 14 Apr 2022 16:50:13 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 14 Apr 2022 16:50:12 +0800 Message-ID: Subject: Re: [PATCH v5 2/2] phy: mediatek: Add PCIe PHY driver From: Jianjun Wang To: Vinod Koul CC: Chunfeng Yun , Kishon Vijay Abraham I , Rob Herring , Matthias Brugger , Chen-Yu Tsai , AngeloGioacchino Del Regno , Krzysztof Kozlowski , Wei-Shun Chang , , , , , , , , , , , Date: Thu, 14 Apr 2022 16:50:12 +0800 In-Reply-To: References: <20220326022728.2969-1-jianjun.wang@mediatek.com> <20220326022728.2969-3-jianjun.wang@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2022-04-11 at 22:54 +0530, Vinod Koul wrote: > On 26-03-22, 10:27, Jianjun Wang wrote: > > Add PCIe GEN3 PHY driver support on MediaTek chipsets. > > > > Signed-off-by: Jianjun Wang > > Reviewed-by: AngeloGioacchino Del Regno < > > angelogioacchino.delregno@collabora.com> > > --- > > drivers/phy/mediatek/Kconfig | 11 ++ > > drivers/phy/mediatek/Makefile | 1 + > > drivers/phy/mediatek/phy-mtk-pcie.c | 272 > > ++++++++++++++++++++++++++++ > > 3 files changed, 284 insertions(+) > > create mode 100644 drivers/phy/mediatek/phy-mtk-pcie.c > > > > diff --git a/drivers/phy/mediatek/Kconfig > > b/drivers/phy/mediatek/Kconfig > > index 55f8e6c048ab..387ed1b3f2cc 100644 > > --- a/drivers/phy/mediatek/Kconfig > > +++ b/drivers/phy/mediatek/Kconfig > > @@ -55,3 +55,14 @@ config PHY_MTK_MIPI_DSI > > select GENERIC_PHY > > help > > Support MIPI DSI for Mediatek SoCs. > > + > > +config PHY_MTK_PCIE > > + tristate "MediaTek PCIe-PHY Driver" > > + depends on ARCH_MEDIATEK || COMPILE_TEST > > + depends on OF > > + select GENERIC_PHY > > + help > > + Say 'Y' here to add support for MediaTek PCIe PHY driver. > > + This driver create the basic PHY instance and provides > > initialize > > + callback for PCIe GEN3 port, it supports software efuse > > + initialization. > > diff --git a/drivers/phy/mediatek/Makefile > > b/drivers/phy/mediatek/Makefile > > index ace660fbed3a..788c13147f63 100644 > > --- a/drivers/phy/mediatek/Makefile > > +++ b/drivers/phy/mediatek/Makefile > > @@ -6,6 +6,7 @@ > > obj-$(CONFIG_PHY_MTK_TPHY) += phy-mtk-tphy.o > > obj-$(CONFIG_PHY_MTK_UFS) += phy-mtk-ufs.o > > obj-$(CONFIG_PHY_MTK_XSPHY) += phy-mtk-xsphy.o > > +obj-$(CONFIG_PHY_MTK_PCIE) += phy-mtk-pcie.o > > > > phy-mtk-hdmi-drv-y := phy-mtk-hdmi.o > > phy-mtk-hdmi-drv-y += phy-mtk-hdmi-mt2701.o > > diff --git a/drivers/phy/mediatek/phy-mtk-pcie.c > > b/drivers/phy/mediatek/phy-mtk-pcie.c > > new file mode 100644 > > index 000000000000..d288655b6cff > > --- /dev/null > > +++ b/drivers/phy/mediatek/phy-mtk-pcie.c > > @@ -0,0 +1,272 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (c) 2022 MediaTek Inc. > > + * Author: Jianjun Wang > > + */ > > + > > +#include > > +#include > > Why do you need this header I'll remove them in the next version, thanks. > > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "phy-mtk-io.h" > > + > > +#define PEXTP_ANA_GLB_00_REG 0x9000 > > +#define PEXTP_ANA_LN0_TRX_REG 0xa000 > > +#define PEXTP_ANA_TX_OFFSET 0x04 > > +#define PEXTP_ANA_RX_OFFSET 0x3c > > +#define PEXTP_ANA_LANE_OFFSET 0x100 > > + > > +/* PEXTP_GLB_00_REG[28:24] Internal Resistor Selection of TX Bias > > Current */ > > +#define EFUSE_GLB_INTR_SEL GENMASK(28, 24) > > +#define EFUSE_GLB_INTR_VAL(x) ((0x1f & (x)) << 24) > > There are nice macros in bitfield.h which you can use to set/get > value Thanks for the suggestion, that's really helpful, I'll replace them with the macros in bitfield.h. > > > + > > +/* PEXTP_ANA_LN_RX_REG[3:0] RX impedance selection */ > > +#define EFUSE_LN_RX_SEL GENMASK(3, 0) > > +#define EFUSE_LN_RX_VAL(x) (0xf & (x)) > > + > > +/* PEXTP_ANA_LN_TX_REG[5:2] TX PMOS impedance selection */ > > +#define EFUSE_LN_TX_PMOS_SEL GENMASK(5, 2) > > +#define EFUSE_LN_TX_PMOS_VAL(x) ((0xf & (x)) << 2) > > + > > +/* PEXTP_ANA_LN_TX_REG[11:8] TX NMOS impedance selection */ > > +#define EFUSE_LN_TX_NMOS_SEL GENMASK(11, 8) > > +#define EFUSE_LN_TX_NMOS_VAL(x) ((0xf & (x)) << 8) > > + > > +/** > > + * struct mtk_pcie_lane_efuse - eFuse data for each lane > > + * @tx_pmos: TX PMOS impedance selection data > > + * @tx_nmos: TX NMOS impedance selection data > > + * @rx_data: RX impedance selection data > > + * @lane_efuse_supported: software eFuse data is supported for > > this lane > > + */ > > +struct mtk_pcie_lane_efuse { > > + u32 tx_pmos; > > + u32 tx_nmos; > > + u32 rx_data; > > + bool lane_efuse_supported; > > +}; > > + > > +/** > > + * struct mtk_pcie_phy_data - phy data for each SoC > > + * @num_lanes: supported lane numbers > > + * @sw_efuse_supported: support software to load eFuse data > > + */ > > +struct mtk_pcie_phy_data { > > + int num_lanes; > > + bool sw_efuse_supported; > > +}; > > + > > +/** > > + * struct mtk_pcie_phy - PCIe phy driver main structure > > + * @dev: pointer to device > > + * @phy: pointer to generic phy > > + * @sif_base: IO mapped register base address of system interface > > + * @data: pointer to SoC dependent data > > + * @sw_efuse_en: software eFuse enable status > > + * @efuse_glb_intr: internal resistor selection of TX bias current > > data > > + * @efuse: pointer to eFuse data for each lane > > + */ > > +struct mtk_pcie_phy { > > + struct device *dev; > > + struct phy *phy; > > + void __iomem *sif_base; > > + const struct mtk_pcie_phy_data *data; > > + > > + bool sw_efuse_en; > > + u32 efuse_glb_intr; > > + struct mtk_pcie_lane_efuse *efuse; > > +}; > > + > > +static void mtk_pcie_efuse_set_lane(struct mtk_pcie_phy *pcie_phy, > > + unsigned int lane) > > +{ > > + struct mtk_pcie_lane_efuse *data = &pcie_phy->efuse[lane]; > > + void __iomem *addr; > > + > > + if (!data->lane_efuse_supported) > > + return; > > + > > + addr = pcie_phy->sif_base + PEXTP_ANA_LN0_TRX_REG + > > + lane * PEXTP_ANA_LANE_OFFSET; > > + > > + mtk_phy_update_bits(addr + PEXTP_ANA_TX_OFFSET, > > EFUSE_LN_TX_PMOS_SEL, > > + EFUSE_LN_TX_PMOS_VAL(data->tx_pmos)); > > + > > + mtk_phy_update_bits(addr + PEXTP_ANA_TX_OFFSET, > > EFUSE_LN_TX_NMOS_SEL, > > + EFUSE_LN_TX_NMOS_VAL(data->tx_nmos)); > > + > > + mtk_phy_update_bits(addr + PEXTP_ANA_RX_OFFSET, > > EFUSE_LN_RX_SEL, > > + EFUSE_LN_RX_VAL(data->rx_data)); > > +} > > + > > +/** > > + * mtk_pcie_phy_init() - Initialize the phy > > + * @phy: the phy to be initialized > > + * > > + * Initialize the phy by setting the efuse data. > > + * The hardware settings will be reset during suspend, it should > > be > > + * reinitialized when the consumer calls phy_init() again on > > resume. > > + */ > > +static int mtk_pcie_phy_init(struct phy *phy) > > +{ > > + struct mtk_pcie_phy *pcie_phy = phy_get_drvdata(phy); > > + int i; > > + > > + if (!pcie_phy->sw_efuse_en) > > + return 0; > > + > > + /* Set global data */ > > + mtk_phy_update_bits(pcie_phy->sif_base + PEXTP_ANA_GLB_00_REG, > > + EFUSE_GLB_INTR_SEL, > > + EFUSE_GLB_INTR_VAL(pcie_phy- > > >efuse_glb_intr)); > > + > > + for (i = 0; i < pcie_phy->data->num_lanes; i++) > > + mtk_pcie_efuse_set_lane(pcie_phy, i); > > + > > + return 0; > > +} > > + > > +static const struct phy_ops mtk_pcie_phy_ops = { > > + .init = mtk_pcie_phy_init, > > Only init for this phy? no power up/down either?? Yes, we only need this init to setting its efuse data. > > > > + .owner = THIS_MODULE, > > +}; > > + > > +static int mtk_pcie_efuse_read_for_lane(struct mtk_pcie_phy > > *pcie_phy, > > + unsigned int lane) > > +{ > > + struct mtk_pcie_lane_efuse *efuse = &pcie_phy->efuse[lane]; > > + struct device *dev = pcie_phy->dev; > > + char efuse_id[16]; > > + int ret; > > + > > + snprintf(efuse_id, sizeof(efuse_id), "tx_ln%d_pmos", lane); > > + ret = nvmem_cell_read_variable_le_u32(dev, efuse_id, &efuse- > > >tx_pmos); > > + if (ret) > > + return dev_err_probe(dev, ret, "Failed to read %s\n", > > efuse_id); > > + > > + snprintf(efuse_id, sizeof(efuse_id), "tx_ln%d_nmos", lane); > > + ret = nvmem_cell_read_variable_le_u32(dev, efuse_id, &efuse- > > >tx_nmos); > > + if (ret) > > + return dev_err_probe(dev, ret, "Failed to read %s\n", > > efuse_id); > > + > > + snprintf(efuse_id, sizeof(efuse_id), "rx_ln%d", lane); > > + ret = nvmem_cell_read_variable_le_u32(dev, efuse_id, &efuse- > > >rx_data); > > + if (ret) > > + return dev_err_probe(dev, ret, "Failed to read %s\n", > > efuse_id); > > + > > + if (!(efuse->tx_pmos || efuse->tx_nmos || efuse->rx_data)) > > + return dev_err_probe(dev, -EINVAL, > > + "No eFuse data found for lane%d, > > but dts enable it\n", > > + lane); > > + > > + efuse->lane_efuse_supported = true; > > + > > + return 0; > > +} > > + > > +static int mtk_pcie_read_efuse(struct mtk_pcie_phy *pcie_phy) > > +{ > > + struct device *dev = pcie_phy->dev; > > + bool nvmem_enabled; > > + int ret, i; > > + > > + /* nvmem data is optional */ > > + nvmem_enabled = device_property_read_bool(dev, "nvmem-cells"); > > + if (!nvmem_enabled) > > + return 0; > > + > > + ret = nvmem_cell_read_variable_le_u32(dev, "glb_intr", > > + &pcie_phy- > > >efuse_glb_intr); > > + if (ret) > > + return dev_err_probe(dev, ret, "Failed to read > > glb_intr\n"); > > + > > + pcie_phy->sw_efuse_en = true; > > + > > + pcie_phy->efuse = devm_kzalloc(dev, pcie_phy->data->num_lanes * > > + sizeof(*pcie_phy->efuse), > > GFP_KERNEL); > > + if (!pcie_phy->efuse) > > + return -ENOMEM; > > + > > + for (i = 0; i < pcie_phy->data->num_lanes; i++) { > > + ret = mtk_pcie_efuse_read_for_lane(pcie_phy, i); > > + if (ret) > > + return ret; > > + } > > + > > + return 0; > > +} > > + > > +static int mtk_pcie_phy_probe(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > + struct phy_provider *provider; > > + struct mtk_pcie_phy *pcie_phy; > > + int ret; > > + > > + pcie_phy = devm_kzalloc(dev, sizeof(*pcie_phy), GFP_KERNEL); > > + if (!pcie_phy) > > + return -ENOMEM; > > + > > + pcie_phy->sif_base = > > devm_platform_ioremap_resource_byname(pdev, "sif"); > > + if (IS_ERR(pcie_phy->sif_base)) > > + return dev_err_probe(dev, PTR_ERR(pcie_phy->sif_base), > > + "Failed to map phy-sif base\n"); > > + > > + pcie_phy->phy = devm_phy_create(dev, dev->of_node, > > &mtk_pcie_phy_ops); > > + if (IS_ERR(pcie_phy->phy)) > > + return dev_err_probe(dev, PTR_ERR(pcie_phy->phy), > > + "Failed to create PCIe phy\n"); > > + > > + pcie_phy->dev = dev; > > + pcie_phy->data = of_device_get_match_data(dev); > > + if (!pcie_phy->data) > > + return dev_err_probe(dev, -EINVAL, "Failed to get phy > > data\n"); > > + > > + if (pcie_phy->data->sw_efuse_supported) { > > + /* > > + * Failed to read the efuse data is not a fatal > > problem, > > + * ignore the failure and keep going. > > + */ > > + ret = mtk_pcie_read_efuse(pcie_phy); > > + if (ret == -EPROBE_DEFER) > > + return ret; > > + } > > + > > + phy_set_drvdata(pcie_phy->phy, pcie_phy); > > + > > + provider = devm_of_phy_provider_register(dev, > > of_phy_simple_xlate); > > + if (IS_ERR(provider)) > > + return dev_err_probe(dev, PTR_ERR(provider), > > + "PCIe phy probe failed\n"); > > + > > + return 0; > > +} > > + > > +static const struct mtk_pcie_phy_data mt8195_data = { > > + .num_lanes = 2, > > + .sw_efuse_supported = true, > > +}; > > + > > +static const struct of_device_id mtk_pcie_phy_of_match[] = { > > + { .compatible = "mediatek,mt8195-pcie-phy", .data = > > &mt8195_data }, > > + { }, > > +}; > > +MODULE_DEVICE_TABLE(of, mtk_pcie_phy_of_match); > > + > > +static struct platform_driver mtk_pcie_phy_driver = { > > + .probe = mtk_pcie_phy_probe, > > + .driver = { > > + .name = "mtk-pcie-phy", > > + .of_match_table = mtk_pcie_phy_of_match, > > + }, > > +}; > > +module_platform_driver(mtk_pcie_phy_driver); > > + > > +MODULE_DESCRIPTION("MediaTek PCIe PHY driver"); > > +MODULE_AUTHOR("Jianjun Wang "); > > +MODULE_LICENSE("GPL v2"); > > -- > > 2.18.0 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FFE5C433EF for ; Thu, 14 Apr 2022 08:55:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0T1FcbYvx3+EdlSa6AnAArd03e0NO61QdmKDuIBdcFM=; b=JVHT13MiUMeHZw HcYDOycchBNMjxZeoEmNuLbMZ3HD+0h14rYpICl+eyf0ljaYTcNyccQ0SiuxTy7UNbJWv89xdRRF/ k4DjRvV3TYUxO5c3a7MqjhI6ZWuFaNh1hiDWDdP9XXN5ClSzlwFflPDUTRR4h2NlT3WSDBZeS+VaT UtCZUgGlqougSIL7+ZOgzudVEn832A/AEfOH7c3Pnqvkg5mJQ6okMr7YpMSpKZP9G46eyTgQFtUPP VWdx0LVKyUGv19Z1TkbsrTpDVasMGlSdoVxSUbN1HB07avVmqx4LQ/tcHNaYXR+22U77mCzaVxiCn 2/hwMyKGzKIat1jG24Ew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nevFs-004fe6-9i; Thu, 14 Apr 2022 08:55:08 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nevCq-004e4G-6g; Thu, 14 Apr 2022 08:52:02 +0000 X-UUID: 04b8c43997604f6e8a22040795528e88-20220414 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=9M04+aqajnbMcV6zbu5Be4csDI5kkY3EpSWcWeczfwo=; b=b4Sj8n3RGb2vE5DbWoxpbr0DbR4SzVXA0fFz3MskIL/N75VyDdKEN8+RWAVYuVNioW5lvTdi/WnAq1b+Bl3TAlv8ah39z23eqkNw4hrwQ0h/DpPui8KLfEOD3A5HuGoeVOK5cX12/E+CEdVnvuksepkZO58pUilDrIZSSxBPZzk=; X-UUID: 04b8c43997604f6e8a22040795528e88-20220414 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1661945974; Thu, 14 Apr 2022 01:51:55 -0700 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 14 Apr 2022 01:50:15 -0700 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 14 Apr 2022 16:50:13 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 14 Apr 2022 16:50:12 +0800 Message-ID: Subject: Re: [PATCH v5 2/2] phy: mediatek: Add PCIe PHY driver From: Jianjun Wang To: Vinod Koul CC: Chunfeng Yun , Kishon Vijay Abraham I , Rob Herring , Matthias Brugger , Chen-Yu Tsai , "AngeloGioacchino Del Regno" , Krzysztof Kozlowski , Wei-Shun Chang , , , , , , , , , , , Date: Thu, 14 Apr 2022 16:50:12 +0800 In-Reply-To: References: <20220326022728.2969-1-jianjun.wang@mediatek.com> <20220326022728.2969-3-jianjun.wang@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220414_015200_356615_86A6FCEC X-CRM114-Status: GOOD ( 36.07 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, 2022-04-11 at 22:54 +0530, Vinod Koul wrote: > On 26-03-22, 10:27, Jianjun Wang wrote: > > Add PCIe GEN3 PHY driver support on MediaTek chipsets. > > > > Signed-off-by: Jianjun Wang > > Reviewed-by: AngeloGioacchino Del Regno < > > angelogioacchino.delregno@collabora.com> > > --- > > drivers/phy/mediatek/Kconfig | 11 ++ > > drivers/phy/mediatek/Makefile | 1 + > > drivers/phy/mediatek/phy-mtk-pcie.c | 272 > > ++++++++++++++++++++++++++++ > > 3 files changed, 284 insertions(+) > > create mode 100644 drivers/phy/mediatek/phy-mtk-pcie.c > > > > diff --git a/drivers/phy/mediatek/Kconfig > > b/drivers/phy/mediatek/Kconfig > > index 55f8e6c048ab..387ed1b3f2cc 100644 > > --- a/drivers/phy/mediatek/Kconfig > > +++ b/drivers/phy/mediatek/Kconfig > > @@ -55,3 +55,14 @@ config PHY_MTK_MIPI_DSI > > select GENERIC_PHY > > help > > Support MIPI DSI for Mediatek SoCs. > > + > > +config PHY_MTK_PCIE > > + tristate "MediaTek PCIe-PHY Driver" > > + depends on ARCH_MEDIATEK || COMPILE_TEST > > + depends on OF > > + select GENERIC_PHY > > + help > > + Say 'Y' here to add support for MediaTek PCIe PHY driver. > > + This driver create the basic PHY instance and provides > > initialize > > + callback for PCIe GEN3 port, it supports software efuse > > + initialization. > > diff --git a/drivers/phy/mediatek/Makefile > > b/drivers/phy/mediatek/Makefile > > index ace660fbed3a..788c13147f63 100644 > > --- a/drivers/phy/mediatek/Makefile > > +++ b/drivers/phy/mediatek/Makefile > > @@ -6,6 +6,7 @@ > > obj-$(CONFIG_PHY_MTK_TPHY) += phy-mtk-tphy.o > > obj-$(CONFIG_PHY_MTK_UFS) += phy-mtk-ufs.o > > obj-$(CONFIG_PHY_MTK_XSPHY) += phy-mtk-xsphy.o > > +obj-$(CONFIG_PHY_MTK_PCIE) += phy-mtk-pcie.o > > > > phy-mtk-hdmi-drv-y := phy-mtk-hdmi.o > > phy-mtk-hdmi-drv-y += phy-mtk-hdmi-mt2701.o > > diff --git a/drivers/phy/mediatek/phy-mtk-pcie.c > > b/drivers/phy/mediatek/phy-mtk-pcie.c > > new file mode 100644 > > index 000000000000..d288655b6cff > > --- /dev/null > > +++ b/drivers/phy/mediatek/phy-mtk-pcie.c > > @@ -0,0 +1,272 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (c) 2022 MediaTek Inc. > > + * Author: Jianjun Wang > > + */ > > + > > +#include > > +#include > > Why do you need this header I'll remove them in the next version, thanks. > > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "phy-mtk-io.h" > > + > > +#define PEXTP_ANA_GLB_00_REG 0x9000 > > +#define PEXTP_ANA_LN0_TRX_REG 0xa000 > > +#define PEXTP_ANA_TX_OFFSET 0x04 > > +#define PEXTP_ANA_RX_OFFSET 0x3c > > +#define PEXTP_ANA_LANE_OFFSET 0x100 > > + > > +/* PEXTP_GLB_00_REG[28:24] Internal Resistor Selection of TX Bias > > Current */ > > +#define EFUSE_GLB_INTR_SEL GENMASK(28, 24) > > +#define EFUSE_GLB_INTR_VAL(x) ((0x1f & (x)) << 24) > > There are nice macros in bitfield.h which you can use to set/get > value Thanks for the suggestion, that's really helpful, I'll replace them with the macros in bitfield.h. > > > + > > +/* PEXTP_ANA_LN_RX_REG[3:0] RX impedance selection */ > > +#define EFUSE_LN_RX_SEL GENMASK(3, 0) > > +#define EFUSE_LN_RX_VAL(x) (0xf & (x)) > > + > > +/* PEXTP_ANA_LN_TX_REG[5:2] TX PMOS impedance selection */ > > +#define EFUSE_LN_TX_PMOS_SEL GENMASK(5, 2) > > +#define EFUSE_LN_TX_PMOS_VAL(x) ((0xf & (x)) << 2) > > + > > +/* PEXTP_ANA_LN_TX_REG[11:8] TX NMOS impedance selection */ > > +#define EFUSE_LN_TX_NMOS_SEL GENMASK(11, 8) > > +#define EFUSE_LN_TX_NMOS_VAL(x) ((0xf & (x)) << 8) > > + > > +/** > > + * struct mtk_pcie_lane_efuse - eFuse data for each lane > > + * @tx_pmos: TX PMOS impedance selection data > > + * @tx_nmos: TX NMOS impedance selection data > > + * @rx_data: RX impedance selection data > > + * @lane_efuse_supported: software eFuse data is supported for > > this lane > > + */ > > +struct mtk_pcie_lane_efuse { > > + u32 tx_pmos; > > + u32 tx_nmos; > > + u32 rx_data; > > + bool lane_efuse_supported; > > +}; > > + > > +/** > > + * struct mtk_pcie_phy_data - phy data for each SoC > > + * @num_lanes: supported lane numbers > > + * @sw_efuse_supported: support software to load eFuse data > > + */ > > +struct mtk_pcie_phy_data { > > + int num_lanes; > > + bool sw_efuse_supported; > > +}; > > + > > +/** > > + * struct mtk_pcie_phy - PCIe phy driver main structure > > + * @dev: pointer to device > > + * @phy: pointer to generic phy > > + * @sif_base: IO mapped register base address of system interface > > + * @data: pointer to SoC dependent data > > + * @sw_efuse_en: software eFuse enable status > > + * @efuse_glb_intr: internal resistor selection of TX bias current > > data > > + * @efuse: pointer to eFuse data for each lane > > + */ > > +struct mtk_pcie_phy { > > + struct device *dev; > > + struct phy *phy; > > + void __iomem *sif_base; > > + const struct mtk_pcie_phy_data *data; > > + > > + bool sw_efuse_en; > > + u32 efuse_glb_intr; > > + struct mtk_pcie_lane_efuse *efuse; > > +}; > > + > > +static void mtk_pcie_efuse_set_lane(struct mtk_pcie_phy *pcie_phy, > > + unsigned int lane) > > +{ > > + struct mtk_pcie_lane_efuse *data = &pcie_phy->efuse[lane]; > > + void __iomem *addr; > > + > > + if (!data->lane_efuse_supported) > > + return; > > + > > + addr = pcie_phy->sif_base + PEXTP_ANA_LN0_TRX_REG + > > + lane * PEXTP_ANA_LANE_OFFSET; > > + > > + mtk_phy_update_bits(addr + PEXTP_ANA_TX_OFFSET, > > EFUSE_LN_TX_PMOS_SEL, > > + EFUSE_LN_TX_PMOS_VAL(data->tx_pmos)); > > + > > + mtk_phy_update_bits(addr + PEXTP_ANA_TX_OFFSET, > > EFUSE_LN_TX_NMOS_SEL, > > + EFUSE_LN_TX_NMOS_VAL(data->tx_nmos)); > > + > > + mtk_phy_update_bits(addr + PEXTP_ANA_RX_OFFSET, > > EFUSE_LN_RX_SEL, > > + EFUSE_LN_RX_VAL(data->rx_data)); > > +} > > + > > +/** > > + * mtk_pcie_phy_init() - Initialize the phy > > + * @phy: the phy to be initialized > > + * > > + * Initialize the phy by setting the efuse data. > > + * The hardware settings will be reset during suspend, it should > > be > > + * reinitialized when the consumer calls phy_init() again on > > resume. > > + */ > > +static int mtk_pcie_phy_init(struct phy *phy) > > +{ > > + struct mtk_pcie_phy *pcie_phy = phy_get_drvdata(phy); > > + int i; > > + > > + if (!pcie_phy->sw_efuse_en) > > + return 0; > > + > > + /* Set global data */ > > + mtk_phy_update_bits(pcie_phy->sif_base + PEXTP_ANA_GLB_00_REG, > > + EFUSE_GLB_INTR_SEL, > > + EFUSE_GLB_INTR_VAL(pcie_phy- > > >efuse_glb_intr)); > > + > > + for (i = 0; i < pcie_phy->data->num_lanes; i++) > > + mtk_pcie_efuse_set_lane(pcie_phy, i); > > + > > + return 0; > > +} > > + > > +static const struct phy_ops mtk_pcie_phy_ops = { > > + .init = mtk_pcie_phy_init, > > Only init for this phy? no power up/down either?? Yes, we only need this init to setting its efuse data. > > > > + .owner = THIS_MODULE, > > +}; > > + > > +static int mtk_pcie_efuse_read_for_lane(struct mtk_pcie_phy > > *pcie_phy, > > + unsigned int lane) > > +{ > > + struct mtk_pcie_lane_efuse *efuse = &pcie_phy->efuse[lane]; > > + struct device *dev = pcie_phy->dev; > > + char efuse_id[16]; > > + int ret; > > + > > + snprintf(efuse_id, sizeof(efuse_id), "tx_ln%d_pmos", lane); > > + ret = nvmem_cell_read_variable_le_u32(dev, efuse_id, &efuse- > > >tx_pmos); > > + if (ret) > > + return dev_err_probe(dev, ret, "Failed to read %s\n", > > efuse_id); > > + > > + snprintf(efuse_id, sizeof(efuse_id), "tx_ln%d_nmos", lane); > > + ret = nvmem_cell_read_variable_le_u32(dev, efuse_id, &efuse- > > >tx_nmos); > > + if (ret) > > + return dev_err_probe(dev, ret, "Failed to read %s\n", > > efuse_id); > > + > > + snprintf(efuse_id, sizeof(efuse_id), "rx_ln%d", lane); > > + ret = nvmem_cell_read_variable_le_u32(dev, efuse_id, &efuse- > > >rx_data); > > + if (ret) > > + return dev_err_probe(dev, ret, "Failed to read %s\n", > > efuse_id); > > + > > + if (!(efuse->tx_pmos || efuse->tx_nmos || efuse->rx_data)) > > + return dev_err_probe(dev, -EINVAL, > > + "No eFuse data found for lane%d, > > but dts enable it\n", > > + lane); > > + > > + efuse->lane_efuse_supported = true; > > + > > + return 0; > > +} > > + > > +static int mtk_pcie_read_efuse(struct mtk_pcie_phy *pcie_phy) > > +{ > > + struct device *dev = pcie_phy->dev; > > + bool nvmem_enabled; > > + int ret, i; > > + > > + /* nvmem data is optional */ > > + nvmem_enabled = device_property_read_bool(dev, "nvmem-cells"); > > + if (!nvmem_enabled) > > + return 0; > > + > > + ret = nvmem_cell_read_variable_le_u32(dev, "glb_intr", > > + &pcie_phy- > > >efuse_glb_intr); > > + if (ret) > > + return dev_err_probe(dev, ret, "Failed to read > > glb_intr\n"); > > + > > + pcie_phy->sw_efuse_en = true; > > + > > + pcie_phy->efuse = devm_kzalloc(dev, pcie_phy->data->num_lanes * > > + sizeof(*pcie_phy->efuse), > > GFP_KERNEL); > > + if (!pcie_phy->efuse) > > + return -ENOMEM; > > + > > + for (i = 0; i < pcie_phy->data->num_lanes; i++) { > > + ret = mtk_pcie_efuse_read_for_lane(pcie_phy, i); > > + if (ret) > > + return ret; > > + } > > + > > + return 0; > > +} > > + > > +static int mtk_pcie_phy_probe(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > + struct phy_provider *provider; > > + struct mtk_pcie_phy *pcie_phy; > > + int ret; > > + > > + pcie_phy = devm_kzalloc(dev, sizeof(*pcie_phy), GFP_KERNEL); > > + if (!pcie_phy) > > + return -ENOMEM; > > + > > + pcie_phy->sif_base = > > devm_platform_ioremap_resource_byname(pdev, "sif"); > > + if (IS_ERR(pcie_phy->sif_base)) > > + return dev_err_probe(dev, PTR_ERR(pcie_phy->sif_base), > > + "Failed to map phy-sif base\n"); > > + > > + pcie_phy->phy = devm_phy_create(dev, dev->of_node, > > &mtk_pcie_phy_ops); > > + if (IS_ERR(pcie_phy->phy)) > > + return dev_err_probe(dev, PTR_ERR(pcie_phy->phy), > > + "Failed to create PCIe phy\n"); > > + > > + pcie_phy->dev = dev; > > + pcie_phy->data = of_device_get_match_data(dev); > > + if (!pcie_phy->data) > > + return dev_err_probe(dev, -EINVAL, "Failed to get phy > > data\n"); > > + > > + if (pcie_phy->data->sw_efuse_supported) { > > + /* > > + * Failed to read the efuse data is not a fatal > > problem, > > + * ignore the failure and keep going. > > + */ > > + ret = mtk_pcie_read_efuse(pcie_phy); > > + if (ret == -EPROBE_DEFER) > > + return ret; > > + } > > + > > + phy_set_drvdata(pcie_phy->phy, pcie_phy); > > + > > + provider = devm_of_phy_provider_register(dev, > > of_phy_simple_xlate); > > + if (IS_ERR(provider)) > > + return dev_err_probe(dev, PTR_ERR(provider), > > + "PCIe phy probe failed\n"); > > + > > + return 0; > > +} > > + > > +static const struct mtk_pcie_phy_data mt8195_data = { > > + .num_lanes = 2, > > + .sw_efuse_supported = true, > > +}; > > + > > +static const struct of_device_id mtk_pcie_phy_of_match[] = { > > + { .compatible = "mediatek,mt8195-pcie-phy", .data = > > &mt8195_data }, > > + { }, > > +}; > > +MODULE_DEVICE_TABLE(of, mtk_pcie_phy_of_match); > > + > > +static struct platform_driver mtk_pcie_phy_driver = { > > + .probe = mtk_pcie_phy_probe, > > + .driver = { > > + .name = "mtk-pcie-phy", > > + .of_match_table = mtk_pcie_phy_of_match, > > + }, > > +}; > > +module_platform_driver(mtk_pcie_phy_driver); > > + > > +MODULE_DESCRIPTION("MediaTek PCIe PHY driver"); > > +MODULE_AUTHOR("Jianjun Wang "); > > +MODULE_LICENSE("GPL v2"); > > -- > > 2.18.0 > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2558C433EF for ; Thu, 14 Apr 2022 08:55:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2vKq9jiuYS0lX+NMqZyYAiYU2fLSGav10Qsulb7ZCXk=; b=1R4m0YEtuORPZi zUq6nnb1dtv2RIWu5GdTPcSHPTCwBd9ASeAbugLgSo+XQfO5b5O5cfsOEchySdd9NOBWnjQU3ay87 2dcOHKFnspqkE/leQo3t+WA6JlkUIKgVTTOiQLJaTvxzw8lT2q9yC9G793CdbAOWAe+bpEwFSsH3u aXmyWApMi/ECngi6LLwxM8a/P3FOhWgzRn6wQQrG9oB3mjfoVuG6x45SFcu5dn8O/2QLEvDXTg/VD Ad7sTmR2/71j9taQ0FgNvnTgq+ouRlfHTRBi8wI7XlGkfsK/SV3oErMb7A7EWNHQRxNDTRsWcbaRt W4/E623l7yhb3HfpvqCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nevFs-004fdt-1u; Thu, 14 Apr 2022 08:55:08 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nevCq-004e4G-6g; Thu, 14 Apr 2022 08:52:02 +0000 X-UUID: 04b8c43997604f6e8a22040795528e88-20220414 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=9M04+aqajnbMcV6zbu5Be4csDI5kkY3EpSWcWeczfwo=; b=b4Sj8n3RGb2vE5DbWoxpbr0DbR4SzVXA0fFz3MskIL/N75VyDdKEN8+RWAVYuVNioW5lvTdi/WnAq1b+Bl3TAlv8ah39z23eqkNw4hrwQ0h/DpPui8KLfEOD3A5HuGoeVOK5cX12/E+CEdVnvuksepkZO58pUilDrIZSSxBPZzk=; X-UUID: 04b8c43997604f6e8a22040795528e88-20220414 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1661945974; Thu, 14 Apr 2022 01:51:55 -0700 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 14 Apr 2022 01:50:15 -0700 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 14 Apr 2022 16:50:13 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 14 Apr 2022 16:50:12 +0800 Message-ID: Subject: Re: [PATCH v5 2/2] phy: mediatek: Add PCIe PHY driver From: Jianjun Wang To: Vinod Koul CC: Chunfeng Yun , Kishon Vijay Abraham I , Rob Herring , Matthias Brugger , Chen-Yu Tsai , "AngeloGioacchino Del Regno" , Krzysztof Kozlowski , Wei-Shun Chang , , , , , , , , , , , Date: Thu, 14 Apr 2022 16:50:12 +0800 In-Reply-To: References: <20220326022728.2969-1-jianjun.wang@mediatek.com> <20220326022728.2969-3-jianjun.wang@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220414_015200_356615_86A6FCEC X-CRM114-Status: GOOD ( 36.07 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Mon, 2022-04-11 at 22:54 +0530, Vinod Koul wrote: > On 26-03-22, 10:27, Jianjun Wang wrote: > > Add PCIe GEN3 PHY driver support on MediaTek chipsets. > > > > Signed-off-by: Jianjun Wang > > Reviewed-by: AngeloGioacchino Del Regno < > > angelogioacchino.delregno@collabora.com> > > --- > > drivers/phy/mediatek/Kconfig | 11 ++ > > drivers/phy/mediatek/Makefile | 1 + > > drivers/phy/mediatek/phy-mtk-pcie.c | 272 > > ++++++++++++++++++++++++++++ > > 3 files changed, 284 insertions(+) > > create mode 100644 drivers/phy/mediatek/phy-mtk-pcie.c > > > > diff --git a/drivers/phy/mediatek/Kconfig > > b/drivers/phy/mediatek/Kconfig > > index 55f8e6c048ab..387ed1b3f2cc 100644 > > --- a/drivers/phy/mediatek/Kconfig > > +++ b/drivers/phy/mediatek/Kconfig > > @@ -55,3 +55,14 @@ config PHY_MTK_MIPI_DSI > > select GENERIC_PHY > > help > > Support MIPI DSI for Mediatek SoCs. > > + > > +config PHY_MTK_PCIE > > + tristate "MediaTek PCIe-PHY Driver" > > + depends on ARCH_MEDIATEK || COMPILE_TEST > > + depends on OF > > + select GENERIC_PHY > > + help > > + Say 'Y' here to add support for MediaTek PCIe PHY driver. > > + This driver create the basic PHY instance and provides > > initialize > > + callback for PCIe GEN3 port, it supports software efuse > > + initialization. > > diff --git a/drivers/phy/mediatek/Makefile > > b/drivers/phy/mediatek/Makefile > > index ace660fbed3a..788c13147f63 100644 > > --- a/drivers/phy/mediatek/Makefile > > +++ b/drivers/phy/mediatek/Makefile > > @@ -6,6 +6,7 @@ > > obj-$(CONFIG_PHY_MTK_TPHY) += phy-mtk-tphy.o > > obj-$(CONFIG_PHY_MTK_UFS) += phy-mtk-ufs.o > > obj-$(CONFIG_PHY_MTK_XSPHY) += phy-mtk-xsphy.o > > +obj-$(CONFIG_PHY_MTK_PCIE) += phy-mtk-pcie.o > > > > phy-mtk-hdmi-drv-y := phy-mtk-hdmi.o > > phy-mtk-hdmi-drv-y += phy-mtk-hdmi-mt2701.o > > diff --git a/drivers/phy/mediatek/phy-mtk-pcie.c > > b/drivers/phy/mediatek/phy-mtk-pcie.c > > new file mode 100644 > > index 000000000000..d288655b6cff > > --- /dev/null > > +++ b/drivers/phy/mediatek/phy-mtk-pcie.c > > @@ -0,0 +1,272 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (c) 2022 MediaTek Inc. > > + * Author: Jianjun Wang > > + */ > > + > > +#include > > +#include > > Why do you need this header I'll remove them in the next version, thanks. > > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "phy-mtk-io.h" > > + > > +#define PEXTP_ANA_GLB_00_REG 0x9000 > > +#define PEXTP_ANA_LN0_TRX_REG 0xa000 > > +#define PEXTP_ANA_TX_OFFSET 0x04 > > +#define PEXTP_ANA_RX_OFFSET 0x3c > > +#define PEXTP_ANA_LANE_OFFSET 0x100 > > + > > +/* PEXTP_GLB_00_REG[28:24] Internal Resistor Selection of TX Bias > > Current */ > > +#define EFUSE_GLB_INTR_SEL GENMASK(28, 24) > > +#define EFUSE_GLB_INTR_VAL(x) ((0x1f & (x)) << 24) > > There are nice macros in bitfield.h which you can use to set/get > value Thanks for the suggestion, that's really helpful, I'll replace them with the macros in bitfield.h. > > > + > > +/* PEXTP_ANA_LN_RX_REG[3:0] RX impedance selection */ > > +#define EFUSE_LN_RX_SEL GENMASK(3, 0) > > +#define EFUSE_LN_RX_VAL(x) (0xf & (x)) > > + > > +/* PEXTP_ANA_LN_TX_REG[5:2] TX PMOS impedance selection */ > > +#define EFUSE_LN_TX_PMOS_SEL GENMASK(5, 2) > > +#define EFUSE_LN_TX_PMOS_VAL(x) ((0xf & (x)) << 2) > > + > > +/* PEXTP_ANA_LN_TX_REG[11:8] TX NMOS impedance selection */ > > +#define EFUSE_LN_TX_NMOS_SEL GENMASK(11, 8) > > +#define EFUSE_LN_TX_NMOS_VAL(x) ((0xf & (x)) << 8) > > + > > +/** > > + * struct mtk_pcie_lane_efuse - eFuse data for each lane > > + * @tx_pmos: TX PMOS impedance selection data > > + * @tx_nmos: TX NMOS impedance selection data > > + * @rx_data: RX impedance selection data > > + * @lane_efuse_supported: software eFuse data is supported for > > this lane > > + */ > > +struct mtk_pcie_lane_efuse { > > + u32 tx_pmos; > > + u32 tx_nmos; > > + u32 rx_data; > > + bool lane_efuse_supported; > > +}; > > + > > +/** > > + * struct mtk_pcie_phy_data - phy data for each SoC > > + * @num_lanes: supported lane numbers > > + * @sw_efuse_supported: support software to load eFuse data > > + */ > > +struct mtk_pcie_phy_data { > > + int num_lanes; > > + bool sw_efuse_supported; > > +}; > > + > > +/** > > + * struct mtk_pcie_phy - PCIe phy driver main structure > > + * @dev: pointer to device > > + * @phy: pointer to generic phy > > + * @sif_base: IO mapped register base address of system interface > > + * @data: pointer to SoC dependent data > > + * @sw_efuse_en: software eFuse enable status > > + * @efuse_glb_intr: internal resistor selection of TX bias current > > data > > + * @efuse: pointer to eFuse data for each lane > > + */ > > +struct mtk_pcie_phy { > > + struct device *dev; > > + struct phy *phy; > > + void __iomem *sif_base; > > + const struct mtk_pcie_phy_data *data; > > + > > + bool sw_efuse_en; > > + u32 efuse_glb_intr; > > + struct mtk_pcie_lane_efuse *efuse; > > +}; > > + > > +static void mtk_pcie_efuse_set_lane(struct mtk_pcie_phy *pcie_phy, > > + unsigned int lane) > > +{ > > + struct mtk_pcie_lane_efuse *data = &pcie_phy->efuse[lane]; > > + void __iomem *addr; > > + > > + if (!data->lane_efuse_supported) > > + return; > > + > > + addr = pcie_phy->sif_base + PEXTP_ANA_LN0_TRX_REG + > > + lane * PEXTP_ANA_LANE_OFFSET; > > + > > + mtk_phy_update_bits(addr + PEXTP_ANA_TX_OFFSET, > > EFUSE_LN_TX_PMOS_SEL, > > + EFUSE_LN_TX_PMOS_VAL(data->tx_pmos)); > > + > > + mtk_phy_update_bits(addr + PEXTP_ANA_TX_OFFSET, > > EFUSE_LN_TX_NMOS_SEL, > > + EFUSE_LN_TX_NMOS_VAL(data->tx_nmos)); > > + > > + mtk_phy_update_bits(addr + PEXTP_ANA_RX_OFFSET, > > EFUSE_LN_RX_SEL, > > + EFUSE_LN_RX_VAL(data->rx_data)); > > +} > > + > > +/** > > + * mtk_pcie_phy_init() - Initialize the phy > > + * @phy: the phy to be initialized > > + * > > + * Initialize the phy by setting the efuse data. > > + * The hardware settings will be reset during suspend, it should > > be > > + * reinitialized when the consumer calls phy_init() again on > > resume. > > + */ > > +static int mtk_pcie_phy_init(struct phy *phy) > > +{ > > + struct mtk_pcie_phy *pcie_phy = phy_get_drvdata(phy); > > + int i; > > + > > + if (!pcie_phy->sw_efuse_en) > > + return 0; > > + > > + /* Set global data */ > > + mtk_phy_update_bits(pcie_phy->sif_base + PEXTP_ANA_GLB_00_REG, > > + EFUSE_GLB_INTR_SEL, > > + EFUSE_GLB_INTR_VAL(pcie_phy- > > >efuse_glb_intr)); > > + > > + for (i = 0; i < pcie_phy->data->num_lanes; i++) > > + mtk_pcie_efuse_set_lane(pcie_phy, i); > > + > > + return 0; > > +} > > + > > +static const struct phy_ops mtk_pcie_phy_ops = { > > + .init = mtk_pcie_phy_init, > > Only init for this phy? no power up/down either?? Yes, we only need this init to setting its efuse data. > > > > + .owner = THIS_MODULE, > > +}; > > + > > +static int mtk_pcie_efuse_read_for_lane(struct mtk_pcie_phy > > *pcie_phy, > > + unsigned int lane) > > +{ > > + struct mtk_pcie_lane_efuse *efuse = &pcie_phy->efuse[lane]; > > + struct device *dev = pcie_phy->dev; > > + char efuse_id[16]; > > + int ret; > > + > > + snprintf(efuse_id, sizeof(efuse_id), "tx_ln%d_pmos", lane); > > + ret = nvmem_cell_read_variable_le_u32(dev, efuse_id, &efuse- > > >tx_pmos); > > + if (ret) > > + return dev_err_probe(dev, ret, "Failed to read %s\n", > > efuse_id); > > + > > + snprintf(efuse_id, sizeof(efuse_id), "tx_ln%d_nmos", lane); > > + ret = nvmem_cell_read_variable_le_u32(dev, efuse_id, &efuse- > > >tx_nmos); > > + if (ret) > > + return dev_err_probe(dev, ret, "Failed to read %s\n", > > efuse_id); > > + > > + snprintf(efuse_id, sizeof(efuse_id), "rx_ln%d", lane); > > + ret = nvmem_cell_read_variable_le_u32(dev, efuse_id, &efuse- > > >rx_data); > > + if (ret) > > + return dev_err_probe(dev, ret, "Failed to read %s\n", > > efuse_id); > > + > > + if (!(efuse->tx_pmos || efuse->tx_nmos || efuse->rx_data)) > > + return dev_err_probe(dev, -EINVAL, > > + "No eFuse data found for lane%d, > > but dts enable it\n", > > + lane); > > + > > + efuse->lane_efuse_supported = true; > > + > > + return 0; > > +} > > + > > +static int mtk_pcie_read_efuse(struct mtk_pcie_phy *pcie_phy) > > +{ > > + struct device *dev = pcie_phy->dev; > > + bool nvmem_enabled; > > + int ret, i; > > + > > + /* nvmem data is optional */ > > + nvmem_enabled = device_property_read_bool(dev, "nvmem-cells"); > > + if (!nvmem_enabled) > > + return 0; > > + > > + ret = nvmem_cell_read_variable_le_u32(dev, "glb_intr", > > + &pcie_phy- > > >efuse_glb_intr); > > + if (ret) > > + return dev_err_probe(dev, ret, "Failed to read > > glb_intr\n"); > > + > > + pcie_phy->sw_efuse_en = true; > > + > > + pcie_phy->efuse = devm_kzalloc(dev, pcie_phy->data->num_lanes * > > + sizeof(*pcie_phy->efuse), > > GFP_KERNEL); > > + if (!pcie_phy->efuse) > > + return -ENOMEM; > > + > > + for (i = 0; i < pcie_phy->data->num_lanes; i++) { > > + ret = mtk_pcie_efuse_read_for_lane(pcie_phy, i); > > + if (ret) > > + return ret; > > + } > > + > > + return 0; > > +} > > + > > +static int mtk_pcie_phy_probe(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > + struct phy_provider *provider; > > + struct mtk_pcie_phy *pcie_phy; > > + int ret; > > + > > + pcie_phy = devm_kzalloc(dev, sizeof(*pcie_phy), GFP_KERNEL); > > + if (!pcie_phy) > > + return -ENOMEM; > > + > > + pcie_phy->sif_base = > > devm_platform_ioremap_resource_byname(pdev, "sif"); > > + if (IS_ERR(pcie_phy->sif_base)) > > + return dev_err_probe(dev, PTR_ERR(pcie_phy->sif_base), > > + "Failed to map phy-sif base\n"); > > + > > + pcie_phy->phy = devm_phy_create(dev, dev->of_node, > > &mtk_pcie_phy_ops); > > + if (IS_ERR(pcie_phy->phy)) > > + return dev_err_probe(dev, PTR_ERR(pcie_phy->phy), > > + "Failed to create PCIe phy\n"); > > + > > + pcie_phy->dev = dev; > > + pcie_phy->data = of_device_get_match_data(dev); > > + if (!pcie_phy->data) > > + return dev_err_probe(dev, -EINVAL, "Failed to get phy > > data\n"); > > + > > + if (pcie_phy->data->sw_efuse_supported) { > > + /* > > + * Failed to read the efuse data is not a fatal > > problem, > > + * ignore the failure and keep going. > > + */ > > + ret = mtk_pcie_read_efuse(pcie_phy); > > + if (ret == -EPROBE_DEFER) > > + return ret; > > + } > > + > > + phy_set_drvdata(pcie_phy->phy, pcie_phy); > > + > > + provider = devm_of_phy_provider_register(dev, > > of_phy_simple_xlate); > > + if (IS_ERR(provider)) > > + return dev_err_probe(dev, PTR_ERR(provider), > > + "PCIe phy probe failed\n"); > > + > > + return 0; > > +} > > + > > +static const struct mtk_pcie_phy_data mt8195_data = { > > + .num_lanes = 2, > > + .sw_efuse_supported = true, > > +}; > > + > > +static const struct of_device_id mtk_pcie_phy_of_match[] = { > > + { .compatible = "mediatek,mt8195-pcie-phy", .data = > > &mt8195_data }, > > + { }, > > +}; > > +MODULE_DEVICE_TABLE(of, mtk_pcie_phy_of_match); > > + > > +static struct platform_driver mtk_pcie_phy_driver = { > > + .probe = mtk_pcie_phy_probe, > > + .driver = { > > + .name = "mtk-pcie-phy", > > + .of_match_table = mtk_pcie_phy_of_match, > > + }, > > +}; > > +module_platform_driver(mtk_pcie_phy_driver); > > + > > +MODULE_DESCRIPTION("MediaTek PCIe PHY driver"); > > +MODULE_AUTHOR("Jianjun Wang "); > > +MODULE_LICENSE("GPL v2"); > > -- > > 2.18.0 > > -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA4A1C433F5 for ; Thu, 14 Apr 2022 08:56:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HXDOX824TO5a+AdMGj4sB4wJ8VekFPRlY68eGYcb2OA=; b=1HrpxOd3brRwqi IwG0GYUognafGfANlq+BKnWnPb/VyOeIn4ccToIJEBDK8PfawzuvDp/AChEpWzGhxz/ed13nSS2N4 gtYBSGqsrnxvl2lCPntumE7FCP/2gUC98msnvIDuhLZeVeQJo42yzmjWbAblk+i88Mc88mqQTYqeh iMczbRQuSRJsmnz4xM0SeJWt2IhLaqFuuPjzgKnY16hcXdq97vweglAXTm2/HYnxgFA7lGRn41qAO /97U69d0s4SCWSsb+SdODdagBTAIqbFdLWXr+7dggJXz9OhjNx5s/qFtusmlNDeckcWOQj4IrVnDb 8natayOXD8ORN150DwqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nevFx-004ffb-BA; Thu, 14 Apr 2022 08:55:13 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nevCq-004e4G-6g; Thu, 14 Apr 2022 08:52:02 +0000 X-UUID: 04b8c43997604f6e8a22040795528e88-20220414 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=9M04+aqajnbMcV6zbu5Be4csDI5kkY3EpSWcWeczfwo=; b=b4Sj8n3RGb2vE5DbWoxpbr0DbR4SzVXA0fFz3MskIL/N75VyDdKEN8+RWAVYuVNioW5lvTdi/WnAq1b+Bl3TAlv8ah39z23eqkNw4hrwQ0h/DpPui8KLfEOD3A5HuGoeVOK5cX12/E+CEdVnvuksepkZO58pUilDrIZSSxBPZzk=; X-UUID: 04b8c43997604f6e8a22040795528e88-20220414 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1661945974; Thu, 14 Apr 2022 01:51:55 -0700 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 14 Apr 2022 01:50:15 -0700 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 14 Apr 2022 16:50:13 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 14 Apr 2022 16:50:12 +0800 Message-ID: Subject: Re: [PATCH v5 2/2] phy: mediatek: Add PCIe PHY driver From: Jianjun Wang To: Vinod Koul CC: Chunfeng Yun , Kishon Vijay Abraham I , Rob Herring , Matthias Brugger , Chen-Yu Tsai , "AngeloGioacchino Del Regno" , Krzysztof Kozlowski , Wei-Shun Chang , , , , , , , , , , , Date: Thu, 14 Apr 2022 16:50:12 +0800 In-Reply-To: References: <20220326022728.2969-1-jianjun.wang@mediatek.com> <20220326022728.2969-3-jianjun.wang@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220414_015200_356615_86A6FCEC X-CRM114-Status: GOOD ( 36.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2022-04-11 at 22:54 +0530, Vinod Koul wrote: > On 26-03-22, 10:27, Jianjun Wang wrote: > > Add PCIe GEN3 PHY driver support on MediaTek chipsets. > > > > Signed-off-by: Jianjun Wang > > Reviewed-by: AngeloGioacchino Del Regno < > > angelogioacchino.delregno@collabora.com> > > --- > > drivers/phy/mediatek/Kconfig | 11 ++ > > drivers/phy/mediatek/Makefile | 1 + > > drivers/phy/mediatek/phy-mtk-pcie.c | 272 > > ++++++++++++++++++++++++++++ > > 3 files changed, 284 insertions(+) > > create mode 100644 drivers/phy/mediatek/phy-mtk-pcie.c > > > > diff --git a/drivers/phy/mediatek/Kconfig > > b/drivers/phy/mediatek/Kconfig > > index 55f8e6c048ab..387ed1b3f2cc 100644 > > --- a/drivers/phy/mediatek/Kconfig > > +++ b/drivers/phy/mediatek/Kconfig > > @@ -55,3 +55,14 @@ config PHY_MTK_MIPI_DSI > > select GENERIC_PHY > > help > > Support MIPI DSI for Mediatek SoCs. > > + > > +config PHY_MTK_PCIE > > + tristate "MediaTek PCIe-PHY Driver" > > + depends on ARCH_MEDIATEK || COMPILE_TEST > > + depends on OF > > + select GENERIC_PHY > > + help > > + Say 'Y' here to add support for MediaTek PCIe PHY driver. > > + This driver create the basic PHY instance and provides > > initialize > > + callback for PCIe GEN3 port, it supports software efuse > > + initialization. > > diff --git a/drivers/phy/mediatek/Makefile > > b/drivers/phy/mediatek/Makefile > > index ace660fbed3a..788c13147f63 100644 > > --- a/drivers/phy/mediatek/Makefile > > +++ b/drivers/phy/mediatek/Makefile > > @@ -6,6 +6,7 @@ > > obj-$(CONFIG_PHY_MTK_TPHY) += phy-mtk-tphy.o > > obj-$(CONFIG_PHY_MTK_UFS) += phy-mtk-ufs.o > > obj-$(CONFIG_PHY_MTK_XSPHY) += phy-mtk-xsphy.o > > +obj-$(CONFIG_PHY_MTK_PCIE) += phy-mtk-pcie.o > > > > phy-mtk-hdmi-drv-y := phy-mtk-hdmi.o > > phy-mtk-hdmi-drv-y += phy-mtk-hdmi-mt2701.o > > diff --git a/drivers/phy/mediatek/phy-mtk-pcie.c > > b/drivers/phy/mediatek/phy-mtk-pcie.c > > new file mode 100644 > > index 000000000000..d288655b6cff > > --- /dev/null > > +++ b/drivers/phy/mediatek/phy-mtk-pcie.c > > @@ -0,0 +1,272 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (c) 2022 MediaTek Inc. > > + * Author: Jianjun Wang > > + */ > > + > > +#include > > +#include > > Why do you need this header I'll remove them in the next version, thanks. > > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "phy-mtk-io.h" > > + > > +#define PEXTP_ANA_GLB_00_REG 0x9000 > > +#define PEXTP_ANA_LN0_TRX_REG 0xa000 > > +#define PEXTP_ANA_TX_OFFSET 0x04 > > +#define PEXTP_ANA_RX_OFFSET 0x3c > > +#define PEXTP_ANA_LANE_OFFSET 0x100 > > + > > +/* PEXTP_GLB_00_REG[28:24] Internal Resistor Selection of TX Bias > > Current */ > > +#define EFUSE_GLB_INTR_SEL GENMASK(28, 24) > > +#define EFUSE_GLB_INTR_VAL(x) ((0x1f & (x)) << 24) > > There are nice macros in bitfield.h which you can use to set/get > value Thanks for the suggestion, that's really helpful, I'll replace them with the macros in bitfield.h. > > > + > > +/* PEXTP_ANA_LN_RX_REG[3:0] RX impedance selection */ > > +#define EFUSE_LN_RX_SEL GENMASK(3, 0) > > +#define EFUSE_LN_RX_VAL(x) (0xf & (x)) > > + > > +/* PEXTP_ANA_LN_TX_REG[5:2] TX PMOS impedance selection */ > > +#define EFUSE_LN_TX_PMOS_SEL GENMASK(5, 2) > > +#define EFUSE_LN_TX_PMOS_VAL(x) ((0xf & (x)) << 2) > > + > > +/* PEXTP_ANA_LN_TX_REG[11:8] TX NMOS impedance selection */ > > +#define EFUSE_LN_TX_NMOS_SEL GENMASK(11, 8) > > +#define EFUSE_LN_TX_NMOS_VAL(x) ((0xf & (x)) << 8) > > + > > +/** > > + * struct mtk_pcie_lane_efuse - eFuse data for each lane > > + * @tx_pmos: TX PMOS impedance selection data > > + * @tx_nmos: TX NMOS impedance selection data > > + * @rx_data: RX impedance selection data > > + * @lane_efuse_supported: software eFuse data is supported for > > this lane > > + */ > > +struct mtk_pcie_lane_efuse { > > + u32 tx_pmos; > > + u32 tx_nmos; > > + u32 rx_data; > > + bool lane_efuse_supported; > > +}; > > + > > +/** > > + * struct mtk_pcie_phy_data - phy data for each SoC > > + * @num_lanes: supported lane numbers > > + * @sw_efuse_supported: support software to load eFuse data > > + */ > > +struct mtk_pcie_phy_data { > > + int num_lanes; > > + bool sw_efuse_supported; > > +}; > > + > > +/** > > + * struct mtk_pcie_phy - PCIe phy driver main structure > > + * @dev: pointer to device > > + * @phy: pointer to generic phy > > + * @sif_base: IO mapped register base address of system interface > > + * @data: pointer to SoC dependent data > > + * @sw_efuse_en: software eFuse enable status > > + * @efuse_glb_intr: internal resistor selection of TX bias current > > data > > + * @efuse: pointer to eFuse data for each lane > > + */ > > +struct mtk_pcie_phy { > > + struct device *dev; > > + struct phy *phy; > > + void __iomem *sif_base; > > + const struct mtk_pcie_phy_data *data; > > + > > + bool sw_efuse_en; > > + u32 efuse_glb_intr; > > + struct mtk_pcie_lane_efuse *efuse; > > +}; > > + > > +static void mtk_pcie_efuse_set_lane(struct mtk_pcie_phy *pcie_phy, > > + unsigned int lane) > > +{ > > + struct mtk_pcie_lane_efuse *data = &pcie_phy->efuse[lane]; > > + void __iomem *addr; > > + > > + if (!data->lane_efuse_supported) > > + return; > > + > > + addr = pcie_phy->sif_base + PEXTP_ANA_LN0_TRX_REG + > > + lane * PEXTP_ANA_LANE_OFFSET; > > + > > + mtk_phy_update_bits(addr + PEXTP_ANA_TX_OFFSET, > > EFUSE_LN_TX_PMOS_SEL, > > + EFUSE_LN_TX_PMOS_VAL(data->tx_pmos)); > > + > > + mtk_phy_update_bits(addr + PEXTP_ANA_TX_OFFSET, > > EFUSE_LN_TX_NMOS_SEL, > > + EFUSE_LN_TX_NMOS_VAL(data->tx_nmos)); > > + > > + mtk_phy_update_bits(addr + PEXTP_ANA_RX_OFFSET, > > EFUSE_LN_RX_SEL, > > + EFUSE_LN_RX_VAL(data->rx_data)); > > +} > > + > > +/** > > + * mtk_pcie_phy_init() - Initialize the phy > > + * @phy: the phy to be initialized > > + * > > + * Initialize the phy by setting the efuse data. > > + * The hardware settings will be reset during suspend, it should > > be > > + * reinitialized when the consumer calls phy_init() again on > > resume. > > + */ > > +static int mtk_pcie_phy_init(struct phy *phy) > > +{ > > + struct mtk_pcie_phy *pcie_phy = phy_get_drvdata(phy); > > + int i; > > + > > + if (!pcie_phy->sw_efuse_en) > > + return 0; > > + > > + /* Set global data */ > > + mtk_phy_update_bits(pcie_phy->sif_base + PEXTP_ANA_GLB_00_REG, > > + EFUSE_GLB_INTR_SEL, > > + EFUSE_GLB_INTR_VAL(pcie_phy- > > >efuse_glb_intr)); > > + > > + for (i = 0; i < pcie_phy->data->num_lanes; i++) > > + mtk_pcie_efuse_set_lane(pcie_phy, i); > > + > > + return 0; > > +} > > + > > +static const struct phy_ops mtk_pcie_phy_ops = { > > + .init = mtk_pcie_phy_init, > > Only init for this phy? no power up/down either?? Yes, we only need this init to setting its efuse data. > > > > + .owner = THIS_MODULE, > > +}; > > + > > +static int mtk_pcie_efuse_read_for_lane(struct mtk_pcie_phy > > *pcie_phy, > > + unsigned int lane) > > +{ > > + struct mtk_pcie_lane_efuse *efuse = &pcie_phy->efuse[lane]; > > + struct device *dev = pcie_phy->dev; > > + char efuse_id[16]; > > + int ret; > > + > > + snprintf(efuse_id, sizeof(efuse_id), "tx_ln%d_pmos", lane); > > + ret = nvmem_cell_read_variable_le_u32(dev, efuse_id, &efuse- > > >tx_pmos); > > + if (ret) > > + return dev_err_probe(dev, ret, "Failed to read %s\n", > > efuse_id); > > + > > + snprintf(efuse_id, sizeof(efuse_id), "tx_ln%d_nmos", lane); > > + ret = nvmem_cell_read_variable_le_u32(dev, efuse_id, &efuse- > > >tx_nmos); > > + if (ret) > > + return dev_err_probe(dev, ret, "Failed to read %s\n", > > efuse_id); > > + > > + snprintf(efuse_id, sizeof(efuse_id), "rx_ln%d", lane); > > + ret = nvmem_cell_read_variable_le_u32(dev, efuse_id, &efuse- > > >rx_data); > > + if (ret) > > + return dev_err_probe(dev, ret, "Failed to read %s\n", > > efuse_id); > > + > > + if (!(efuse->tx_pmos || efuse->tx_nmos || efuse->rx_data)) > > + return dev_err_probe(dev, -EINVAL, > > + "No eFuse data found for lane%d, > > but dts enable it\n", > > + lane); > > + > > + efuse->lane_efuse_supported = true; > > + > > + return 0; > > +} > > + > > +static int mtk_pcie_read_efuse(struct mtk_pcie_phy *pcie_phy) > > +{ > > + struct device *dev = pcie_phy->dev; > > + bool nvmem_enabled; > > + int ret, i; > > + > > + /* nvmem data is optional */ > > + nvmem_enabled = device_property_read_bool(dev, "nvmem-cells"); > > + if (!nvmem_enabled) > > + return 0; > > + > > + ret = nvmem_cell_read_variable_le_u32(dev, "glb_intr", > > + &pcie_phy- > > >efuse_glb_intr); > > + if (ret) > > + return dev_err_probe(dev, ret, "Failed to read > > glb_intr\n"); > > + > > + pcie_phy->sw_efuse_en = true; > > + > > + pcie_phy->efuse = devm_kzalloc(dev, pcie_phy->data->num_lanes * > > + sizeof(*pcie_phy->efuse), > > GFP_KERNEL); > > + if (!pcie_phy->efuse) > > + return -ENOMEM; > > + > > + for (i = 0; i < pcie_phy->data->num_lanes; i++) { > > + ret = mtk_pcie_efuse_read_for_lane(pcie_phy, i); > > + if (ret) > > + return ret; > > + } > > + > > + return 0; > > +} > > + > > +static int mtk_pcie_phy_probe(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > + struct phy_provider *provider; > > + struct mtk_pcie_phy *pcie_phy; > > + int ret; > > + > > + pcie_phy = devm_kzalloc(dev, sizeof(*pcie_phy), GFP_KERNEL); > > + if (!pcie_phy) > > + return -ENOMEM; > > + > > + pcie_phy->sif_base = > > devm_platform_ioremap_resource_byname(pdev, "sif"); > > + if (IS_ERR(pcie_phy->sif_base)) > > + return dev_err_probe(dev, PTR_ERR(pcie_phy->sif_base), > > + "Failed to map phy-sif base\n"); > > + > > + pcie_phy->phy = devm_phy_create(dev, dev->of_node, > > &mtk_pcie_phy_ops); > > + if (IS_ERR(pcie_phy->phy)) > > + return dev_err_probe(dev, PTR_ERR(pcie_phy->phy), > > + "Failed to create PCIe phy\n"); > > + > > + pcie_phy->dev = dev; > > + pcie_phy->data = of_device_get_match_data(dev); > > + if (!pcie_phy->data) > > + return dev_err_probe(dev, -EINVAL, "Failed to get phy > > data\n"); > > + > > + if (pcie_phy->data->sw_efuse_supported) { > > + /* > > + * Failed to read the efuse data is not a fatal > > problem, > > + * ignore the failure and keep going. > > + */ > > + ret = mtk_pcie_read_efuse(pcie_phy); > > + if (ret == -EPROBE_DEFER) > > + return ret; > > + } > > + > > + phy_set_drvdata(pcie_phy->phy, pcie_phy); > > + > > + provider = devm_of_phy_provider_register(dev, > > of_phy_simple_xlate); > > + if (IS_ERR(provider)) > > + return dev_err_probe(dev, PTR_ERR(provider), > > + "PCIe phy probe failed\n"); > > + > > + return 0; > > +} > > + > > +static const struct mtk_pcie_phy_data mt8195_data = { > > + .num_lanes = 2, > > + .sw_efuse_supported = true, > > +}; > > + > > +static const struct of_device_id mtk_pcie_phy_of_match[] = { > > + { .compatible = "mediatek,mt8195-pcie-phy", .data = > > &mt8195_data }, > > + { }, > > +}; > > +MODULE_DEVICE_TABLE(of, mtk_pcie_phy_of_match); > > + > > +static struct platform_driver mtk_pcie_phy_driver = { > > + .probe = mtk_pcie_phy_probe, > > + .driver = { > > + .name = "mtk-pcie-phy", > > + .of_match_table = mtk_pcie_phy_of_match, > > + }, > > +}; > > +module_platform_driver(mtk_pcie_phy_driver); > > + > > +MODULE_DESCRIPTION("MediaTek PCIe PHY driver"); > > +MODULE_AUTHOR("Jianjun Wang "); > > +MODULE_LICENSE("GPL v2"); > > -- > > 2.18.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel