From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63C16C433DB for ; Thu, 28 Jan 2021 14:29:37 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 001EE64DDB for ; Thu, 28 Jan 2021 14:29:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 001EE64DDB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.77082.139417 (Exim 4.92) (envelope-from ) id 1l58IX-0005jy-T4; Thu, 28 Jan 2021 14:29:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 77082.139417; Thu, 28 Jan 2021 14:29:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l58IX-0005jr-Os; Thu, 28 Jan 2021 14:29:25 +0000 Received: by outflank-mailman (input) for mailman id 77082; Thu, 28 Jan 2021 14:29:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l58IW-0005jl-BS for xen-devel@lists.xenproject.org; Thu, 28 Jan 2021 14:29:24 +0000 Received: from mail-lj1-x22e.google.com (unknown [2a00:1450:4864:20::22e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f51559a6-5eca-45eb-93b3-c3423d804c3c; Thu, 28 Jan 2021 14:29:23 +0000 (UTC) Received: by mail-lj1-x22e.google.com with SMTP id y11so6579724ljk.1 for ; Thu, 28 Jan 2021 06:29:23 -0800 (PST) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id b24sm1710966lff.204.2021.01.28.06.29.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jan 2021 06:29:21 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f51559a6-5eca-45eb-93b3-c3423d804c3c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=yjs6PedjRi1tEV5PcSbTaYSabtBnHYKNtVuQh7L6+TE=; b=G/8YN6WHa301YdSq/PZii+CWMdxCFLRwvfWVTJGfF/ZBVeTmCeyVrrL++mq/rRduyH BVMJyMZknBjitBrvSe0+onDLV/SYHYP2/wAlZwRjoF8t8AqNEDPd4s7oz9WyQfd0DcMU H+2xsknb2uYEt+8mLCowVQ5ubDhHU+2RwltSbSnJk7KMLEl3oYTi6AFpijFBXNcEuCVH UKHw/8UxZx/+ll35Je92DS2wW0k1P/X6gN/Rjof9lVUr0HoOtzyp8PvRtcWOCkHmfEK2 EWIBsM82MC6PfVuStYDt71BJB6PuftYzKei0zNbOK1MXhfW2nJLsDThJrpkA9x8QPR3J 17Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=yjs6PedjRi1tEV5PcSbTaYSabtBnHYKNtVuQh7L6+TE=; b=r+fMUE5rOtntKXSKadhTK5gYuJiKE9SxTzZEabjbvgYJKVwpKgD6k2vN2oSft4i3ha 42GqKB3yucMzpRX6xh13f0FcBshQ4uaAI6teR7grd2Qxg9gDsvDsyCB+A4bp81QkM2ej nd9LrdNi7COBxtT1XCIdvY9OmBfP4d0VRklbTdBY4obbtBNUpgqXHvfN2VMwA5jy6AX4 Zf5WGK5dEuxf2VurCu3PI3VVhvjZJ/xKTv7jayn6dfF2pLk0TnWqGQVgEw3D9r2CxLSp D/bS6KNLvHojOvB9Es1JVw/UxGivvoAFljVtMEghmmwKfL4KKiic4cDmzCtOPf/9prmK cTvA== X-Gm-Message-State: AOAM5333dHjeFENW5oImw3+s7gFCKLL6ca50RYlCH+y5/PO2/856tN67 ZUotZ65A1OUm/H55IfifUgU= X-Google-Smtp-Source: ABdhPJzri9S9ipnHSxcG+b6xyZxEMGarOHBqNpLO06ORkp+2bLsP3XiTQps9KQn+6emFV0AArfUgGQ== X-Received: by 2002:a2e:850c:: with SMTP id j12mr9158890lji.298.1611844162030; Thu, 28 Jan 2021 06:29:22 -0800 (PST) Subject: Re: [PATCH V5 14/22] arm/ioreq: Introduce arch specific bits for IOREQ/DM features From: Oleksandr To: Julien Grall Cc: xen-devel@lists.xenproject.org, Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , Oleksandr Tyshchenko References: <1611601709-28361-1-git-send-email-olekstysh@gmail.com> <1611601709-28361-15-git-send-email-olekstysh@gmail.com> <67136393-8454-9d28-628a-bfb380fd8fc9@xen.org> <078a6aa6-2f72-d816-9e14-8132648d3370@gmail.com> Message-ID: Date: Thu, 28 Jan 2021 16:29:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Hi Julien On 28.01.21 15:39, Oleksandr wrote: > > On 28.01.21 13:33, Oleksandr wrote: > > Hi Julien > >> >> On 28.01.21 11:40, Julien Grall wrote: >> >> Hi Julien >> >>> Hi Oleksandr, >>> >>> On 27/01/2021 19:20, Oleksandr wrote: >>>  >  >>> So I think we may be able to drop the include from >>> asm/hvm/domain.h >>>> (this would avoid to include it everywhere...). >>>> >>>> I have tried that, but other CUs use definitions from >>>> public/hvm/dm_op.h, for example: >>>> >>>> p2m-pt.c: In function 'p2m_type_to_flags': >>>> p2m-pt.c:87:33: error: 'XEN_DMOP_IOREQ_MEM_ACCESS_WRITE' undeclared >>>> (first use in this function) >>>>           if ( p2m->ioreq.flags & XEN_DMOP_IOREQ_MEM_ACCESS_WRITE ) >>>>                                   ^ >>>> So, I would prefer to leave it as is, please let me know if you >>>> think otherwise. >>> >>> AFAICT, there is only 2 places (p2m-pt.c and p2m-ept.c) that >>> requires but doesn't directly include it. >>> Folding the diff below in patch #4 should do the job: >> >> ok, will do > > > Just to clarify, you mentioned about patch #4, but shouldn't we make > these changes in patch #9 which actually tries to sort dm related stuff? or a least in patch #8 which moves the stuff from asm-x86/hvm/domain.h to xen/ioreq.h (including the user of XEN_DMOP_IO_RANGE_PCI), what do you think? As for proposed changes, can confirm they work. > > >> >> >>> >>> diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c >>> index 975ab403f235..23d411f01d2f 100644 >>> --- a/xen/arch/x86/mm/p2m-ept.c >>> +++ b/xen/arch/x86/mm/p2m-ept.c >>> @@ -17,6 +17,7 @@ >>> >>>  #include >>>  #include >>> +#include >>>  #include >>>  #include >>>  #include >>> diff --git a/xen/arch/x86/mm/p2m-pt.c b/xen/arch/x86/mm/p2m-pt.c >>> index c43d5d0413a1..f2afcf49a368 100644 >>> --- a/xen/arch/x86/mm/p2m-pt.c >>> +++ b/xen/arch/x86/mm/p2m-pt.c >>> @@ -27,6 +27,7 @@ >>>  #include >>>  #include >>>  #include >>> +#include >>>  #include >>>  #include >>>  #include >>> diff --git a/xen/include/asm-x86/hvm/domain.h >>> b/xen/include/asm-x86/hvm/domain.h >>> index 3b36c2f41fa1..f26c1a2e2d5f 100644 >>> --- a/xen/include/asm-x86/hvm/domain.h >>> +++ b/xen/include/asm-x86/hvm/domain.h >>> @@ -28,8 +28,6 @@ >>>  #include >>>  #include >>> >>> -#include >>> - >>>  #ifdef CONFIG_MEM_SHARING >>>  struct mem_sharing_domain >>>  { >>> >>> You would then need to move the include of in >>> from this patch to patch #9. >> >> yes, sure >> >> -- Regards, Oleksandr Tyshchenko