From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B1DFC43218 for ; Tue, 11 Jun 2019 15:05:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E54D2080A for ; Tue, 11 Jun 2019 15:05:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E54D2080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59968 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haiLJ-0002l8-PQ for qemu-devel@archiver.kernel.org; Tue, 11 Jun 2019 11:05:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49120) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haiHI-0008NW-GG for qemu-devel@nongnu.org; Tue, 11 Jun 2019 11:01:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hai2U-000612-Ah for qemu-devel@nongnu.org; Tue, 11 Jun 2019 10:46:19 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:37179) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hai2U-000602-2i for qemu-devel@nongnu.org; Tue, 11 Jun 2019 10:46:18 -0400 Received: by mail-wm1-f65.google.com with SMTP id 22so3247641wmg.2 for ; Tue, 11 Jun 2019 07:46:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=u0pKX1Gpuq1szK531lu6VU6STfr7eTVlQOsvTQVcSwA=; b=mHfClt5PTvQVDC7SStP4w9IPF8AL74wHptQhC6pGAEEPXAnpI400cW+df6EIeW/Np1 8y9Vp92FOz9iG7waaBBSAL44eH91PlD9udC9tONkOXKE+Dn/Z1kWFjwdxbz4gVtD+Bj/ uhO5Man6nj5xFOujWYIJGWfzgibZXRkVDOv97W8ghdH2gUSVxtT99sPZcqjHRDeOuRq0 b6n5dJzpHKnjVk2Pv/Z+0wGyQHu/kxTuDCiW5EloQn4a4vUVRjQhwnQtCpBnHM1wX5PO 6F9tvHKYOsVQnN6rDKRypZCx7qrJkdVFpz2sbuKTY+7dP7TvBRR4XPRa33Q8FGY55bFm Hcow== X-Gm-Message-State: APjAAAXNhdw7IS9N47Aoz9iwB63QoPDtiSn97epY7RVEzpw2uCfuSHWt sMR5k9wJD5K+ZpXdg5oYBRimWw== X-Google-Smtp-Source: APXvYqyKHNzhon+NcT5y0BfDPPBRu2lxHZ/KtNuLRlvOqmu4hwVzqRNBfM/Anw4v5TJtweMX6iIKNA== X-Received: by 2002:a1c:208c:: with SMTP id g134mr18290611wmg.112.1560264376712; Tue, 11 Jun 2019 07:46:16 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:49d3:a711:c5a3:8ebf? ([2001:b07:6468:f312:49d3:a711:c5a3:8ebf]) by smtp.gmail.com with ESMTPSA id f10sm23198827wrg.24.2019.06.11.07.46.11 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 11 Jun 2019 07:46:16 -0700 (PDT) To: "wangjie (P)" , Michal Privoznik , qemu-devel@nongnu.org, qemu-block@nongnu.org References: <1559048796-57016-1-git-send-email-wangjie88@huawei.com> <4955ec04-1884-3a68-975f-8d72487c253c@huawei.com> From: Paolo Bonzini Message-ID: Date: Tue, 11 Jun 2019 16:46:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <4955ec04-1884-3a68-975f-8d72487c253c@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.128.65 Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] pr-manager-helper: fix pr process been killed when reconectting X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: eric.fangyi@huawei.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/06/19 15:51, wangjie (P) wrote: > Hi， Paolo and Michal： > > Base on my patch, I found another problem is that： > >     qemu: report DISCONNECTED > >     libvirt: start pr-helper #1, but it will takes a while to complete > this action > >     qemu: reconnect to start pr-helper #1 immediately and failed, so > report DISCONNECTED > >     libvirt: begin to call qemuProcessStartManagedPRDaemon to start > pr-helper #2, but virPidFileAcquirePath failed, so close fd and unlink > pidfile by mistake > > > based on the above problem, I thought out two ways to fix this problem: > > 1. qemu: when call pr_manager_helper_write failed, sleep one second to > make sure libvirt had started pr-helper before call > pr_manager_helper_initialize. > > 2. libvirt: if virFileLock failed in virPidFileAcquirePath, not to close > fd and unlink pidfile, because pr-helper #1 is using the pidfile. I think this could also be fixed by using the socket activation protocol in libvirt, because QEMU will be able to connect. libvirt will have to discard events from QMP right after it calls listen() on the socket. Paolo