From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D942C43334 for ; Mon, 13 Jun 2022 15:12:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242013AbiFMPMz (ORCPT ); Mon, 13 Jun 2022 11:12:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1386555AbiFMPMr (ORCPT ); Mon, 13 Jun 2022 11:12:47 -0400 X-Greylist: delayed 419 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 13 Jun 2022 05:27:08 PDT Received: from smtp-8fac.mail.infomaniak.ch (smtp-8fac.mail.infomaniak.ch [83.166.143.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89F3E113F83 for ; Mon, 13 Jun 2022 05:27:06 -0700 (PDT) Received: from smtp-3-0000.mail.infomaniak.ch (unknown [10.4.36.107]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4LM9cj5FsVzMpwtX; Mon, 13 Jun 2022 14:20:05 +0200 (CEST) Received: from ns3096276.ip-94-23-54.eu (unknown [23.97.221.149]) by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4LM9cd4MYKzlpb2d; Mon, 13 Jun 2022 14:20:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=digikod.net; s=20191114; t=1655122805; bh=P8NVyXj34ZvJVQWESPk01PC8KYswBLc2J5cBfxA5wlI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=aOumEP/IoqVDxckhdOnow8XBOtzF6rPUHSpjAaEiKv4s4qTv9+QazdFI/MV0sY9Oj WNcCDGC2NsIWSWr8htmOXQonlVhjqK6/U6g/yYRD9VTzd/JdIjpyOFwXcDvdlX4LMS ZPoJ0aNzkEJ9Yh+5Wu0QvJ3PdsdwNy2lAdCZDTxY= Message-ID: Date: Mon, 13 Jun 2022 14:20:00 +0200 MIME-Version: 1.0 User-Agent: Subject: Re: [PATCH 1/4] certs/blacklist_hashes.c: fix const confusion in certs blacklist Content-Language: en-US To: Masahiro Yamada , linux-kbuild@vger.kernel.org Cc: David Howells , Jarkko Sakkinen , David Woodhouse , keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Snowberg , Herbert Xu , Tyler Hicks References: <20220611172233.1494073-1-masahiroy@kernel.org> From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= In-Reply-To: <20220611172233.1494073-1-masahiroy@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: keyrings@vger.kernel.org On 11/06/2022 19:22, Masahiro Yamada wrote: > This file fails to compile as follows: > > CC certs/blacklist_hashes.o > certs/blacklist_hashes.c:4:1: error: ignoring attribute ‘section (".init.data")’ because it conflicts with previous ‘section (".init.rodata")’ [-Werror=attributes] > 4 | const char __initdata *const blacklist_hashes[] = { > | ^~~~~ > In file included from certs/blacklist_hashes.c:2: > certs/blacklist.h:5:38: note: previous declaration here > 5 | extern const char __initconst *const blacklist_hashes[]; > | ^~~~~~~~~~~~~~~~ > > Apply the same fix as commit 2be04df5668d ("certs/blacklist_nohashes.c: > fix const confusion in certs blacklist"). > > Fixes: 734114f8782f ("KEYS: Add a system blacklist keyring") > Signed-off-by: Masahiro Yamada Reviewed-by: Mickaël Salaün > --- > > certs/blacklist_hashes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/certs/blacklist_hashes.c b/certs/blacklist_hashes.c > index 344892337be0..d5961aa3d338 100644 > --- a/certs/blacklist_hashes.c > +++ b/certs/blacklist_hashes.c > @@ -1,7 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 > #include "blacklist.h" > > -const char __initdata *const blacklist_hashes[] = { > +const char __initconst *const blacklist_hashes[] = { > #include CONFIG_SYSTEM_BLACKLIST_HASH_LIST > , NULL > };