From: Reinette Chatre <reinette.chatre@intel.com>
To: James Morse <james.morse@arm.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Cc: Fenghua Yu <fenghua.yu@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
H Peter Anvin <hpa@zytor.com>, Babu Moger <Babu.Moger@amd.com>
Subject: Re: [PATCH v3 07/10] x86/resctrl: Add arch_needs_linear to explain AMD/Intel MBA difference
Date: Tue, 19 May 2020 11:03:14 -0700 [thread overview]
Message-ID: <ff095b21-023c-a3c6-2f6c-89c0e3d02eb3@intel.com> (raw)
In-Reply-To: <20200518131924.7741-8-james.morse@arm.com>
Hi James,
On 5/18/2020 6:19 AM, James Morse wrote:
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index dd51e23e346b..0b288b6fefd9 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -370,6 +370,7 @@ struct rdt_cache {
> * struct rdt_membw - Memory bandwidth allocation related data
> * @min_bw: Minimum memory bandwidth percentage user can request
> * @bw_gran: Granularity at which the memory bandwidth is allocated
> + * @arch_needs_linear: True if we can't configure non-linear resources
> * @delay_linear: True if memory B/W delay is in linear scale
> * @mba_sc: True if MBA software controller(mba_sc) is enabled
> * @mb_map: Mapping of memory B/W percentage to memory B/W delay
> @@ -378,6 +379,7 @@ struct rdt_membw {
> u32 min_bw;
> u32 bw_gran;
> u32 delay_linear;
> + bool arch_needs_linear;
> bool mba_sc;
> u32 *mb_map;
> };
>
Sorry, I just noticed this while rebasing our respective changes to this
area ... could the comments be in the same order as the fields in the
struct?
Reinette
next prev parent reply other threads:[~2020-05-19 18:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 13:19 [PATCH v3 00/10] x86/resctrl: Misc cleanup James Morse
2020-05-18 13:19 ` [PATCH v3 01/10] x86/resctrl: Nothing uses struct mbm_state chunks_bw James Morse
2020-05-18 13:19 ` [PATCH v3 02/10] x86/resctrl: Remove max_delay James Morse
2020-05-18 13:19 ` [PATCH v3 03/10] x86/resctrl: Fix stale comment James Morse
2020-05-18 13:19 ` [PATCH v3 04/10] x86/resctrl: use container_of() in delayed_work handlers James Morse
2020-05-18 13:19 ` [PATCH v3 05/10] x86/resctrl: Include pid.h James Morse
2020-05-18 13:19 ` [PATCH v3 06/10] x86/resctrl: Use is_closid_match() in more places James Morse
2020-05-18 13:19 ` [PATCH v3 07/10] x86/resctrl: Add arch_needs_linear to explain AMD/Intel MBA difference James Morse
2020-05-19 18:03 ` Reinette Chatre [this message]
2020-05-22 17:46 ` Babu Moger
2020-05-18 13:19 ` [PATCH v3 08/10] x86/resctrl: Merge AMD/Intel parse_bw() calls James Morse
2020-05-22 17:46 ` Babu Moger
2020-05-18 13:19 ` [PATCH v3 09/10] x86/resctrl: Add arch_has_{sparse,empty}_bitmaps to explain CAT differences James Morse
2020-05-19 18:55 ` Reinette Chatre
2020-05-22 17:47 ` Babu Moger
2020-05-18 13:19 ` [PATCH v3 10/10] cacheinfo: Move resctrl's get_cache_id() to the cacheinfo header file James Morse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff095b21-023c-a3c6-2f6c-89c0e3d02eb3@intel.com \
--to=reinette.chatre@intel.com \
--cc=Babu.Moger@amd.com \
--cc=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.