[Buildroot] [PATCH] package/qt5/qt5webengine: fix build error

["Bartosz Biłas" <b.bilas@grinn-global.com>]

Hi Peter,

On 7/30/19 11:30 PM, Peter Seiderer wrote:
> Hello Bartosz,
>
> On Tue, 30 Jul 2019 13:58:32 +0200, Bartosz Bilas <b.bilas@grinn-global.com> wrote:
>
>> This commit adds a patch from upstream chromium
>> and bumps required minimal gcc version to 8.
>>
>> Fixes:
>>    ../../3rdparty/chromium/third_party/skia/third_party/skcms/skcms.cc:1909:16:
>>    note: in definition of macro 'NS'
>>    #define NS(id) id
>>                  ^~
> Please paste some more lines of the failure, e.g. as the original:
>
> 	[102/12099] CXX obj/skia/skcms/skcms.o
> 	FAILED: obj/skia/skcms/skcms.o
> [...]
> 	../../3rdparty/chromium/third_party/skia/third_party/skcms/src/Transform_inl.h: In function ?void exec_ops(const Op*, const void**, const char*, char*, int)?:
> 	../../3rdparty/chromium/third_party/skia/third_party/skcms/src/Transform_inl.h:560:16: internal compiler error: in convert_move, at expr.c:231
> 	 static void NS(exec_ops)(const Op* ops, const void** args,
> 	                ^
> 	../../3rdparty/chromium/third_party/skia/third_party/skcms/skcms.cc:1909:16: note: in definition of macro ?NS?
> 	 #define NS(id) id
> 	                ^~
> 	Please submit a full bug report,
> 	with preprocessed source if appropriate.
> 	See <http://bugs.buildroot.net/> for instructions.
>
> As the intersting part is the 'internal compiler error'...
>
> Regards,
> Peter

That's all related to this error:

[1898/14080] CXX obj/skia/skcms/skcms.o
FAILED: obj/skia/skcms/skcms.o
/home/bbilas/projects/buildroot_projects/dev/buildroot-2019.05/output/host/bin/arm-buildroot-linux-gnueabihf-g++ 
-MMD -MF obj/skia/skcms/skcms.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV 
-DUSE_AURA=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DNO_TCMALLOC 
-DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL 
-DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DTOOLKIT_QT 
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE 
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS 
-DCR_SYSROOT_HASH=b2165ab47ab9c4cc780db53ace1b08607d68ae31 -DNDEBUG 
-DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen 
-I../../3rdparty/chromium -w -std=c11 -mfp16-format=ieee 
-fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector 
-Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= 
-funwind-tables -fPIC -pipe -pthread -march=armv7-a -mfloat-abi=hard 
-mtune=generic-armv7-a -mfpu=vfpv3-d16 -Wall -U_FORTIFY_SOURCE 
-D_FORTIFY_SOURCE=2 -Wno-psabi -Wno-unused-local-typedefs 
-Wno-maybe-uninitialized -Wno-deprecated-declarations 
-fno-delete-null-pointer-checks -Wno-comments -Wno-dangling-else 
-Wno-packed-not-aligned -Wno-missing-field-initializers 
-Wno-unused-parameter -O2 -fno-ident -fdata-sections -ffunction-sections 
-fno-omit-frame-pointer -g0 -fvisibility=hidden -std=gnu++14 
-Wno-narrowing -Wno-attributes -Wno-class-memaccess 
-Wno-subobject-linkage -fno-exceptions -fno-rtti 
--sysroot=../../../../../host/arm-buildroot-linux-gnueabihf/sysroot 
-fvisibility-inlines-hidden -c 
../../3rdparty/chromium/third_party/skia/third_party/skcms/skcms.cc -o 
obj/skia/skcms/skcms.o
../../3rdparty/chromium/third_party/skia/third_party/skcms/src/Transform_inl.h: 
In function ?void exec_ops(const Op*, const void**, const char*, char*, 
int)?:
../../3rdparty/chromium/third_party/skia/third_party/skcms/src/Transform_inl.h:560:16: 
internal compiler error: in convert_move, at expr.c:231
 ?static void NS(exec_ops)(const Op* ops, const void** args,
 ??????????????? ^
../../3rdparty/chromium/third_party/skia/third_party/skcms/skcms.cc:1909:16: 
note: in definition of macro ?NS?
 ?#define NS(id) id
 ??????????????? ^~
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://bugs.buildroot.net/> for instructions.
[1902/14080] CXX obj/skia/skia_core_and_effects/SkMipMap.o
ninja: build stopped: subcommand failed.


It's a bit weird because I've used the mentioned patch but I chose gcc 7 
and I encountered this error again but yesterday I made a clean build 
with gcc 5 and everything looked fine. Is there a posibility to run 
autobuilders with all suported gcc version to check if build succedded?

Best
Bartek
>
>> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
>> ---
>>   ...1-pkg_config-Fixes-when-use_sysroot-false.patch | 56 ++++++++++++++++++++++
>>   package/qt5/qt5webengine/Config.in                 |  6 +--
>>   2 files changed, 59 insertions(+), 3 deletions(-)
>>   create mode 100644 package/qt5/qt5webengine/5.12.4/0001-pkg_config-Fixes-when-use_sysroot-false.patch
>>
>> diff --git a/package/qt5/qt5webengine/5.12.4/0001-pkg_config-Fixes-when-use_sysroot-false.patch b/package/qt5/qt5webengine/5.12.4/0001-pkg_config-Fixes-when-use_sysroot-false.patch
>> new file mode 100644
>> index 0000000000..e5ffd19dd0
>> --- /dev/null
>> +++ b/package/qt5/qt5webengine/5.12.4/0001-pkg_config-Fixes-when-use_sysroot-false.patch
>> @@ -0,0 +1,56 @@
>> +From cc35cac78c053c14da01d6b1e5b05b0615360148 Mon Sep 17 00:00:00 2001
>> +From: Tom Anderson <thomasanderson@chromium.org>
>> +Date: Thu, 2 Aug 2018 01:59:28 +0000
>> +Subject: [PATCH] pkg_config: Fixes when use_sysroot=false
>> +
>> +This CL introduces 2 changes to the behavior of pkg_config when
>> +use_sysroot=false:
>> +
>> +1. The path is not made relative to the build directory.  This fixes the case
>> +where your src directory may be mounted at different locations.
>> +
>> +2. -I is used instead of -isystem.  When -isystem is used, dep files do not
>> +reference the system header files.  This is OK when using the sysroot because
>> +the CR_SYSROOT_HASH macro contains the sysroot revision so any source files will
>> +be rebuilt when the sysroot updates.
>> +
>> +R=dpranke
>> +
>> +Change-Id: Ia3d7df51880205fee888923283b76078ccb3112f
>> +Reviewed-on: https://chromium-review.googlesource.com/1159689
>> +Reviewed-by: Dirk Pranke <dpranke@chromium.org>
>> +Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
>> +Cr-Original-Commit-Position: refs/heads/master@{#580030}
>> +Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
>> +Cr-Mirrored-Commit: a8c8396fd20d98666d517c45b358c63736e345ef
>> +---
>> + src/3rdparty/chromium/build/config/linux/pkg_config.gni | 12 ++++++++----
>> + 1 file changed, 8 insertions(+), 4 deletions(-)
>> +
>> +diff --git a/src/3rdparty/chromium/build/config/linux/pkg_config.gni b/src/3rdparty/chromium/build/config/linux/pkg_config.gni
>> +index 53ee353af..428e44ac0 100644
>> +--- a/src/3rdparty/chromium/build/config/linux/pkg_config.gni
>> ++++ b/src/3rdparty/chromium/build/config/linux/pkg_config.gni
>> +@@ -103,11 +103,15 @@ template("pkg_config") {
>> +     pkgresult = exec_script(pkg_config_script, args, "value")
>> +     cflags = pkgresult[1]
>> +
>> +-    # We want the system include paths to use -isystem instead of -I to suppress
>> +-    # warnings in those headers.
>> +     foreach(include, pkgresult[0]) {
>> +-      include_relativized = rebase_path(include, root_build_dir)
>> +-      cflags += [ "-isystem$include_relativized" ]
>> ++      if (use_sysroot) {
>> ++        # We want the system include paths to use -isystem instead of -I to
>> ++        # suppress warnings in those headers.
>> ++        include_relativized = rebase_path(include, root_build_dir)
>> ++        cflags += [ "-isystem$include_relativized" ]
>> ++      } else {
>> ++        cflags += [ "-I$include" ]
>> ++      }
>> +     }
>> +
>> +     if (!defined(invoker.ignore_libs) || !invoker.ignore_libs) {
>> +--
>> +2.21.0
>> +
>> diff --git a/package/qt5/qt5webengine/Config.in b/package/qt5/qt5webengine/Config.in
>> index 744d659567..8102e39b0b 100644
>> --- a/package/qt5/qt5webengine/Config.in
>> +++ b/package/qt5/qt5webengine/Config.in
>> @@ -10,10 +10,10 @@ config BR2_PACKAGE_QT5WEBENGINE_ARCH_SUPPORTS
>>   	depends on !BR2_BINFMT_FLAT # qt5base-icu
>>   	depends on BR2_USE_MMU # libglib2, qt5base-dbus
>>   
>> -comment "qt5webengine needs udev /dev management and a glibc toolchain w/ gcc >= 4.8, host gcc >= 4.8, threads, wchar"
>> +comment "qt5webengine needs udev /dev management and a glibc toolchain w/ gcc >= 8, host gcc >= 4.8, threads, wchar"
>>   	depends on BR2_PACKAGE_QT5WEBENGINE_ARCH_SUPPORTS
>>   	depends on !BR2_PACKAGE_HAS_UDEV || !BR2_TOOLCHAIN_USES_GLIBC || \
>> -		!BR2_HOST_GCC_AT_LEAST_4_8 || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || \
>> +		!BR2_HOST_GCC_AT_LEAST_4_8 || !BR2_TOOLCHAIN_GCC_AT_LEAST_8 || \
>>   		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
>>   
>>   comment "qt5webengine needs an OpenGL and EGL-capable backend"
>> @@ -30,7 +30,7 @@ config BR2_PACKAGE_QT5WEBENGINE
>>   	depends on BR2_PACKAGE_QT5WEBENGINE_ARCH_SUPPORTS
>>   	depends on BR2_TOOLCHAIN_USES_GLIBC # execinfo.h, mallinfo
>>   	depends on BR2_HOST_GCC_AT_LEAST_4_8 # qt5base-icu
>> -	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # qt5base-icu
>> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_8 # qt5base-icu
>>   	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862 || BR2_PACKAGE_QT5_VERSION_5_6 # libnss
>>   	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2, libvpx, qt5base-dbus
>>   	depends on BR2_USE_WCHAR # libglib2
-- 
*BARTOSZ BI?AS*
Junior Software Developer 	GRINN
skype:
TEL.+48 71 716 40 99
WEB. grinn-global.com
	Grinn sp. z o.o.
Strzegomska 140a
54-429 Wroc?aw
	KRS:0000230049
NIP:8992730302
REGON:020047322 	S?d Rejonowy we Wroc?awiu
VI Wydzia? Gospodarczy
Kapita? zak?adowy: 125.000,00 z?


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190731/57dd692d/attachment.html>