From: Frederic Barrat <fbarrat@linux.vnet.ibm.com>
To: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org,
Michael Ellerman <mpe@ellerman.id.au>
Cc: Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
Christophe Lombard <christophe_lombard@fr.ibm.com>,
Philippe Bergheaud <philippe.bergheaud@fr.ibm.com>,
"Alastair D'Silva" <alastair@au1.ibm.com>
Subject: Re: [PATCH v2] cxl: Set the valid bit in PE for dedicated mode
Date: Mon, 4 Sep 2017 12:09:37 +0200 [thread overview]
Message-ID: <ff10e314-893c-54b6-2602-b834411b9560@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170904084825.22172-1-vaibhav@linux.vnet.ibm.com>
Le 04/09/2017 à 10:48, Vaibhav Jain a écrit :
> Make sure to set the valid-bit in software-state field of the
> populated PE. This was earlier missing for dedicated mode AFUs, hence
> was causing a PSL freeze when the AFU was activated.
>
> Signed-off-by: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>
> ---
> Changelog:
>
> v2 -> Removed a call to smp_wmb() after setting the bit [Michael Ellerman]
> ---
Acked-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>
>
> drivers/misc/cxl/native.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/misc/cxl/native.c b/drivers/misc/cxl/native.c
> index 4a82c313cf71..75df74d59527 100644
> --- a/drivers/misc/cxl/native.c
> +++ b/drivers/misc/cxl/native.c
> @@ -897,6 +897,14 @@ int cxl_attach_dedicated_process_psl9(struct cxl_context *ctx, u64 wed, u64 amr)
> if (ctx->afu->adapter->native->sl_ops->update_dedicated_ivtes)
> afu->adapter->native->sl_ops->update_dedicated_ivtes(ctx);
>
> + ctx->elem->software_state = cpu_to_be32(CXL_PE_SOFTWARE_STATE_V);
> + /*
> + * Ideally we should do a wmb() here to make sure the changes to the
> + * PE are visible to the card before we call afu_enable.
> + * On ppc64 though all mmios are preceded by a 'sync' instruction hence
> + * we dont dont need one here.
> + */
> +
> result = cxl_ops->afu_reset(afu);
> if (result)
> return result;
>
next prev parent reply other threads:[~2017-09-04 10:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 8:48 [PATCH v2] cxl: Set the valid bit in PE for dedicated mode Vaibhav Jain
2017-09-04 10:09 ` Frederic Barrat [this message]
2017-09-05 0:37 ` Andrew Donnellan
2017-10-05 4:21 ` [v2] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff10e314-893c-54b6-2602-b834411b9560@linux.vnet.ibm.com \
--to=fbarrat@linux.vnet.ibm.com \
--cc=alastair@au1.ibm.com \
--cc=andrew.donnellan@au1.ibm.com \
--cc=christophe_lombard@fr.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=philippe.bergheaud@fr.ibm.com \
--cc=vaibhav@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.