Re: [PATCH] sandbox: Remove OF_HOSTFILE

From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: "Tom Rini" <trini@konsulko.com>, "Pali Rohár" <pali@kernel.org>,
	"Marek Behún" <marek.behun@nic.cz>,
	"Bin Meng" <bmeng.cn@gmail.com>,
	"Chee Hong Ang" <chee.hong.ang@intel.com>,
	"Sean Anderson" <seanga2@gmail.com>,
	"Patrick Delaunay" <patrick.delaunay@foss.st.com>,
	"Joe Hershberger" <joe.hershberger@ni.com>,
	"Nicolas Saenz Julienne" <nsaenzjulienne@suse.de>,
	"Wasim Khan" <wasim.khan@nxp.com>,
	"AKASHI Takahiro" <takahiro.akashi@linaro.org>,
	"Etienne Carriere" <etienne.carriere@linaro.org>,
	"Alexandru Gagniuc" <mr.nuke.me@gmail.com>,
	"Nandor Han" <nandor.han@vaisala.com>,
	"Steffen Jaeckel" <jaeckel-floss@eyet-services.de>,
	"Heiko Schocher" <hs@denx.de>,
	"Asherah Connor" <ashe@kivikakk.ee>,
	"Andre Przywara" <andre.przywara@arm.com>,
	"U-Boot Mailing List" <u-boot@lists.denx.de>,
	"Simon Glass" <sjg@chromium.org>
Subject: Re: [PATCH] sandbox: Remove OF_HOSTFILE
Date: Wed, 29 Sep 2021 09:44:54 +0200	[thread overview]
Message-ID: <ff1148f0-7ca0-e039-f6e8-3232f623f0ff@gmx.de> (raw)
In-Reply-To: <YVQGynXzW95HnP4D@apalos.home>



On 9/29/21 08:25, Ilias Apalodimas wrote:
>>>> - */
>>>> -int sandbox_read_fdt_from_file(void);
>>>> -
>>>>   /**
>>>>    * sandbox_reset() - reset sandbox
>>>>    *
>>>> diff --git a/configs/sandbox64_defconfig b/configs/sandbox64_defconfig
>>>> index f7098b496983..358a6c168259 100644
>>>> --- a/configs/sandbox64_defconfig
>>>> +++ b/configs/sandbox64_defconfig
>>>> @@ -86,7 +86,7 @@ CONFIG_MAC_PARTITION=y
>>>>   CONFIG_AMIGA_PARTITION=y
>>>>   CONFIG_OF_CONTROL=y
>>>>   CONFIG_OF_LIVE=y
>>>> -CONFIG_OF_HOSTFILE=y
>>>> +CONFIG_OF_BOARD=y
>>>
>>> Can we put this in Kconfig instead, so it is enabled for all sandbox boards?
>>
>> Sure
>
> Looking at this again,  is this doable?  I remember 'select' being
> available only on bool or tristate options.  Is there another way?
>
> Cheers
> /Ilias
>

This will work:

diff --git a/dts/Kconfig b/dts/Kconfig
index dabe0080c1..6aca8a8738 100644
--- a/dts/Kconfig
+++ b/dts/Kconfig
@@ -90,6 +90,7 @@ config OF_LIVE
  choice
         prompt "Provider of DTB for DT control"
         depends on OF_CONTROL
+       default OF_BOARD if SANDBOX

  config OF_SEPARATE
         bool "Separate DTB for DT control"

Best regards

Heinrich
