From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755050Ab0BRNpn (ORCPT ); Thu, 18 Feb 2010 08:45:43 -0500 Received: from mail-fx0-f220.google.com ([209.85.220.220]:52908 "EHLO mail-fx0-f220.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753535Ab0BRNpm (ORCPT ); Thu, 18 Feb 2010 08:45:42 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=SxnImhcRwUU+Oeo3bxxuoFRduNRltx/ZA5eo6Cy/X7L//KVz7p7CxX/LeKTVU6KJp5 nkQAUAfeCKtBEHWyKs7DlHHkmlxe+YLhFHdIrCCQvfeRqPhvL0NV0t1eWL8WhBFDuEV0 aIf6GQALxT5iRTbTpAmAOXlVwG/kFf6wkGYLQ= MIME-Version: 1.0 In-Reply-To: <1266496346.26719.464.camel@laptop> References: <1266406962-17463-1-git-send-email-luca@luca-barbieri.com> <1266406962-17463-10-git-send-email-luca@luca-barbieri.com> <1266488742.26719.119.camel@laptop> <1266490846.26719.206.camel@laptop> <1266496346.26719.464.camel@laptop> Date: Thu, 18 Feb 2010 14:45:40 +0100 X-Google-Sender-Auth: 34dfc95a2011ebe0 Message-ID: Subject: Re: [PATCH 09/10] x86-32: use SSE for atomic64_read/set if available From: Luca Barbieri To: Peter Zijlstra Cc: mingo@elte.hu, hpa@zytor.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Depends on where on the stack you're going to save things, I through > you'd take space in the thread_info struct, but I guess if you're simply > going to push the reg onto the stack it should be fine. Yes, this seems the best solution. With frame pointers enabled, it's just a single andl $-8, %esp to align the stack (otherwise, frame pointers are forced by gcc).