From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F28EC4743D for ; Wed, 9 Jun 2021 01:06:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B17C260FDA for ; Wed, 9 Jun 2021 01:05:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B17C260FDA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49406 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqmfO-00036f-DP for qemu-devel@archiver.kernel.org; Tue, 08 Jun 2021 21:05:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqmeg-0002K6-03 for qemu-devel@nongnu.org; Tue, 08 Jun 2021 21:05:14 -0400 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]:35537) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqmed-0004Oj-7E for qemu-devel@nongnu.org; Tue, 08 Jun 2021 21:05:13 -0400 Received: by mail-pj1-x1034.google.com with SMTP id fy24-20020a17090b0218b029016c5a59021fso423127pjb.0 for ; Tue, 08 Jun 2021 18:05:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=EeVrr4AEboVATcF3XpcHFIKof1+wOaT0mQCL24NqF1U=; b=h+7Cyw0dGf5wAxpUcOETmWo7QHrqShh70aaquqa1KiAGm5AJEg1tM9g1G23j3fuzLa 16kxpa5hih8pPLZzmm4/YAJd9GfBjpWsEFSAQSZVGuxhwN1Pd3RWdn+MWfe4qFh92vDY DJdsqwJhlDfaVD8FvMZdks81I0fIKHMiMz1pCL0XkRpPsNN6Oi+FjRyph7tUwpNYMZkc vn+RCLrbDm+NOTlPZdvNIQ0VDwcSPSxsH1ok9ryvEuRAs/XArh43S4K0Px/AxRIpg4Wm vIIEgnpeirlCd+AuN3CUQXevAciLMbgRtztPpzWPOH0/qsz4OLeqYMiSAgElVA2PwCBD ppsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EeVrr4AEboVATcF3XpcHFIKof1+wOaT0mQCL24NqF1U=; b=eoHGAU223qys53UYW7mBNYf21kLFMKT0hgksHSCAwxIqzBNE5Ex8y6+U19tFi4Oehv nI4komewBHIkT+CzOoTZNxbHGRR7AjOuC+QwVkvI+YtjcIl/gW1PITdgB9PDOp3hOgsF 0fNal0aIm93q+WUDphUoFVkdhRVgSDC/22YW+vqGcqvEsCzzfM/QM4zT1hqzqaFd6Qfk W8aIT5ROj5t5Cc/Gp29ZAOxAasxO+M9GH+eUXbk+SYNEbtBHBipbYm1GTWBDll3W7MDi Y/gU0pJzOfa98CQPuUPr5p9DOKkoPhx2nKYRnF9O6aASIgnAbD5o+tWXg3en2mVseVW3 xwfg== X-Gm-Message-State: AOAM530OBGVIakSgQgbYmuXSQ/CPnCxx2ITBEYXNDbdfiBDFqNFxgVUX UzgeZd0D0rGuF7W5UkG4VhbTVsdGFRauAw== X-Google-Smtp-Source: ABdhPJyidEoH6Gl1nh7/sNDyjwkZnkRgsu5sAx9SvZQe2qMSCfJqnkgMNMnySJ+teMQM36usqYLTlA== X-Received: by 2002:a17:90a:e60d:: with SMTP id j13mr28040837pjy.112.1623200709352; Tue, 08 Jun 2021 18:05:09 -0700 (PDT) Received: from [192.168.1.11] (174-21-70-228.tukw.qwest.net. [174.21.70.228]) by smtp.gmail.com with ESMTPSA id o9sm12653074pfh.217.2021.06.08.18.05.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Jun 2021 18:05:08 -0700 (PDT) Subject: Re: [PATCH 32/55] target/arm: Implement MVE VRMLALDAVH, VRMLSLDAVH To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20210607165821.9892-1-peter.maydell@linaro.org> <20210607165821.9892-33-peter.maydell@linaro.org> From: Richard Henderson Message-ID: Date: Tue, 8 Jun 2021 18:05:07 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210607165821.9892-33-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1034; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1034.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/7/21 9:57 AM, Peter Maydell wrote: > +#define DO_LDAVH(OP, ESIZE, TYPE, H, XCHG, EVENACC, ODDACC, TO128) \ > + uint64_t HELPER(glue(mve_, OP))(CPUARMState *env, void *vn, \ > + void *vm, uint64_t a) \ > + { \ > + uint16_t mask = mve_element_mask(env); \ > + unsigned e; \ > + TYPE *n = vn, *m = vm; \ > + Int128 acc = TO128(a); \ This seems to miss the << 8. Which suggests that the whole thing can be done without Int128: > + for (e = 0; e < 16 / ESIZE; e++, mask >>= ESIZE) { \ > + if (mask & 1) { \ > + if (e & 1) { \ > + acc = ODDACC(acc, TO128(n[H(e - 1 * XCHG)] * m[H(e)])); \ tmp = n * m; tmp = (tmp >> 8) + ((tmp >> 7) & 1); acc ODDACC tmp; > +static bool trans_VRMLALDAVH_S(DisasContext *s, arg_vmlaldav *a) > +{ > + MVEGenDualAccOpFn *fns[] = { static const, etc. r~