From: Alexander Graf <graf@amazon.com>
To: Liran Alon <liran.alon@oracle.com>
Cc: "kvm list" <kvm@vger.kernel.org>,
linux-kernel@vger.kernel.org, x86@kernel.org,
"H. Peter Anvin" <hpa@zytor.com>,
"Borislav Petkov" <bp@alien8.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Joerg Roedel" <joro@8bytes.org>,
"Jim Mattson" <jmattson@google.com>,
"Wanpeng Li" <wanpengli@tencent.com>,
"Vitaly Kuznetsov" <vkuznets@redhat.com>,
"Sean Christopherson" <sean.j.christopherson@intel.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH 2/2] KVM: SVM: Disable posted interrupts for odd IRQs
Date: Wed, 4 Sep 2019 15:06:05 +0200 [thread overview]
Message-ID: <ff1bad8b-31dc-042b-7b90-ccc31e1a80de@amazon.com> (raw)
In-Reply-To: <7AEDDBE7-138A-455F-957C-C2DE64BD8B06@oracle.com>
On 04.09.19 01:20, Liran Alon wrote:
>
>
>> On 3 Sep 2019, at 17:29, Alexander Graf <graf@amazon.com> wrote:
>>
>> We can easily route hardware interrupts directly into VM context when
>> they target the "Fixed" or "LowPriority" delivery modes.
>>
>> However, on modes such as "SMI" or "Init", we need to go via KVM code
>> to actually put the vCPU into a different mode of operation, so we can
>> not post the interrupt
>>
>> Add code in the SVM PI logic to explicitly refuse to establish posted
>> mappings for advanced IRQ deliver modes.
>>
>> This fixes a bug I have with code which configures real hardware to
>> inject virtual SMIs into my guest.
>>
>> Signed-off-by: Alexander Graf <graf@amazon.com>
>
> Nit: I prefer to squash both commits into one that change both VMX & SVM.
> As it’s exactly the same change.
It's the same change (hence the same patch set), but they touch
different files and so for bisectability it's still convenient to have
them as different commits. I'd really prefer to have them stay separate.
Thanks a lot for the review! :)
Alex
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Ralf Herbrich
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
prev parent reply other threads:[~2019-09-04 13:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 14:29 [PATCH 0/2] KVM: Only use posted interrupts for Fixes/LowPrio MSIs Alexander Graf
2019-09-03 14:29 ` [PATCH 1/2] KVM: VMX: Disable posted interrupts for odd IRQs Alexander Graf
2019-09-03 23:15 ` Liran Alon
2019-09-03 14:29 ` [PATCH 2/2] KVM: SVM: " Alexander Graf
2019-09-03 23:20 ` Liran Alon
2019-09-04 13:06 ` Alexander Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff1bad8b-31dc-042b-7b90-ccc31e1a80de@amazon.com \
--to=graf@amazon.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liran.alon@oracle.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.