From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 10/24] ethdev: parse ethertype filter
Date: Tue, 20 Dec 2016 18:12:15 +0000
Message-ID: <ff1ef72f-7397-a7d0-071f-ff18be979bf6@intel.com>
References: <1480679625-4157-1-git-send-email-beilei.xing@intel.com>
 <1480679625-4157-11-git-send-email-beilei.xing@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, wenzhuo.lu@intel.com,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Beilei Xing <beilei.xing@intel.com>, jingjing.wu@intel.com,
 helin.zhang@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 1B82CFBB0
 for <dev@dpdk.org>; Tue, 20 Dec 2016 19:12:18 +0100 (CET)
In-Reply-To: <1480679625-4157-11-git-send-email-beilei.xing@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/2/2016 11:53 AM, Beilei Xing wrote:
> Check if the rule is a ethertype rule, and get the ethertype
> info BTW.
> 
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> ---

CC: Adrien Mazarguil <adrien.mazarguil@6wind.com>

>  lib/librte_ether/rte_flow.c        | 136 +++++++++++++++++++++++++++++++++++++
>  lib/librte_ether/rte_flow_driver.h |  34 ++++++++++

<...>

> diff --git a/lib/librte_ether/rte_flow_driver.h b/lib/librte_ether/rte_flow_driver.h
> index a88c621..2760c74 100644
> --- a/lib/librte_ether/rte_flow_driver.h
> +++ b/lib/librte_ether/rte_flow_driver.h
> @@ -170,6 +170,40 @@ rte_flow_error_set(struct rte_flow_error *error,
>  const struct rte_flow_ops *
>  rte_flow_ops_get(uint8_t port_id, struct rte_flow_error *error);
>  
> +int cons_parse_ethertype_filter(const struct rte_flow_attr *attr,
> +			    const struct rte_flow_item *pattern,
> +			    const struct rte_flow_action *actions,
> +			    struct rte_eth_ethertype_filter *filter,
> +			    struct rte_flow_error *error);

Although this is helper function, it may be good if it follows the
rte_follow namespace.

> +
> +#define PATTERN_SKIP_VOID(filter, filter_struct, error_type)		\
> +	do {								\
> +		if (!pattern) {						\
> +			memset(filter, 0, sizeof(filter_struct));	\
> +			error->type = error_type;                       \
> +			return -EINVAL;					\
> +		}							\
> +		item = pattern + i;					\

I believe macros that relies on variables that not passed as argument is
not good idea.

> +		while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {		\
> +			i++;						\
> +			item = pattern + i;				\
> +		}							\
> +	} while (0)
> +
> +#define ACTION_SKIP_VOID(filter, filter_struct, error_type)		\
> +	do {								\
> +		if (!actions) {						\
> +			memset(filter, 0, sizeof(filter_struct));	\
> +			error->type = error_type;			\
> +			return -EINVAL;					\
> +		}							\
> +		act = actions + i;					\
> +		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {	\
> +			i++;						\
> +			act = actions + i;				\
> +		}							\
> +	} while (0)

Are these macros generic enough for all rte_flow consumers?

What do you think separate this patch, and use these after applied,
meanwhile keeping function and MACROS PMD internal?

> +
>  #ifdef __cplusplus
>  }
>  #endif
>